Concurrency bug in Tempest test "test_list_shares_with_detail_filter_by_extra_specs"

[Valeriy Ponomaryov]

Tempest fails with following error from time to time:

"""

Traceback (most recent call last):
  File "/opt/stack/new/manila/manila_tempest_tests/tests/api/admin/test_shares_actions.py", line 190, in test_list_shares_with_detail_filter_by_extra_specs
    "s_id": share["id"], "st": share["share_type"]}
ValueError: Share 'cdd499f7-6b02-4f47-8b39-7093b4d07e11' listed with extra_specs filter has nonexistent share type 'share-type-1283899337'.

"""

CI logs: http://logs.openstack.org/56/220956/3/check/gate-manila-tempest-dsvm-neutron/3015de9/logs/testr_results.html.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221236

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221236
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=06e957844732682c549814babb6a28d6962131c6
Submitter: Jenkins
Branch: master

commit 06e957844732682c549814babb6a28d6962131c6
Author: Valeriy Ponomaryov <email address hidden>
Date: Tue Sep 8 13:19:15 2015 +0300

    Fix concurrency issue in tempest test

    Tempest test 'test_list_shares_with_detail_filter_by_extra_specs' fails
    with following error from time to time:

    ValueError: Share 'cdd499f7-6b02-4f47-8b39-7093b4d07e11' listed with
    extra_specs filter has nonexistent share type 'share-type-1283899337'.

    It happens because list of share types is taken for each step of a loop
    Get list of share types only once and before taking list of shares, in
    that case we will have share objects with still existing share types.

    Change-Id: I0c29d16385255599b902757544e31ebbec79ca84
    Closes-Bug: #1493125