Do not allow to modify access for public share type

Bug #1490912 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
zhongjun

Bug Description

Do not allow to modify access for public share type

Now public share type can be removed project access, but when
listing access, manila returns 'Access list not available for public
share types.' It's weird for users experience.
We should check if a type is public and do not allow public share type
to modify project access.
APIImpact
When modifying access for public share type, API will return 400 and message:
"Invalid share type: Type access modification is not applicable to public
share type."

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219213

Changed in manila:
assignee: nobody → zhongjun (jun-zhongjun)
status: New → In Progress
Changed in manila:
importance: Undecided → Low
zhongjun (jun-zhongjun)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/219213
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f041606cb4f5def4837387812c6b4f379c857255
Submitter: Jenkins
Branch: master

commit f041606cb4f5def4837387812c6b4f379c857255
Author: zhongjun <email address hidden>
Date: Tue Sep 1 18:10:06 2015 +0800

    Do not allow to modify access for public share type

    Now public share type can be removed project access, but when
    listing access, manila returns 'Access list not available for public
    share types'. It's weird for users experience.

    We should check if a type is public and do not allow public share type
    to modify project access.

    APIImpact
    When modifying access for public share type, API will return 409 and message:
    "Invalid share type: Type access modification is not applicable to public
    share type."

    Change-Id: I94f580eeb7eef4263c631227cc3710eeae2b9706
    Closes-Bug: #1490912

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.