Tempest tests targeting user based rules issue

Bug #1489359 reported by Alin Balutoiu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Alin Balutoiu

Bug Description

The helper method "_create_delete_ro_access_rule" used by the tests targeting user rules will actually create ip based rules.

https://github.com/openstack/manila/blob/master/contrib/tempest/tempest/api/share/test_rules.py#L26

This can easily be fixed by using the access_type and access_to attributes instead of the hardcoded values.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217623

Changed in manila:
assignee: nobody → Alin Balutoiu (abalutoiu)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/217623
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=641a5e985e058013b10c420792a5e7bed3245599
Submitter: Jenkins
Branch: master

commit 641a5e985e058013b10c420792a5e7bed3245599
Author: Alin Balutoiu <email address hidden>
Date: Thu Aug 27 12:34:23 2015 +0300

    Fix Tempest tests targeting user based access rules

    The helper method "_create_delete_ro_access_rule" used by the tests
    targeting user rules will actually create ip based rules.

    This can easily be fixed by using the access_type and access_to
    attributes instead of the hardcoded values.

    Closes-Bug: #1489359

    Change-Id: Ie81537c53744f33c10a6d0e0d584a6f355e47407

Changed in manila:
status: In Progress → Fix Committed
Changed in manila:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in manila:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-3 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.