Migration 5077ffcc5f1c add_share_instances fails with SQLAlchemy < 1.0.0

[Igor Malinovskiy]

2015-08-21 14:52:34.65 INFO alembic.migration [-] Running upgrade 3db9992c30f3 -> 5077ffcc5f1c, add_share_instances
2015-08-21 14:52:34.196 CRITICAL manila [-] AttributeError: 'Table' object has no attribute 'foreign_key_constraints'

2015-08-21 14:52:34.196 TRACE manila Traceback (most recent call last):
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/bin/manila-manage", line 10, in <module>
2015-08-21 14:52:34.196 TRACE manila sys.exit(main())
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/cmd/manage.py", line 448, in main
2015-08-21 14:52:34.196 TRACE manila fn(*fn_args)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/cmd/manage.py", line 212, in sync
2015-08-21 14:52:34.196 TRACE manila return migration.upgrade(version)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migration.py", line 28, in upgrade
2015-08-21 14:52:34.196 TRACE manila return IMPL.upgrade(version)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migrations/alembic/migration.py", line 51, in upgrade
2015-08-21 14:52:34.196 TRACE manila return alembic.command.upgrade(_alembic_config(), revision or 'head')
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/command.py", line 165, in upgrade
2015-08-21 14:52:34.196 TRACE manila script.run_env()
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/script.py", line 382, in run_env
2015-08-21 14:52:34.196 TRACE manila util.load_python_file(self.dir, 'env.py')
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/util.py", line 242, in load_python_file
2015-08-21 14:52:34.196 TRACE manila module = load_module_py(module_id, path)
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/compat.py", line 79, in load_module_py
2015-08-21 14:52:34.196 TRACE manila mod = imp.load_source(module_id, path, fp)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migrations/alembic/env.py", line 41, in <module>
2015-08-21 14:52:34.196 TRACE manila run_migrations_online()
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migrations/alembic/env.py", line 36, in run_migrations_online
2015-08-21 14:52:34.196 TRACE manila context.run_migrations() # pylint: disable=E1101
2015-08-21 14:52:34.196 TRACE manila File "<string>", line 7, in run_migrations
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/environment.py", line 742, in run_migrations
2015-08-21 14:52:34.196 TRACE manila self.get_context().run_migrations(**kw)
2015-08-21 14:52:34.196 TRACE manila File "/usr/local/lib/python2.7/dist-packages/alembic/migration.py", line 305, in run_migrations
2015-08-21 14:52:34.196 TRACE manila step.migration_fn(**kw)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migrations/alembic/versions/5077ffcc5f1c_add_share_instances.py", line 282, in upgrade
2015-08-21 14:52:34.196 TRACE manila create_share_instances_table(connection)
2015-08-21 14:52:34.196 TRACE manila File "/opt/stack/manila/manila/db/migrations/alembic/versions/5077ffcc5f1c_add_share_instances.py", line 86, in create_share_instances_table
2015-08-21 14:52:34.196 TRACE manila for fk in shares_table.foreign_key_constraints:
2015-08-21 14:52:34.196 TRACE manila AttributeError: 'Table' object has no attribute 'foreign_key_constraints'
2015-08-21 14:52:34.196 TRACE manila
+ exit_trap
+ local r=1
++ jobs -p
+ jobs=
+ [[ -n '' ]]
+ kill_spinner
+ '[' '!' -z '' ']'
+ [[ 1 -ne 0 ]]
+ echo 'Error on exit'
Error on exit
+ [[ -z /opt/stack/logs ]]
+ /opt/stack/devstack/tools/worlddump.py -d /opt/stack/logs
World dumping... see /opt/stack/logs/worlddump-2015-08-21-065234.txt for details
+ exit 1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216286
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9f9115409064a3a3c0062defb7da74a0eeb2ede2
Submitter: Jenkins
Branch: master

commit 9f9115409064a3a3c0062defb7da74a0eeb2ede2
Author: Lukas Bezdicka <email address hidden>
Date: Mon Aug 24 16:38:12 2015 +0200

    Fix compatibility with sqlalchemy 0.9.7

    Change I326c00b8252f2630e72bb0c22ca294f79feee2be introduced sqlalchmey
    1.0+ only Table attribute foreign_key_constraints. It should be sufficient
    to use foreign_keys as only name is needed.

    Closes-Bug: #1487351
    Change-Id: I38dd8ab620cbe372265eb0568d806cf1c37d5e14