share api returns name of share_type instead of UUID

Bug #1483886 reported by Andrew Kerr
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Igor Malinovskiy

Bug Description

When performing a GET on the /shares/<id> endpoint, manila returns share_type as the name of the share_type instead of the UUID of the share_type

Revision history for this message
Ben Swartzlander (bswartz) wrote :

Bugfix for this should ideally go in after microversions because the fix will change the API.

Changed in manila:
importance: Undecided → Medium
milestone: none → liberty-3
status: New → Triaged
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Why it should be UUID?
Names are unique for share types.

Revision history for this message
Andrew Kerr (andrew-kerr) wrote :

All other resources are referred to by UUID

Revision history for this message
Andrew Kerr (andrew-kerr) wrote :

Also, the api URI for /types/<id> needs the UUID not the name, so returning the name of the share is not helpful

Revision history for this message
Andrew Kerr (andrew-kerr) wrote :

That last comment should say share_type not share

Changed in manila:
assignee: nobody → Igor Malinovskiy (imalinovskiy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220046

Changed in manila:
status: Triaged → In Progress
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-3 → liberty-rc1
Changed in manila:
assignee: Igor Malinovskiy (imalinovskiy) → Valeriy Ponomaryov (vponomaryov)
Changed in manila:
assignee: Valeriy Ponomaryov (vponomaryov) → nobody
assignee: nobody → Igor Malinovskiy (imalinovskiy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/220046
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0460c7a84f2dfc81f9ff09e6e099cfd97d03a800
Submitter: Jenkins
Branch: master

commit 0460c7a84f2dfc81f9ff09e6e099cfd97d03a800
Author: Igor Malinovskiy <email address hidden>
Date: Mon Sep 14 06:14:24 2015 -0700

    Return share_type UUID instead of name in Share API

    APIImpact
    Change-Id: I082bdac82c981adf733c709472ce1b9e26d5650b
    Closes-Bug: #1483886

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.