manila 'cover' tox job shows different results after reruns
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Low
|
Unassigned |
Bug Description
We have tox job "cover" that calculate total code coverage with unit tests.
And this job reports different results on the same state if run it again and again.
Results for three runs:
Run№ statements missing excluded coverage
1 43573 4568 0 90%
2 43573 4580 0 89%
3 43573 4577 0 89%
4 43573 4584 0 89%
Looks like we have some concurrency issues in unit tests that lead to really different code lines be called.
Some debug discovered several problem places, that have different coverage:
manila/
manila/service
manila/
manila/test
manila/
manila/
manila/
manila/
manila/
manila/
description: | updated |
description: | updated |
summary: |
- manila coverage job shows different results after reruns + manila 'cover' tox job shows different results after reruns |
description: | updated |
description: | updated |
description: | updated |
tags: | added: tests unit |
description: | updated |
Changed in manila: | |
importance: | Undecided → Medium |
Changed in manila: | |
milestone: | none → liberty-2 |
Changed in manila: | |
milestone: | liberty-2 → liberty-3 |
Changed in manila: | |
milestone: | liberty-3 → liberty-rc1 |
Changed in manila: | |
importance: | Medium → Low |
Changed in manila: | |
milestone: | liberty-rc1 → none |
assignee: | Valeriy Ponomaryov (vponomaryov) → nobody |
status: | In Progress → Confirmed |
Debuging case of manila/ db/sqlalchemy/ api found out that "some" of not covered code lines are taken as "covered" sometimes. So, we can fix it with improving test coverage.