Config option "enabled_share_protocols" is case-sensitive

Bug #1475668 reported by Yogesh
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Valeriy Ponomaryov

Bug Description

Manila api could not recognize the lower case value (eg. cifs) provided in "enabled_share_protocols".
Therefore, failed to start with below error -

cd /opt/stack/manila && /usr/local/bin/manila-api --config-file /etc/manila/manila.conf
Traceback (most recent call last):
  File "/usr/local/bin/manila-api", line 10, in <module>
    sys.exit(main())
  File "/opt/stack/manila/manila/cmd/api.py", line 48, in main
    config.verify_share_protocols()
  File "/opt/stack/manila/manila/common/config.py", line 179, in verify_share_protocols
    msg += _("Please specify one or more protocols using "
  File "/usr/local/lib/python2.7/dist-packages/oslo_i18n/_message.py", line 154, in __add__
    raise TypeError(msg)
TypeError
m-api failed to start

Expected behavior - This option needs to be case-insensitive.

Changed in manila:
importance: Undecided → Low
status: New → In Progress
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
milestone: none → liberty-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/204566
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c017947f582eb582b538ab08c06be2d64777a2b1
Submitter: Jenkins
Branch: master

commit c017947f582eb582b538ab08c06be2d64777a2b1
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed Jul 22 14:49:50 2015 +0300

    Make config opt 'enabled_share_protocols' verification case insensitive

    Make opt 'enabled_share_protocols' expect share protocol names using any case.
    Also, remove concatenation of translated messages and make explicit
    unicode-transformation or these messages that is required when lazy translation
    is enabled. That is case of Manila.

    See http://docs.openstack.org/developer/oslo.i18n/usage.html#lazy-translation

    Change-Id: Iadf41abd5ac62fcce0c0f63cd9a376a2c6eadd6e
    Closes-Bug: #1475668

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-2 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.