Cannot perform 'manila extend' - device is busy

[Julia Varlamova]

When we create a share and mount it on client VM, we cannot do 'manila extend' because of the following error:

2015-07-09 07:47:29.524 ERROR manila.share.manager [req-17323f19-74b6-4693-a919-ee5b476f4b74 b64ca6449dc3434e946fcddbc0431dc3 f0821a1fd4d14571b229fff611682041] Extend share failed.
2015-07-09 07:47:29.524 TRACE manila.share.manager Traceback (most recent call last):
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/manager.py", line 936, in extend_share
2015-07-09 07:47:29.524 TRACE manila.share.manager share, new_size, share_server=share_server)
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/drivers/generic.py", line 119, in wrap
2015-07-09 07:47:29.524 TRACE manila.share.manager return f(self, context, *args, **kwargs)
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/drivers/generic.py", line 555, in extend_share
2015-07-09 07:47:29.524 TRACE manila.share.manager self._unmount_device(share, server_details)
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/drivers/generic.py", line 323, in _unmount_device
2015-07-09 07:47:29.524 TRACE manila.share.manager return _unmount_device_with_lock()
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 252, in inner
2015-07-09 07:47:29.524 TRACE manila.share.manager return f(*args, **kwargs)
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/drivers/generic.py", line 317, in _unmount_device_with_lock
2015-07-09 07:47:29.524 TRACE manila.share.manager self._ssh_exec(server_details, unmount_cmd)
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/opt/stack/manila/manila/share/drivers/generic.py", line 162, in _ssh_exec
2015-07-09 07:47:29.524 TRACE manila.share.manager return processutils.ssh_execute(ssh, ' '.join(command))
2015-07-09 07:47:29.524 TRACE manila.share.manager File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py", line 380, in ssh_execute
2015-07-09 07:47:29.524 TRACE manila.share.manager cmd=sanitized_cmd)
2015-07-09 07:47:29.524 TRACE manila.share.manager ProcessExecutionError: Unexpected error while running command.
2015-07-09 07:47:29.524 TRACE manila.share.manager Command: sudo umount /shares/share-d15d75e5-3a2d-46d5-9b91-bf705257a8bb && sudo rmdir /shares/share-d15d75e5-3a2d-46d5-9b91-bf705257a8bb
2015-07-09 07:47:29.524 TRACE manila.share.manager Exit code: 1
2015-07-09 07:47:29.524 TRACE manila.share.manager Stdout: u''
2015-07-09 07:47:29.524 TRACE manila.share.manager Stderr: u'umount: /shares/share-d15d75e5-3a2d-46d5-9b91-bf705257a8bb: device is busy.\n (In some cases useful info about processes that use\n the device is found by lsof(8) or fuser(1))\n'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/200422

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/200422
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=48c7b605db1b17af98d1d47df2068e4ef56dbeb1
Submitter: Jenkins
Branch: master

commit 48c7b605db1b17af98d1d47df2068e4ef56dbeb1
Author: Julia Varlamova <email address hidden>
Date: Fri Jul 10 04:26:45 2015 -0400

    Fix 'extend_share' in generic driver

    When we create a share and mount it on client VM, we cannot do
    'manila extend' because of error:
    Stderr: u'umount: /shares/share-xxxxxx: device is busy.

    We need to 'disable_access_for_maintenance' before doing an extension
    and 'restore_access_after_maintenance' after extension was done.

    Closes-Bug: #1473033

    Change-Id: I4b5e665f8d028d4784d02411bbe6daace30aa49e