share server cleanup removes connectivity (generic driver)

[Rodrigo Barbieri]

Steps to recreate the bug:

Environment: default devstack + manila.

1. Create a Share Network "share_net_1" using "private" network and "private-subnet" subnetwork.
2. Create a Share Network "share_net_2" using "private" network and "private-subnet" subnetwork.
3. Create a Share "share_1" specifying "share_net_1", wait for available status.
4. Create a Share "share_2" specifying "share_net_2", wait for available status.

At this point, two Share Servers are being created on the same Manila Subnetwork 10.254.0.0/28. It will add an interface to "router1" that connects it to Manila Subnetwork, the IP address should be 10.254.0.1.

5. Delete "share_2".
6. Wait for Share server cleanup.
7. Check for network interface "10.254.0.1" in "router1", it has been removed and "share_1" cannot be mounted from any VM in "private" network.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/181380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/181380
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c7f57b0d7bf2c45d30f8494a5fb4b6d42ec38583
Submitter: Jenkins
Branch: master

commit c7f57b0d7bf2c45d30f8494a5fb4b6d42ec38583
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri May 8 16:04:41 2015 +0300

    Fix share-server resources cleanup in generic driver

    Generic driver using Neutron creates and attaches service subnets to router.
    When we have more than one share server using same service subnet and delete
    one of them, then Manila removes service subnet from router.
    It is improper behaviour, because other, not deleted, share servers lose
    connection in that case. So, add port validation to get to know for sure,
    whether service subnet is used or not.

    Change-Id: I6e7d4c1b40304be39f84a23c00433f47a295d02c
    Closes-Bug: #1452747

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/183446

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/183446
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=77c3553f60a949610fc377112e0f562c1c5cdffd
Submitter: Jenkins
Branch: stable/kilo

commit 77c3553f60a949610fc377112e0f562c1c5cdffd
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri May 8 16:04:41 2015 +0300

    Fix share-server resources cleanup in generic driver

    Generic driver using Neutron creates and attaches service subnets to router.
    When we have more than one share server using same service subnet and delete
    one of them, then Manila removes service subnet from router.
    It is improper behaviour, because other, not deleted, share servers lose
    connection in that case. So, add port validation to get to know for sure,
    whether service subnet is used or not.

    Change-Id: I6e7d4c1b40304be39f84a23c00433f47a295d02c
    Closes-Bug: #1452747
    (cherry picked from commit c7f57b0d7bf2c45d30f8494a5fb4b6d42ec38583)