share does not have field 'has_snapshots'

[Valeriy Ponomaryov]

Manila restricts to delete shares that has snapshots created from it. But to get know it one should either try delete share or list snapshots filtering by share ID he wants to delete. It is not proper approach for getting such info. Share itself should have attr (i.e. 'has_snapshots') that will provide such information.

[NidhiMittalHada (nidhimittal19)]

I am working on it.

stack@controller:~/devstack$ manila show d5f35492-0d5d-494f-b1f8-e5f512bf6fcc
+-------------------+---------------------------------------------------------------------+
| Property | Value |
+-------------------+---------------------------------------------------------------------+
| status | available |
| description | None |
| availability_zone | nova |
| share_network_id | None |
| export_locations | \\10.141.67.225\DemoVol1_share_d5f35492_0d5d_494f_b1f8_e5f512bf6fcc |
| share_server_id | None |
| host | controller@generic1#GENERIC1 |
| snapshot_id | None |
| is_public | False |
| id | d5f35492-0d5d-494f-b1f8-e5f512bf6fcc |
| size | 1 |
| name | CIFS_share |
| share_type | Nexenta_Storage |
| created_at | 2015-09-09T14:51:11.000000 |
| share_proto | CIFS |
| project_id | 56ad9847e9ae4850a906f4e9b0161ca6 |
| metadata | {} |
+-------------------+---------------------------------------------------------------------+
stack@controller:~/devstack$

There are two ways it can be fixed. Please suggest which one is acceptable..?

1)As has been suggested, the first approach can be to add one more field has_snapshot to share information.
where in has_snapshot will be true if there is >= 1 are associated snapshot for this share.
and has_snapshot will be false when 0 snapshots are associated with this share.

But this requires change in DB schema

2)2nd approach can be to add a cli command for share , that enquires whether share has a snapshot or not.
which will be somewhat like

manila share-snapshot-enquire <share-id>
result:- gives list of snapshots if associated with the share.

[NidhiMittalHada (nidhimittal19)]

Do we plan to target this bug for next release ?

[NidhiMittalHada (nidhimittal19)]

working on it ..

[Jason Grosso (jgrosso)]

Is this bug still in progress?

[Jason Grosso (jgrosso)]

closing item out if this is still a valid wish list item please feel free to reopen it