ganesha: an execute call made with argument 'process_input' that is invalid if call is made to a remote machine

Bug #1422235 reported by Ramana Raja
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Ramana Raja

Bug Description

In the ganesha manager library, an execute call that writes export config files does so by making use of 'process_input' argument. See here,
https://github.com/openstack/manila/commit/559b478e8578ab0bf591d29fcb662a9d7a1158da#diff-ccc750d6512ac97d2a7c2744b0991f1bR231
This argument is supported by processutils's execute() method, used to execute command on local machine and not by processutils's ssh_execute() method, used to execute command on remote machine..
See here,
https://github.com/openstack/oslo.concurrency/commit/be982c56eeb5eb900bfda3375a236bfe425ac200#diff-ef5a9bcb5e6c774f4e9b635c72a4aadcR223
So if the config files are to be written to a remote ganesha server, the execute call made with argument 'process_input' will error out since processutils's ssh_execute() method, which is called for remote execution, does not support that argument.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156124

Changed in manila:
assignee: nobody → Ramana Raja (rraja)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/156124
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a0097bfe15bcbe71f87bd6e9f7fdc67110a6d378
Submitter: Jenkins
Branch: master

commit a0097bfe15bcbe71f87bd6e9f7fdc67110a6d378
Author: Ramana Raja <email address hidden>
Date: Sun Feb 15 14:48:55 2015 +0000

    ganesha: fix execute call using invalid argument

    An execute call in the ganesha manager module that writes ganesha
    export config files is made with 'process_input' argument. This
    argument is invalid for processutils's ssh_execute() method which is
    used by the execute call to write config files to a remote ganesha
    server node. Fix this by not using the 'process_input' argument instead
    use other arguments that would still enable the execute call to write
    ganesha config files.

    Change-Id: I58369468ac7be1de38364a1c1bf6cbf8695b9a1d
    Closes-Bug: #1422235

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.