OpenStack Shared File Systems Service (Manila)

tox job "genconfig" is broken

Bug #1419434 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov
OpenStack Shared File Systems Service (Manila) 2015.1.0 "kilo"

Bug Description

Due to presence of bug in oslo.config lib - https://bugs.launchpad.net/oslo.config/+bug/1419458

Broken config sample generator was not discovered with merging of following commit:
https://review.openstack.org/#/c/139850/

See error: http://logs.openstack.org/50/139850/17/check/gate-manila-tox-genconfig/76129bd/console.html#_2015-02-07_10_16_08_488

Tox job "genconfig" catches error but returns "OK" status always.

Need to fix this tox job.

See original description
Tags: config
Valeriy Ponomaryov (vponomaryov)
tags: added: config
Changed in manila:
milestone: none → kilo-3
importance: Undecided → High
Valeriy Ponomaryov (vponomaryov)
summary: - genconfig tox job returns 'OK' when error exists
+ tox job "genconfig" is broken
description: updated
Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/153866

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/153866
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a312c2809d5cd204dda36615aec6577dfe7acaac
Submitter: Jenkins
Branch: master

commit a312c2809d5cd204dda36615aec6577dfe7acaac
Author: vponomaryov <email address hidden>
Date: Sun Feb 8 17:20:39 2015 +0200

    Fix generation of config sample

    Merged commit I90e19a1d34d568eba6178ca3dbb605f37c598439 has introduced bug
    to generation of config sample, where one of imports was lost.
    It is can not be caught due to b_u_g in oslo.config lib (see #1419458).

    Change-Id: I90a9631ff8f912d0eeb75d16af7d5bf916635405
    Closes-Bug: #1419434

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.