Fail operation when share-network do not have a router

[li,chen]

In generic driver , when connect_share_server_to_tenant_network = False
Every share-network "must" have a router.
If the share-network is created without a router, share creation would failed.

How to reproduce:

1. create a network "user-network" in neutron
2. create a subnet "user-subnet" within "user-network" in neutron
3. create a share-network "user-share-net" in manila with "user-subnet" & "user-network"
4. create a share with "user-share-net"
       => share creation would failed due to " ServiceInstanceException: Subnet gateway is not attached the router."
5. Run command :
    manila share-network-delete "user-share-net"

Result:
       => ERROR: Cannot delete share network xxxxx. There are share servers using it

Expected result:
    1. Actually no share-server has been created, so the output is wrong.
    2. share-network should be able to be deleted successfully

[Valeriy Ponomaryov (vponomaryov)]

Share server with ERROR was created. So, it should be deleted first.

Also, share-network is definition within Manila and it does not have any relation to routers at all. Network of tenant, that is provided within share-network should have interface in public router.

[Thiago Gomes (fthiagogv)]

I follow your steps and don't occur any error.
Do you try run stack again?
Do you verify if the modules are running correctly on screen?

[Jason Grosso (jgrosso)]

Is this bug still happening ?

[Jason Grosso (jgrosso)]

If this is still occurring can you please reopen in a newer defect.