Ganesha config options not being registered

Bug #1415738 reported by Ramana Raja
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Ramana Raja

Bug Description

For instances of classes that inherit both GaneshaMixin and ShareDriver classes (e.g. GPFSShareDriver) currently don't seem to have the ganesha specific configuration options. This is because the initialization method of the ShareDriver class incorrectly calls the init_execute_mixin() method of the ExecuteMixin class instead of the init_ganesha_mixin() method of the GaneshaMixin class that helps register the ganesha configuration options. Please see the incorrect call here,
https://github.com/openstack/manila/commit/559b478e8578ab0bf591d29fcb662a9d7a1158da#diff-224324f888aae88027301e8fedb13340R173

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151112

Changed in manila:
assignee: nobody → Ramana Raja (rraja)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/151112
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=220d33eb592dc950f348e89be41556b79d186031
Submitter: Jenkins
Branch: master

commit 220d33eb592dc950f348e89be41556b79d186031
Author: Ramana Raja <email address hidden>
Date: Thu Jan 29 10:11:07 2015 +0530

    driver: Fix ganesha config option registry

    To register the ganesha config options, the initialization method of
    the ShareDriver class incorrectly calls the ExecuteMixin class's
    init_execute_mixin() method. Instead call GaneshaMixin's
    init_ganesha_mixin() method.

    Change-Id: Iafbdcf7ff1701f95e62f444602a5a2d38ad82938
    Closes-Bug: #1415738

Changed in manila:
status: In Progress → Fix Committed
Changed in manila:
milestone: none → kilo-2
Changed in manila:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.