share driver mode opt should be StrOpt, but now is ListOpt

Bug #1403952 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Critical
Valeriy Ponomaryov

Bug Description

Commit https://github.com/openstack/manila/commit/28f311c9 introduced functionality of share driver modes. But when we set value to it different than None we get error of validation:

2014-12-18 18:24:03.141 ERROR manila.share.driver [-] Unsupported driver mode '['multi_svmd']' is provided. List of supported is ['multi_svm'].
2014-12-18 18:24:03.141 CRITICAL manila [-] InvalidParameterValue: Unsupported driver mode '['multi_svmd']' is provided. List of supported is ['multi_svm'].

2014-12-18 18:24:03.141 TRACE manila Traceback (most recent call last):
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/bin/manila-share", line 58, in <module>
2014-12-18 18:24:03.141 TRACE manila binary='manila-share')
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/manila/service.py", line 446, in create
2014-12-18 18:24:03.141 TRACE manila service_name=service_name)
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/manila/service.py", line 350, in __init__
2014-12-18 18:24:03.141 TRACE manila *args, **kwargs)
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/manila/share/manager.py", line 72, in __init__
2014-12-18 18:24:03.141 TRACE manila share_driver, self.db, configuration=self.configuration)
2014-12-18 18:24:03.141 TRACE manila File "/usr/local/lib/python2.7/dist-packages/oslo/utils/importutils.py", line 38, in import_object
2014-12-18 18:24:03.141 TRACE manila return import_class(import_str)(*args, **kwargs)
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/manila/share/drivers/generic.py", line 117, in __init__
2014-12-18 18:24:03.141 TRACE manila self.mode = self.get_driver_mode([const.MULTI_SVM_MODE, ])
2014-12-18 18:24:03.141 TRACE manila File "/opt/stack/manila/manila/share/driver.py", line 173, in get_driver_mode
2014-12-18 18:24:03.141 TRACE manila raise exception.InvalidParameterValue(msg)
2014-12-18 18:24:03.141 TRACE manila InvalidParameterValue: Unsupported driver mode '['multi_svm']' is provided. List of supported is ['multi_svm'].

Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
importance: Undecided → Critical
status: New → In Progress
description: updated
summary: - share driver mode opt is should be StrOpt, but now is ListOpt
+ share driver mode opt should be StrOpt, but now is ListOpt
Changed in manila:
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142861

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/142861
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=397950e1e92b6a99102213b440820b01c84bdede
Submitter: Jenkins
Branch: master

commit 397950e1e92b6a99102213b440820b01c84bdede
Author: Valeriy Ponomaryov <email address hidden>
Date: Thu Dec 18 19:58:57 2014 +0200

    Fix driver mode opt definition

    Share driver mode opt should be StrOpt, but now it is ListOpt. We get driver
    mode validation error when option is redefined within external config file.
    It can not be caught by update of config opt within code.

    Change-Id: I77cab322beba7ec2258e106eebf631c081cfebe5
    Closes-Bug: #1403952

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers