Generic driver configures incorrect Samba share path

Bug #1370223 reported by David Disseldorp
266
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Critical
Vladimir Vechkanov

Bug Description

When configuring a new Samba share, the generic driver doesn't specify the correct share path. It specifies "path = /shares" instead of "path = /shares/share-GUID". As a result, a host with access to one share can access any other shares deployed by the tenant.

Bug #1370216 means that any shares configured by the generic driver are by default not exposed by Samba. Nevertheless, I've flagged this as a security vulnerability just in case.

Proposed fix attached.

Revision history for this message
David Disseldorp (ddiss-6) wrote :
Revision history for this message
David Disseldorp (ddiss-6) wrote :

Any feedback on the proposed patch?

Changed in manila:
importance: Undecided → Critical
milestone: none → juno-rc1
Changed in manila:
milestone: juno-rc1 → juno-rc2
Revision history for this message
David Disseldorp (ddiss-6) wrote :

Following discussion with Valeriy on IRC, I'll propose the attached patch for public review on GitHub.

Changed in manila:
assignee: nobody → Vladimir Vechkanov (vvechkanov)
status: New → In Progress
Changed in manila:
status: In Progress → Fix Committed
Changed in manila:
status: Fix Committed → Fix Released
information type: Private Security → Public Security
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.