Code references 'in-use' share state but this state is unreachable

[Alex Meade]

Manila code references an 'in-use' status for shares but this status is invalid. I believe this is likely leftover from the cinder fork.

For example.
./manila/share/manager.py: 82 if share['status'] in ['available', 'in-use']:

[Valeriy Ponomaryov (vponomaryov)]

When you give code links, please, use links to code using commits, for example:

https://github.com/stackforge/manila/blob/0b382f186bb7f834c2ac4a5a2730ff2cc03eb97a/manila/share/manager.py#L82

And 'wishlist' status is more suitable here, described issue is harmless.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109644
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=61316b7adb37cbbcfec0be8cbfca3274b6c19b24
Submitter: Jenkins
Branch: master

commit 61316b7adb37cbbcfec0be8cbfca3274b6c19b24
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Jul 25 12:06:00 2014 -0400

    Remove reference to 'in-use' state in share manager

    State 'in-use' is leftover from Cinder and is not used by shares,
    hence it should be removed.
    Due to absense of tests for this module at all, as part of bug fix
    were added unittests.

    Change-Id: I768d731bac3eb1f420695082e69598e55e1de90b
    Closes-Bug: #1346371
    Partial-Bug: #1348635