pep8 tests has a lot of disabled rules

Bug #1333290 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Medium
Andreas Jaeger

Bug Description

pep8/flake8 tests in manila has a lot of skipped rules.

We need to fix problem places and enable rules, without it we have newly added code, that does not correspond to these rules.

Changed in manila:
importance: Undecided → Medium
tags: added: manila manilaclient
Changed in manila:
status: New → In Progress
tags: removed: manilaclient
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/114486
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=09b1917fe89e26e318ed2f341da6c2c3b3fb4191
Submitter: Jenkins
Branch: master

commit 09b1917fe89e26e318ed2f341da6c2c3b3fb4191
Author: Andreas Jaeger <email address hidden>
Date: Fri Aug 15 11:40:56 2014 +0200

    Fix pep8 F811 and F812

    Fixes:
    manila/scheduler/simple.py:74:45: F812 list comprehension redefines
      'service' from line 59
    manila/api/v1/share_networks.py:147:41: F811 redefinition of unused
      'network' from line 29

    Do not blacklist these tests anymore.

    Partial-Bug: #1333290
    Change-Id: Ibf3c170ada17a7af0708331331bc435942c3763b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/114501
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=a7da88bb090939936c823fd65e8b857dc90e000e
Submitter: Jenkins
Branch: master

commit a7da88bb090939936c823fd65e8b857dc90e000e
Author: Andreas Jaeger <email address hidden>
Date: Fri Aug 15 12:42:49 2014 +0200

    Fix pep8 failures in manila/{db,volume}

    Fix pep8 failures, especially:
    H402 one line docstring needs punctuation.
    E127 continuation line over-indented for visual indent
    E128 continuation line under-indented for visual indent
    F401 'xxx' imported but unused

    Partial-Bug: #1333290
    Change-Id: Ia285d30574c3ad51b839823ea934e274f26ce6a3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/114469
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=baad6f7894fc548f562be9465744dd7a724def4f
Submitter: Jenkins
Branch: master

commit baad6f7894fc548f562be9465744dd7a724def4f
Author: Andreas Jaeger <email address hidden>
Date: Fri Aug 15 10:09:28 2014 +0200

    Further pep8 fixes

    Fix the following issues in some files:
    F401 'XXX' imported but unused
    E123 closing bracket does not match indentation of opening bracket's
    line
    E126 continuation line over-indented for hanging indent
    E128 continuation line under-indented for visual indent
    E129 visually indented line with same indent as next logical line
    H904 Wrap long lines in parentheses instead of a backslash

    Partial-Bug: #1333290
    Change-Id: Ic9b3a1e47fd24d2835f35f2ef71c4519908ff049

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/115553
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=2965d59541db96832b2b1ec21c4edbaa2fd1c441
Submitter: Jenkins
Branch: master

commit 2965d59541db96832b2b1ec21c4edbaa2fd1c441
Author: Andreas Jaeger <email address hidden>
Date: Wed Aug 20 10:53:46 2014 +0200

    pep8: Enable H303 and F403

    Remove wildcard imports that are unneeded.
    Add #noqa for needed wildcard imports.

    Enable H303 and F403 flake8 tests.
    Partial-Bug: #1333290

    Change-Id: I5974b899bfd0ffbcc6a5dda330693c17cde91317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/115712
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=290769f087281c3c3f3a6a831e653b39e07107e3
Submitter: Jenkins
Branch: master

commit 290769f087281c3c3f3a6a831e653b39e07107e3
Author: Andreas Jaeger <email address hidden>
Date: Wed Aug 20 18:54:10 2014 +0200

    Flake8: Fix F401

    Fix:
    F401 'XXX' imported but unused
    Add noqa where needed, remove extra imports otherwise.

    Remove F401 from ignore list.

    Partial-Bug: #1333290
    Change-Id: Ib71f0dd001c4e4899200b5e60b3a38e4a6c40555

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116237
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=9154f3e55b52179a4cd68e9946fd6c80342b6832
Submitter: Jenkins
Branch: master

commit 9154f3e55b52179a4cd68e9946fd6c80342b6832
Author: Andreas Jaeger <email address hidden>
Date: Fri Aug 22 14:02:55 2014 +0200

    Flake8: Fix E126 and E127

    Fix these issues and enable E126 and E127:
    E126 continuation line over-indented for hanging indent
    E127 continuation line over-indented for visual indent

    Also fix a few occurences in the touched files of:
    E128 continuation line under-indented for visual indent
    H405 multi line docstring summary not separated with an empty line

    Partial-Bug: #1333290
    Change-Id: If822401fc7e1db49d595a0736a0dff8e00dfd217

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116440
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=cd8dff072573e49b19344323a1192751b291645f
Submitter: Jenkins
Branch: master

commit cd8dff072573e49b19344323a1192751b291645f
Author: Andreas Jaeger <email address hidden>
Date: Sat Aug 23 09:47:13 2014 +0200

    Flake8: Fix some occurences of F841

    Fix F841 in some files:
    F841 local variable 'XXX' is assigned to but never used

    Also fix in utils.py some occurences of:
    H405 multi line docstring summary not separated with an empty line

    Change-Id: I272f075d874e2a48da102d9d4025cb93225170e0
    Partial-Bug: #1333290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116517
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=e1ab0e25c7894c9d6bb65eb9f2e7ba0b406e3faa
Submitter: Jenkins
Branch: master

commit e1ab0e25c7894c9d6bb65eb9f2e7ba0b406e3faa
Author: Andreas Jaeger <email address hidden>
Date: Sun Aug 24 20:20:37 2014 +0200

    Flake8: Fix F841

    Enable F841 and fix all issues.

    Flake F841 is:
    F841 local variable 'XXX' is assigned to but never used

    Also fix in changed files some occurences of:
    E128 continuation line under-indented for visual indent
    H404 multi line docstring should start without a leading new line
    H405 multi line docstring summary not separated with an empty line

    Change-Id: Ifb08a82d05ac15c8e90f214a96e73d82ff850018
    Partial-Bug: #1333290

Changed in manila:
assignee: nobody → Andreas Jaeger (jaegerandi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116521
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=ab96ccb1ef6b4a47faa59b4d901277ec767e0972
Submitter: Jenkins
Branch: master

commit ab96ccb1ef6b4a47faa59b4d901277ec767e0972
Author: Andreas Jaeger <email address hidden>
Date: Sat Aug 23 20:37:43 2014 +0200

    Flake8: Fix H302

    Fix H302 and enable the test:
    H302 import only modules.'from X import Y' does not import a module

    Fix also in the touched files the following:
    E128 continuation line under-indented for visual indent

    Change-Id: I3116c030a5dc0b5be2b4413beaa460e483215774
    Partial-Bug: #1333290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116522
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=4a49b5e5628fcf87b6ea573f303b3eeb7085e9e5
Submitter: Jenkins
Branch: master

commit 4a49b5e5628fcf87b6ea573f303b3eeb7085e9e5
Author: Andreas Jaeger <email address hidden>
Date: Sun Aug 24 21:27:08 2014 +0200

    Flake8: Fix E128

    Fix and enable E128:
    E128 continuation line under-indented for visual indent

    Partial-Bug: #1333290

    Change-Id: I72f673d291c388fc4df19e9585fb02e23c21fec3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116524
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=8203c51081680a7a9dba30ae02d7c43d6e18a124
Submitter: Jenkins
Branch: master

commit 8203c51081680a7a9dba30ae02d7c43d6e18a124
Author: Andreas Jaeger <email address hidden>
Date: Sun Aug 24 22:07:32 2014 +0200

    Flake8: Fix and enable H404

    Fix and enable flake8 test H404:
    H404 multi line docstring should start without a leading new line

    Change-Id: I13dc13bb5e81d65300680df094cde538c7a6f6df
    Partial-Bug: #1333290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/115724
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=1ee54a314409e6ddb634ae9a37adb024d8bb0563
Submitter: Jenkins
Branch: master

commit 1ee54a314409e6ddb634ae9a37adb024d8bb0563
Author: Andreas Jaeger <email address hidden>
Date: Wed Aug 20 19:54:31 2014 +0200

    Flake8: Fix H501

    Fix all occurences of:
    H501 Do not use locals() for string formatting

    Change-Id: Id221d257975659d31b29ed696345f96525c3b459
    Partial-Bug: #1333290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/116975
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=2641eb9b57ecf3e15955b50a33604050f95d2d94
Submitter: Jenkins
Branch: master

commit 2641eb9b57ecf3e15955b50a33604050f95d2d94
Author: Andreas Jaeger <email address hidden>
Date: Tue Aug 26 19:46:55 2014 +0200

    Flake8: Fix and enable H405

    Fix H405:
    H405 multi line docstring summary not separated with an empty line

    With this patch, flake8 passes all checks (incl. hacking checks)
    except the on-purpose disabled check H904.
    Closes-Bug: #1333290

    Change-Id: If41259aefc4d6d588da5036f1f25df17b88db04f

Changed in manila:
status: In Progress → Fix Committed
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :
Changed in manila:
status: Fix Committed → Fix Released
Changed in manila:
milestone: none → juno-3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers