can not create more than 25 shares with generic driver

[Valeriy Ponomaryov]

"Generic" driver uses "service_instance" module.
This module creates VM in nova for each share-network and attaches there volumes using device names "vd*". After usage of all available letters b-z we get next error:

Traceback (most recent call last):
  File "/opt/stack/manila/manila/openstack/common/rpc/amqp.py", line 433, in _process_data
    **args)
  File "/opt/stack/manila/manila/openstack/common/rpc/dispatcher.py", line 148, in dispatch
    return getattr(proxyobj, method)(ctxt, **kwargs)
  File "/opt/stack/manila/manila/share/manager.py", line 128, in create_share
    self.db.share_update(context, share_id, {'status': 'error'})
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/opt/stack/manila/manila/share/manager.py", line 123, in create_share
    export_location = self.driver.create_share(context, share_ref)
  File "/opt/stack/manila/manila/share/drivers/generic.py", line 129, in create_share
    volume = self._attach_volume(self.admin_context, share, server, volume)
  File "/opt/stack/manila/manila/share/drivers/service_instance.py", line 105, in wrapped_func
    return f(self, *args, **kwargs)
  File "/opt/stack/manila/manila/share/drivers/generic.py", line 187, in _attach_volume
    device_path)
  File "/opt/stack/manila/manila/compute/nova.py", line 142, in wrapper
    res = method(self, ctx, instance_id, *args, **kwargs)
  File "/opt/stack/manila/manila/compute/nova.py", line 227, in instance_volume_attach
    device)
  File "/opt/stack/python-novaclient/novaclient/v1_1/volumes.py", line 119, in create_server_volume
    body, "volumeAttachment")
  File "/opt/stack/python-novaclient/novaclient/base.py", line 152, in _create
    _resp, body = self.api.client.post(url, body=body)
  File "/opt/stack/python-novaclient/novaclient/client.py", line 314, in post
    return self._cs_request(url, 'POST', **kwargs)
  File "/opt/stack/python-novaclient/novaclient/client.py", line 288, in _cs_request
    **kwargs)
  File "/opt/stack/python-novaclient/novaclient/client.py", line 270, in _time_request
    resp, body = self.request(url, method, **kwargs)
  File "/opt/stack/python-novaclient/novaclient/client.py", line 264, in request
    raise exceptions.from_response(resp, body, url, method)
InvalidInput: Invalid input received: The supplied device path (/dev/vd{) is invalid.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/91771

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/91771
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=2db02e22b722a2ea32048a86ceba1b7db53a1fee
Submitter: Jenkins
Branch: master

commit 2db02e22b722a2ea32048a86ceba1b7db53a1fee
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri May 2 21:16:01 2014 +0300

    Fixed possibility to have more than 25 shares with generic driver

    Change-Id: Ibca0c33518d61a4b4eb37c243ef103e70859bc0f
    Closes-Bug: #1315266