Reviewed: https://review.openstack.org/518128 Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=535f2f48ff7003d1ec6eee014710dae9a332d9e0 Submitter: Zuul Branch: master commit a4ee1a3f098e97f0e6bdc0f3d20c3021d06cb343 Author: Monty Taylor Date: Wed Oct 4 13:06:22 2017 -0500 Merge tox, tests and other support files Change-Id: I5a4759e36089f1f4fab0c75412c94d051d8b16a7 commit 65293358a0d3cd7055987b18e16b9be5e8a0261b Author: Monty Taylor Date: Wed Oct 4 12:39:43 2017 -0500 Move shade and os-client-config python content Make shade be openstack.cloud and os-client-config be openstack.config. Change-Id: I1d28be82a72cc1a30d6be306257fc1f0736ed604 commit a3cd1f0faff25b6b43a80e8357b134ccd7437f99 Author: Monty Taylor Date: Wed Sep 20 10:29:27 2017 -0500 Merge shade and occ releasenotes Change-Id: I4d25c654ee3c298de03907b14161096a59d098db commit 94ace709e2bf860567a0920c3f836263432862ea Author: OpenStack Proposal Bot Date: Sat Sep 16 23:21:20 2017 +0000 Updated from global requirements Change-Id: I1bbda934cc65d508f1cece8c5adc714e9f464707 commit eafc8bed564d41f2a0c6a050e7a301241309fa59 Author: Monty Taylor Date: Sat Sep 16 13:13:25 2017 -0500 Fix requires_floating_ip This isn't a required piece of the config, so it might be unset. Use get instead of []. Change-Id: I1bbbcb4ac63a4f6d4399c0fa8881c21264a03e4b commit 2c24e204a6d75313447298bdcd7c458fa5107ba6 Author: Monty Taylor Date: Fri Sep 15 10:55:43 2017 -0600 Record server.id in server creation exception If an error happens in the initial creation, no id is returned to the server can't be cleaned up. Change-Id: Ieb818dcf9ded062f016a3f96342f320dc203edd0 commit 2c23196f23be244cd747c1e26c5a55c203f3e7be Author: Paul Belanger Date: Fri Sep 15 12:52:57 2017 -0400 Stop using openstack-doc-build We are in the process of moving openstack-doc-build to project-config, stop running for now. Change-Id: I409929a61044b397eedebe730b43b7897816141f Signed-off-by: Paul Belanger commit 6f72637fb6356d39adee82a2718118156ae4a6bf Author: Dean Troyer Date: Thu Sep 14 16:57:42 2017 -0500 Updates for stestr Change-Id: I344cd6ce38d8db8fe24e1611c9c61e1ffa1b586d commit 482b313b10149bfcb67f5c059da17f08426f7a7a Author: Sławek Kapłoński Date: Thu Sep 14 12:02:02 2017 -0600 Add support for network quota details command Neutron recently introduced API call to get details about current usage of quota by given project. This patch adds support for this command in Shade. Related-Bug: #1716043 Change-Id: I74682c6b2a287f54acef91686e7281f45cbe9684 commit f29d04dcf903fc6ac10f276badaff3edf3f09b7a Author: Monty Taylor Date: Sat Sep 9 11:01:53 2017 -0500 Add pypi and doc publication templates Change-Id: Iaa2b3742d04135a6da35f42f4a787937b9bc81eb Depends-On: I01ea35061ba92c2e466c6269c61e640461d6da99 Depends-On: I4f1aea66fcbb623f554ded4d7ce63ff4c1168e45 commit 3fb4fec1d6ab2c72f72997533792fbe5d05936de Author: OpenStack Proposal Bot Date: Wed Sep 13 13:00:03 2017 +0000 Updated from global requirements Change-Id: I6ecb4e80d2944bf592a2cbd41695643bc49f832d commit 35ae661b2c6b8890d6535bd485129238e6730e4c Author: OpenStack Proposal Bot Date: Wed Sep 13 12:48:14 2017 +0000 Updated from global requirements Change-Id: I17ac8b33f1db658ea5571ac5e954c68bf3fa3ca7 commit f545e8ebeafbfa56a1c337ab1c369e6f0be2adf0 Author: Sam Yaple Date: Tue Sep 12 17:33:36 2017 -0400 Fix search_groups Change-Id: Ibb79be4ea42994b481ff484d5ae2b0aa0a97f4db Related-Id: I5be672c3eae5e013525cc7c0a4d73f9166f379ba commit e1cafe3aa22809b34515340b05452ba8457dbd96 Author: Monty Taylor Date: Tue Sep 12 13:12:43 2017 -0600 Remove EndpointCreate and _project_manager They're not used anymore. Change-Id: I9858bbd4d753d16c113e7df70a5f316ccbce6493 commit ec797b62cc7404db3a70d466e2d80cc00b673b39 Author: Monty Taylor Date: Mon Sep 4 09:01:42 2017 -0500 Remove use of legacy keystone client in functional tests We use it here to verify the new user account information works. We can do the same thing by just grabbing a catalog. Change-Id: I55c981a29f4386a53472a88c1618b390f4b64a08 commit 25ef7bf24446905e3a33083202acaeec58cb04dd Author: OpenStack Proposal Bot Date: Mon Sep 11 21:34:25 2017 +0000 Updated from global requirements Change-Id: I3833b1f450b969e54a9869af9effe2c82a4b4a83 commit 97b98c97e779a29587e2155bbd6b1b7f7056e746 Author: Samuel de Medeiros Queiroz Date: Mon Sep 11 14:37:32 2017 -0300 Remove keystoneclient dependency Since all the keystone client calls have been moved to direct REST calls to keystone server, the dependency can be removed. If someone is getting a legacy keystone client from shade directly, they will be warned to 'pip install keystoneclient' themselves. Change-Id: I653dead3992be09c003aab911dda7cbf892cc9c1 commit d0ca641f8e42893cffcb98bb960cf4d98941f0a4 Author: Samuel de Medeiros Queiroz Date: Sun Sep 10 10:45:44 2017 -0300 De-client-ify Endpoint Create Change-Id: I916dea906886955e8c7d074d5d1d69f29ff5bdf3 commit 941e179e535a2a4ba0df8387abe2d4391644b36c Author: Samuel de Medeiros Queiroz Date: Sun Sep 10 10:45:44 2017 -0300 Refactor the create endpoint code The code is rather complex, this patches improves its readability Change-Id: I0b79217b89fdd636cbf8da241cd7e1af24f07371 commit f3e62250438c347424969fafe3b90a04ecf62890 Author: Samuel de Medeiros Queiroz Date: Sun Sep 10 10:17:55 2017 -0300 Reorganize endpoint create code Group the code for v2.0 in a single if statement. Idem for v3 Change-Id: I12f9a571b33b38e9e0e75fe11c877cca4905e78c commit 605301f99af38d388af3b0500e734c8afc2528a8 Author: Monty Taylor Date: Fri Sep 8 18:45:22 2017 -0500 Switch to constraints version of tox job Change-Id: I4c874df5b0c7f6d28b4dea6b25b32aba95cf6db9 commit 8daf38fb6ace805383fae63ac60b500756decd0a Author: Monty Taylor Date: Thu Sep 7 07:46:06 2017 -0500 Convert test_baremetal_machine_patch to testscenarios We have a helper library that handles this sort of thing. Change-Id: I58f50663ab9c026918088845cceecf78ff15d8c8 commit 960a27447c3c18ba9a68dfe91e01cc629cd3b16f Author: Paul Belanger Date: Fri Sep 1 17:43:47 2017 -0400 Add openstack-doc-build to shade Validate shade is able to build docs using openstack-doc-build with constraints. Change-Id: If419a417d717fe4d5a6da452adf65f63bb8d93e6 Depends-On: Ib998f83135a4fcb796a205e52c435ab29b7cab7b Signed-off-by: Paul Belanger commit ff709954362cf37c21bbe5ede8c4d4ed81d64f48 Author: Monty Taylor Date: Sat Sep 2 15:24:58 2017 -0500 Switch to normal tox-py35 job Change-Id: Id307bd15b0c1b43ce7fba15ac5230c7d26b2a5bc commit 73ef1f549c922759ba6c74f2bb6c0f1a4c72e6c2 Author: Matthew Treinish Date: Fri Aug 4 15:21:38 2017 -0400 Switch to using stestr stestr is a fork of testrepository, designed specifically to concentrate on being a dedicated test runner. [1] The testrepository project is basically not active anymore and has several long standing bugs and useablility issues. stestr is still actively maintained and fixes a large number of those issues with testrepository. [1] https://github.com/mtreinish/stestr Change-Id: I9b8049fd2c78d8f90aed5a8b35c0a9b40ad8c463 commit b817f47782b05416c7b14ae67d0786b1e380d134 Author: Julia Kreger Date: Fri Sep 8 18:53:52 2017 +0000 Migrate machine tests related to state transitions Migrating the machine tests where state transitions occur, such as turning power on/off, maintenance mode, hardware inspection, and general provision state changes such as activating a node and deactivating a node. Change-Id: I88663fecb79247d5473c47847f9c7405f447a80d commit c821c977b937285d16adff7ba7ee154931852fdb Author: Julia Kreger Date: Fri Sep 8 04:05:56 2017 +0000 Migrate machine inspection tests to requests_mock Change-Id: I53bfeff53d569a8075b40e4fb1087357f7eb4da0 commit e8d37f8281192838fe5ca1b1dc86b4a69b44f061 Author: Julia Kreger Date: Thu Sep 7 06:10:27 2017 +0000 Migrate additional machine tests Migrated a number of simpler machine tests to using rest calls, while removing the mocked client versions of the tests. Added additional patch_machine tests, which raised the fact that patch method was not normalizing the data being returned. Added normalization since those fields are not normally returned by get_machine. Change-Id: I1c5f4ebd06fff40da45dbcc0d6ea0f7b108ce8fa commit 8cc1483cc153254b54d96dd615dd174e4dc3c6c5 Author: Samuel de Medeiros Queiroz Date: Wed Sep 6 13:55:26 2017 -0300 De-client-ify Endpoint Update Change-Id: I823414cbee3b8f38fcbddd16271ff61005eaf35d commit 8afeaf60b164120c240b54fbbb36ccf5b73ca299 Author: Samuel de Medeiros Queiroz Date: Wed Sep 6 10:53:43 2017 -0300 De-client-ify List Role Assignments Change-Id: Ief3fd56ccab977399c71cd603e42b52296e2a002 commit 179430c9868321bbc91f12376f44c4e1433fa7fb Author: Samuel de Medeiros Queiroz Date: Wed Sep 6 07:14:38 2017 -0300 De-client-ify Endpoint List Change-Id: If711f71ec05a03e5613cf25849c7b6a68f23eb55 commit eb28fa57510267b63d9a8647bb12e31d94539430 Author: Samuel de Medeiros Queiroz Date: Wed Sep 6 06:46:52 2017 -0300 De-client-ify List Roles for User in v2.0 Change-Id: Ic652a38ba86594540ac4a4f5d944a8cd627d60f5 commit 8d310b7818798d828d0fac8c90553bccb26228d9 Author: Samuel de Medeiros Queiroz Date: Tue Sep 5 20:59:55 2017 -0300 De-client-ify Role Grant and Revoke Change-Id: Ie0a9748132ef7f417aabf976be21ec2d32085c8b commit a4f94bf4def73704ff4947f9874845bca314239d Author: Samuel de Medeiros Queiroz Date: Tue Sep 5 14:51:32 2017 -0300 De-client-ify Endpoint Delete Change-Id: Ieea67d733a20af6ecb7fde88d6af85f8b0cf2c18 commit 76caad4d420abe16895b54d40fa89462397f8240 Author: Samuel de Medeiros Queiroz Date: Tue Sep 5 14:14:09 2017 -0300 De-client-ify User Password Update Change-Id: Idfafc845e44c5a2eb9c6f334a1a4d7eb83c7ce2c commit 4de4fb4a5aeb25e05f85d4696d60cd2794084348 Author: Monty Taylor Date: Tue Sep 5 09:46:41 2017 -0500 Begin converting baremetal node tests Shamelessly based upon pre-existing requests mock code in shade, with the attempt to replace the existing baremetal client mock testing. This updates the way we're creating the ironic_client so that it always does discovery, which _baremetal_client will always have to do because of how the versioned discovery document is in ironic. It also puts in a workaround for a bug that was found in keystoneauth's new version discovery that we should eventually take out. Change-Id: I0e811d69c3cba50f164cb2a3a1302b88fba51308 commit e76896046dcafe3832beb19927621225e9bdecb9 Author: Samuel de Medeiros Queiroz Date: Mon Sep 4 11:01:27 2017 -0300 Remove improper exc handling in is_user_in_group Since we are already catching the expected exceptions for that operation there is no need to catch Exception in that method. Also, the message was saying "error in adding user to group", but that method is just checking ... Change-Id: I3b6fb28773a6c52b223bca4964dba4ccc27f9787 commit e42192e8393f01e825a8b8f5628f7813ae49c4bb Author: Samuel de Medeiros Queiroz Date: Wed Aug 30 18:50:42 2017 -0300 De-client-ify Remove User from Group Change-Id: Ica1cc5e472cfc14f9afeb05db5fa82cfd8ece500 commit be9d046925ecc204bef5a69212b123ce9c3a1039 Author: Julia Kreger Date: Tue Sep 5 00:22:10 2017 +0000 Correct baremetal fake data model In preparation for rewriting tests to use mock_requests, we should need to correct the object naming to match what is defined by the baremetal API. Change-Id: I55c4c895e9fd1f09992bcc9059b7ca132af977cf commit 30e0fbcfd77286fa25b50061637976cd94c2710f Author: Samuel de Medeiros Queiroz Date: Wed Aug 30 18:46:01 2017 -0300 De-client-ify Check User in Group Change-Id: Ia4ff42cf25b3ccad54b4870cde5a5a7e7c6acad6 commit b82a659f7958d39de62e34558987086e6f02bebf Author: Samuel de Medeiros Queiroz Date: Wed Aug 30 18:29:15 2017 -0300 De-client-ify Add User to Group Change-Id: If80267260c6db0440b36ac2e8ce74691eb1948da commit 149a9fbc7841d70b9f9db1ab109eb3060a12bfff Author: Rosario Di Somma Date: Thu Aug 17 12:58:03 2017 +0000 Use direct calls to get__by_id This commit adds a `use_direct_get` flag to the OpenStackCloud object. The goal is to enable direct calls to the get__by_id methods when a UUID is passed and default to the `list` and `search` calls otherwise. Change-Id: I6aebfe7cb40adace0568d8f131e64d6555736712 Signed-off-by: Rosario Di Somma commit ca0103a0a2e4f2772895f904b52e02cd6cd2ccc4 Author: Samuel de Medeiros Queiroz Date: Wed Aug 30 16:56:06 2017 -0300 De-client-ify User Update Change-Id: I2f0917eed4464944b4552972baca838be8e6866e commit 8b47d15fd5a3f67072e82ca8fc4928f57d9c96c8 Author: Monty Taylor Date: Mon Aug 14 10:05:19 2017 -0500 Use new keystoneauth version discovery We can remove a ton of our logic. We still need SOME because we have a different fallback strategy that isn't appropriate for keystoneauth generally. There are a couple of tests removed, since they were testing shade code that was removed. Also it's worth noting that there are tests in test_domain_params and test_image that are mocking the client rather than mocking the requests and we should fix those. Co-authored-by: Samuel de Medeiros Queiroz Change-Id: I78019717cdee79cab43b0d11e737327aa281fd03 commit 469cc5ae49ef4cfcaee302b95ce81dccf9faa945 Author: Monty Taylor Date: Fri Sep 1 08:13:22 2017 -0500 Fix typo in tox.ini Change-Id: I320460d9226f3f4dba782047f83466c0dbbd7e56 commit 371c3ebc0ee28c5e6c0d942c6efc8b16553b80db Author: OpenStack Proposal Bot Date: Fri Sep 1 12:44:43 2017 +0000 Updated from global requirements Change-Id: I7b1217cd50a3e3c89edcb5bda1d22cded90e9b4b commit 8dc051ce3f0a885f2bfab748ba412e5b0239cc5d Author: OpenStack Proposal Bot Date: Fri Sep 1 12:34:00 2017 +0000 Updated from global requirements Change-Id: I2b75a24df0ad5779ac9b2f0a87453ffcc49b3dbe commit 78a1aa3b931b2ad7fd2820292ba4060eb6feb043 Author: Monty Taylor Date: Thu Aug 31 08:38:33 2017 -0500 Add tox_install.sh to deal with upper-constraints shade is in global requirements and upper-constraints now, which means we need to use the tox_install.sh script so that constraints don't break install of shade itself. Change-Id: Id286b634046519e34ac2c01461391d5bc61cd919 commit 8887b483e193cebc5b4a8df12b3325ec4e8938c5 Author: Sam Yaple Date: Thu Aug 24 12:34:49 2017 -0400 Support domain_id for user operations When using ldap you cannot list all users across all domains. You must explicitly declare the domain you want to list. Change-Id: I83d8e313a86a527ea4ccf83cb8c329a7123c2943 commit 4695f5c1b6960c475632e80eccce63bb4d8c39f9 Author: Sam Yaple Date: Thu Aug 24 14:04:03 2017 -0400 Add domain_id to groups When groups are hosted in ldap you must query the domain explictly to list the groups Change-Id: I5be672c3eae5e013525cc7c0a4d73f9166f379ba commit 589b765574d457d2ed9f87b4fd41cf38b4634d1e Author: Sławek Kapłoński Date: Tue Aug 29 21:58:40 2017 +0200 Add handling timeout in servers cleanup function In functional tests in method which cleans server and volumes attached to it, there was sometimes reached timeout, probably because one of resources stuck in "deletion" state for longer than 180 seconds. This patch adds handling such timeout and in such case, try to call delete of server and each volume but without waiting for deletion to be completed and with "force" option in case of volumes. Change-Id: I7a8caf2e89348ae0931a7e7e30ce2a83c4d12e5a commit 1935528ed750b6f3d3d0be6c95a61d511d63076c Author: Sławek Kapłoński Date: Tue Aug 29 21:34:45 2017 +0200 Fix handling timeouts in volume functional tests cleanup This patch adds handle for fixture.TimeoutException in same way as it was done for OpenStackCloudTimeout. It also changes cleanup function that it will not wait for delete of volumes if volume was stuck in "deletion" state. Delete volume with "force=True" will now be call with "wait=False" Change-Id: Ie6a8c7aecaf36b07247b61296d68afd923280440 commit 68f0947ba09baeb545474f0bbb808262613439d6 Author: Sam Yaple Date: Fri Aug 25 21:17:51 2017 -0400 Fix switched params Fixes a reversal of params in get_domain() Change-Id: I3f6e763a2378f52954c9d835a233867fb46f3e56 commit 7fb83a668d73b53e84d8994a802b1e6b14ecde32 Author: Samuel de Medeiros Queiroz Date: Thu Aug 24 06:33:45 2017 -0300 Switch to _is_client_version in list_services Change-Id: Ie7e77c4a766d01557222decdab48fb206086e57f commit 522f51cdf60ed214f07430d0fe01e1638654322c Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 12:53:35 2017 -0400 De-client-ify Service Delete Change-Id: I9a034bf240450574dfcc6ab8074db708002d0659 commit 4cd71a139db8745d63b12389ed2029e1e762072c Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 12:12:06 2017 -0400 De-client-ify Service Update Change-Id: I161b680c6f165d298538ec4e13264deeb92a8453 commit b05aede84bbcb3707be1c4da0c596844ae1f2a60 Author: Sławek Kapłoński Date: Wed Aug 23 21:34:04 2017 +0000 Fix cleaning of Cinder volumes in functional tests There is some issue, probably with Cinder which cause sometimes problem with removing of volumes. Such volumes stuck in "deleting" state in Cinder. This patch changes cleanup method from functional Cinder test that it will not raise exception (and make test fails) if volumes will not be cleaned properly. In such case cleaning will try to delete volume once again with "force=True" and will move forward if it also fails. This change shouldn't cause any new problem with reached volumes quota limits becasue before this patch such volumes were also not removed properly. Change-Id: I984f863b55b46fe6eba4a7ec31434ee4d2baa16f commit bda65e7265247b2d20d8d18d0cbf344bee119425 Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 12:19:42 2017 -0400 De-client-ify Service List Change-Id: I22149f4dd2d63b0f3b809015f4e9633f20a0a1d0 commit 3cfaa4c63b0ff54f45da59ee48fcb9e5ea57dde5 Author: Sławek Kapłoński Date: Thu Aug 17 21:07:54 2017 +0000 Add option to force delete cinder volume Cinder's API gives possibility to force delete volume which is in state 'deleting' or 'error deleting'. This patch adds support for such force delete of volume to shade. Change-Id: Iffede494e5af250a6bfea98e1fbfd8014eff0b02 commit 20cc034f65a7591c85bfd3c31204c4004375800c Author: OpenStack Proposal Bot Date: Fri Aug 18 13:29:21 2017 +0000 Updated from global requirements Change-Id: I00bdd8c84248ed6f8df6c2b5e593dfe21acc07ec commit b5af1ae9367db42a50fa926f0f0bcd3f2ea56e9a Author: OpenStack Proposal Bot Date: Fri Aug 18 11:39:22 2017 +0000 Updated from global requirements Change-Id: I805c30c0a522c03721a97118594030b9c8dfcd51 commit 89e07d905a94525a0813e6e467da9f5cd94a1c8d Author: Sławek Kapłoński Date: Wed Aug 16 20:36:01 2017 +0000 Fix determining if IPv6 is supported when it's disabled On systems where IPv6 is completly disabled there can be AttributeError when shade tries to determine if IPv6 is supported or not on local system. Now it's fixed by returning False always when AF_INET6 isn't available in netifaces. Change-Id: I45138bd42cb63ff59b6aed85f33da11aab43aaba Related-Bug: #2001001 commit e72a6cf6da2456c888d925b849ea544bba92f357 Author: Sławek Kapłoński Date: Wed Aug 16 20:31:27 2017 +0000 Don't determine local IPv6 support if force_ip4=True In case when user set in config to force usage of IPv4 shade will not try to check if IPv6 is locally supported or not. Change-Id: Id12df5de0de58bbe427301c8a32d4c622dfbcc99 Related-Bug: #2001001 commit 7466aaedfa202dc416fbb02b2a672fb8d94c4f92 Author: Samuel de Medeiros Queiroz Date: Mon Aug 14 13:26:46 2017 -0400 Consolidate client version checks in an utility method Change-Id: I8da6f940a5983ce38a4a5bdc054f203088c51c48 commit d8ddbcf749f695288a16f3488e12022c62a620e6 Author: Sławek Kapłoński Date: Sun Aug 6 15:20:37 2017 +0000 Add functional tests for Neutron QoS policies and rules This patch adds functional tests for create/list/update/delete QoS policies and rules. Change-Id: Iebff3309423bea1fa871612c5e824940c13926c1 commit 15a83dab9a8fa68f983903a65fb656104379da5d Author: OpenStack Proposal Bot Date: Sat Aug 12 11:50:13 2017 +0000 Updated from global requirements Change-Id: Iad6eba535f48d0f09e5507db32399623f63a4f88 commit 164501c71570eac15c7be55d0400c400e502bc8b Author: Sean Handley Date: Fri Aug 11 14:12:12 2017 +0100 DataCentred supports Keystone V3 and Glance V2. Change-Id: Ia8c656e2c6b97c877f5028fef8a94a2c41909bc5 commit 4e5d46df7661051db37b48d84ffc5c096be63a55 Author: Rui Chen Date: Wed Aug 9 18:02:37 2017 +0800 Support to get resource by id For finding specified resource, we list all the resources in get_xxx(name_or_id) method, then find the result in list result loop, that might have poor performance and slow response when there are many resources in a project. OpenStack API support to get resource by id directly, and part of them had been implemented in Shade, like: get_server_by_id(), get_user_by_id(), get_volume_snapshot_by_id. The patch aims to support more: - flavor - image - volume - network - subnet - port - floatingip - security group - ... Change-Id: Icb0af21c2d7e8bda07c072cc6098269304b7ab88 Closes-Bug: #1709577 commit 20ebacce1493e00410aeac4fbe0460dbc8b39817 Author: Monty Taylor Date: Thu Aug 10 15:56:20 2017 -0500 Make get_server_console tests more resilient The current tests can fail if the cloud just doesn't return real content. That's not what we want to test though - we want to test that the shade method calls the remote method and gets a result. Change-Id: I2238598c07d5ec51bd11ab019cf3f666ee2eaf7d commit d597ee271e1085e10f89fa9632491b3647ed95b1 Author: Joshua Harlow Date: Mon Aug 7 15:37:37 2017 -0700 Update globals safely The right way to update these globals is to use a lock and ensure that nobody else is updating them at the same time. Also update a temporary dictionary before setting the global one so that nobody sees partial updates to the global one. This should help fix the thread-safety of shade (and other tooling built ontop of this library). Change-Id: Ie0e0369d98ba6a01edcbf447378a786eec3f13f9 commit 240e2594b969fee06be5e5a38e414e6a12d5ba6e Author: lingyongxu Date: Mon Aug 7 15:10:02 2017 +0800 Update the documentation link for doc migration This patch is proposed according to the Direction 10 of doc migration(https://etherpad.openstack.org/p/doc-migration-tracking). Change-Id: Ida458338d353cbd6cc0162263db25f533b0bd9fd commit eed1cbb8cdbb9a1214277b5d38a4b75123ec14ef Author: Andreas Jaeger Date: Sat Aug 5 18:52:47 2017 +0200 Remove OSIC OSIC has been decommissioned, remove the now useless vendor data. Change-Id: I57c6043018e96c0069c7db777b9f585cb7d535e7 Related-Change: I2d1b0710e875bd1ebc305fb5b184b68bf18f2ef7 commit 697cf58c826c56ee1599d23ec1271933e8aae54b Author: Sławek Kapłoński Date: Fri Aug 4 19:19:58 2017 +0000 Make QoS rules required parameters to be not optional Some of QoS rules parameters, like max_kbps for bandwidth limit rule, dscp_mark for dscp marking rule or min_kbps for minimum bandwidth are not optional on Neutron's side so it shouldn't be optional in shade client. This commit changes them to be required in create methods. Change-Id: I6919690d5fe024698dc76bf9808ec8ada80d2ae8 commit 2d547522572962760f2c7081e795a40694296f51 Author: Sławek Kapłoński Date: Tue Aug 1 21:41:56 2017 +0000 Use valid_kwargs decorator in QoS related functions This patch switches all QoS related functions to create/update policies and rules to use _utils.valid_kwargs() decorator instead of validating manually if each argument is None or not None. Change-Id: Ieea34d653e60a97963f7030424ea0f3138c169c2 commit 737f9de574b57f33d748368415df9822a48b44c4 Author: Sławek Kapłoński Date: Tue Aug 1 21:09:42 2017 +0000 Add support for get details of available QoS rule type Neutron with QoS plugin enabled can return details about details of support specific rule type in existing cloud. This patch adds support for getting such details in shade. Change-Id: I95d10f67f9d1c83eb9adb17127d9d7bba766ad6e commit 05b0fe25ccb82b69a986a1ebda3b65506c73b5d1 Author: Béla Vancsics Date: Tue Aug 1 10:17:58 2017 +0200 Use more specific asserts in tests Instead of assertTrue and assertFalse use more specific asserts. They are compatible with Python 2.7[1] and 3.5[2] [1]: https://docs.python.org/2.7/library/unittest.html [2]: https://docs.python.org/3.5/library/unittest.html Change-Id: Ie2e117935e12b9fb56c0b6070924786f9693421e commit 99865c9f77b9825498d60c7895c9784ffdaf70f5 Author: Sławek Kapłoński Date: Mon Jul 31 20:46:32 2017 +0000 Add Neutron QoS minimum bandwidth rule commands Create/Update/List/Get/Delete QoS minimum bandwidth rules is now possible to do with shade. Change-Id: Ibe2b28d15a9a8de58e9605330e241328c1cd242b commit 420e7454de7a2812f3938e84ee074b479620bd46 Author: OpenStack Release Bot Date: Fri Jul 28 21:08:43 2017 +0000 Update reno for stable/pike Change-Id: I03e74702143f0d8ba248c12aba2c179d6cbaafdd commit 8c8f365a9f143f2159339584f15a48bdf185b63d Author: OpenStack Release Bot Date: Fri Jul 28 21:04:06 2017 +0000 Update reno for stable/pike Change-Id: Ie69ff1e5a5d3cf3a762d6915c5d596de4f919931 commit 1521c59999ad9ef8acfd3e1486a4b9f7903242c0 Author: Sławek Kapłoński Date: Sun Jul 16 08:29:15 2017 +0000 Add Neutron QoS dscp marking rule commands Create/Update/List/Get/Delete QoS DSCP marking rules is now possible to do with shade. Change-Id: I3b233c28c28cfa27e2d15599e34bae60bad83d75 commit 1d4c124bb1c94ce475ca494b86dd69b09cbae0b4 Author: OpenStack Proposal Bot Date: Thu Jul 27 20:30:31 2017 +0000 Updated from global requirements Change-Id: I611163aecdc4810e6fd1d7e47e60171d72db0ea3 commit 85d8adaec6ac976a4c95f0796eaaca2ff15d4f67 Author: OpenStack Proposal Bot Date: Thu Jul 27 20:19:00 2017 +0000 Updated from global requirements Change-Id: I2da0ea1c58865c47396b001f1aa66c54ece57bfb commit a4fdee57310f9bca644e84e43787f04c5996ab98 Author: Lee Yarwood Date: Mon Jul 10 14:15:31 2017 +0100 router: Ignore L3 HA ports when listing interfaces L3 HA ports do not correspond to a router interface and should be ignored when listing these interfaces. Change-Id: I7fb5add36af09cc22084c8c034bf9f3cd0fbb442 commit f66f86207361d733faef7fc4c4712ae828eb4821 Author: Paul Belanger Date: Fri Jul 14 15:37:46 2017 -0400 Initial commit of zuulv3 jobs Here we are adding shade to zuulv3.o.o to aid in testing. Add UPPER_CONSTRAINTS_FILE to tox whitelist of variables. Change-Id: I4bc3bd751a80308df3b2114f95886bd104516dd2 Depends-On: Ib9f0a787998f34414c8072074113d29cdb8cdb59 Signed-off-by: Paul Belanger commit 623593a6933da69000967abd7b6d3e2cf7cec954 Author: Dirk Mueller Date: Sat Jul 15 20:26:43 2017 +0200 Manually sync with g-r Change-Id: I4298bb7c2d66632b716b0dbeae64c9dca2b3434d commit 1b51cd83de845e4e4a5abbad22c6c94cd7a3f0f8 Author: rajat29 Date: Fri Jul 21 12:26:43 2017 +0530 Update the documentation link for doc migration Change-Id: Idd4909d94c07220425fbdce938c133d890c4be86 commit 06b390ad7c8971a8ce5bf51a05eea40b48b83d94 Author: rajat29 Date: Thu Jul 20 19:05:26 2017 +0530 Replace six.itervalues with dict.values() We should avoid using six.itervalues to achieve iterators. We can use dict.values instead, as it willreturn iterators in PY3 as well. And dict.items/values will more readable. Change-Id: I81fcf7cfdbd24784039ec2aca6a0c1f503a76502 commit d9091fb8ad63210fbdf72084d2d4a98305a45a1d Author: Samuel de Medeiros Queiroz Date: Thu Jul 20 06:48:38 2017 -0400 Consolidate the use of self._get_and_munchify Replace meta.get_and_munchify with self._get_and_munchify in operatorcloud.py Change-Id: I411a1d740ea96bd7a1ac9c3ae67d8d518bf619f7 commit e171aa4f6aeb34a830db1839ce11578b8adae379 Author: Samuel de Medeiros Queiroz Date: Wed Jul 19 07:26:42 2017 -0400 De-client-ify Role Delete Change-Id: I97c4e7a2cd9e6e3de9b5d03dc5b5476a9e595108 commit 2d777b911f1e26ee2d7002040099c6769e177f84 Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 14:45:49 2017 -0400 De-client-ify Role List Change-Id: I3e5a093f0d3b09b897afda7ed793a18a5732513a commit 8034894d81e05d8a790098c02805e9931f48718d Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 13:28:00 2017 -0400 De-client-ify Role Create Change-Id: I0b01b10907939cc93adfee9e53109893abfe62b1 commit 9b2e01d962bb1cfb3717c943a564a8d9fef48419 Author: Samuel de Medeiros Queiroz Date: Wed Jul 19 06:33:15 2017 -0400 De-client-ify Group Delete Change-Id: I07785bcee5cd312293ba9a3eed9aec8820378332 commit b7f90dc661636c5ea50f4d18188d45e2d71953f6 Author: Samuel de Medeiros Queiroz Date: Wed Jul 19 06:26:03 2017 -0400 De-client-ify Group Update Change-Id: Iff584891a07a619b57a1700351a7fe5f19ca8a57 commit 57f5c896e088c7d69a13fb26d536c8fb391c39cd Author: Samuel de Medeiros Queiroz Date: Wed Jul 19 06:07:06 2017 -0400 De-client-ify Group List Change-Id: If2b1f2aa064e33629307f457b94ba52b2dc02230 commit 9ca78367fd49763c20d2dbb92def2819f366fe80 Author: Samuel de Medeiros Queiroz Date: Wed Jul 19 06:01:32 2017 -0400 De-client-ify Group Create Change-Id: Id7674f3aacdfa1448c243fe0e3932dc5f303e9ba commit 67accb5b099eeab26d402d33073dd09bcedeb9b6 Author: OpenStack Proposal Bot Date: Wed Jul 19 17:59:42 2017 +0000 Updated from global requirements Change-Id: I96229428c485ca9ea9af79c3b5d5dbb43840f169 commit bf5cd53cbf79f35d4a08987bfc432e9a56489a01 Author: Rosario Di Somma Date: Sat Jul 15 22:37:38 2017 +0000 Don't remove top-container element in the adapter Change-Id: I0b375b5c6f3575216cbecc59285a6980fbe14314 Signed-off-by: Rosario Di Somma commit 262061afd05e9fd097e11f7b073a7dd0e3f44627 Author: Akihiro Motoki Date: Wed Jul 12 06:43:50 2017 +0000 Improve doc formatting a bit After migrating to openstackdocstheme, some shade document became not easy to read. This commit fixes them a bit. - openstackdocstheme assumee only one title per page. Use a different level of title for the title. Otherwise, titles with the same level are not shown. - Release notes page has a lot of sections. It leads to a long TOC in the user guide index page. Use maxdepth=1 explicitly for the release notes. - Add a link to a simple example to usage.rst. It helps users who access the user guide directly. Change-Id: If51afa471505296b502bed3288cc9bcf30a69ba3 commit a134c10ea443ff74aa558aa7e83a651083d0d910 Author: Sorin Sbarnea Date: Tue Jul 11 12:23:46 2017 +0100 Added useful links to README Fixes #2001116 Change-Id: I43c313fffe8ff0c0e8aa583adce7676872ce357b commit 806378f4f37f5dd421535b7961d705b0bc7f071a Author: Sławek Kapłoński Date: Mon Jul 10 20:45:37 2017 +0000 Add Neutron QoS bandwidth limit rule commands Create/Update/List/Get/Delete QoS bandwidth limit rules is now possible to do with shade. Change-Id: Ife015dd3f9584df901462b3998a4d775374073cf commit 9f78c543498c3c419418d3161ffe8bf5ea3d4253 Author: Samuel de Medeiros Queiroz Date: Mon Jul 10 11:38:10 2017 -0400 De-client-ify Service Create Change-Id: Ifc71043cbb40d2888cd9c8341f135e832c553d00 commit a9687a82fc14e3e9f6ce9925d27bf5699308914d Author: Lee Yarwood Date: Mon Jul 10 14:41:49 2017 +0100 Add debug to tox environment The oslotest package distributes a shell file that may be used to assist in debugging python code. The shell file uses testtools, and supports debugging with pdb. To enable debugging, run tox with the debug environment. Below are the following ways to run it. * tox -e debug module * tox -e debug module.test_class * tox -e debug module.test_class.test_method Change-Id: If0b06dcf094682401c4b09dd72493c678ea2a6b0 commit 20c1e82fa7c639a9f88fcd1cbcc57226ca6729c1 Author: Abhijeet Kasurde Date: Sun Jul 9 21:48:22 2017 +0530 Remove hard-coding of timeout from API This patch adds a fix for removing hardcoding of timeout variable in _upload_image_put method by adding method argument timeout. Change-Id: I01ac7d590bfc4aea1adf571bd56d52048723d570 Signed-off-by: Abhijeet Kasurde commit d1eea7a720bb14f6781ec5abadbc27fafdf85e1e Author: Monty Taylor Date: Wed Jun 28 12:52:40 2017 -0500 Make sure we don't fail open on bad input to validate Passing arbitrary dicts to validate does not validate that that's what we're sending to the API. Put in a validation check that the keys we're sending are the ones validate does something about. It's possible there is another param to validate we're not listing. If we hit a test that needs it, we can always add it. Change-Id: I75b24f4f640b7cf6ffebff494e1627569d74755a commit 10e6fbe44f53a0beff2a2e4d2243b3c2e7f96d8c Author: Monty Taylor Date: Wed Jun 28 12:38:05 2017 -0500 Make sure we pass propert dicts to validate In register_uris, validate takes a dict that matches the dict one normally passes to requests_mock - that is, it can take json, headers, etc. Unfortunately, our fixture doesn't error when one passes a normal dict to it thinking you're passing a json dict for it to validate. This fixes the call sites - the associated tests need to be fixed. Change-Id: I16f265fe41219be0f3b031eb8be26f740a65d665 commit 54d6e1d1847b0bd18e4ef1276be2b7044ab5b8f8 Author: Monty Taylor Date: Fri Jul 7 12:10:06 2017 -0500 Add flag to include all images in image list Recent Glance v2 hides images that are shared but not accepted. The way to see them is to send member_status=all, which is a bit low-level for a shade user to need to know. Add a show_all to list_images that defaults to False so that behavior doesn't change. Don't add it to search_images, because at the search_images level the user has the ability to pass in whatever filters they want. Change-Id: Ida2ea943168f5be56a60a94576bdcc6c8e1a9d24 commit af0dbbd86f671c4c33841a11a63698ace1e4869b Author: Sławek Kapłoński Date: Thu Jul 6 21:16:58 2017 +0000 Add support for list available QoS rule types Neutron with QoS plugin enabled can return list of rule types which are available in current cloud deployment. This patch adds support for listing such available rule types in shade. Change-Id: I005b34b129bfe8e1ac4deb6dbeefad2ffe5ce023 commit 4446ba9920315ff57b8bd39bc2fdfaeec02d056b Author: Sławek Kapłoński Date: Thu Jul 6 17:46:14 2017 +0000 Add validation of required QoS extensions in Neutron Before operations on QoS policies shade can now check if required extensions (qos and qos-default) are available in cloud. Change-Id: I81727e25b72580d748757ead2c9a38708160d6c5 commit 29dd83d4e0fedcc9ae36576ff3293ac4d2252d27 Author: Samuel de Medeiros Queiroz Date: Tue Jun 27 20:54:02 2017 -0400 De-client-ify Domain Search Change-Id: If3e2d677cbc8f936144ae1e433eb3f23540e90eb commit 1bd19cca5cab0792c906bb1417c771ee960e10ca Author: Samuel de Medeiros Queiroz Date: Tue Jun 27 20:39:42 2017 -0400 De-client-ify Domain Get Change-Id: I43dab8b2cbc9f3f9f2e34fdd7d0cec915d3abdb8 commit cac429f4a9fe940fc03dc0f06c8f79e64f95d2df Author: Samuel de Medeiros Queiroz Date: Tue Jun 27 19:38:53 2017 -0400 De-client-ify Domain List Change-Id: I08332dc617fe2f77ddefa6dded86fe964b4fd1e0 commit ecd470db33bd1458a346f95355b111882073d43f Author: Samuel de Medeiros Queiroz Date: Wed Jun 14 21:37:00 2017 -0400 De-client-ify User Create Change-Id: I29b8502883f6ce58e6d2dcfb72df38d6989c18f9 commit ab2c4b314fc0a58c138dd2798a947be1fd957208 Author: Monty Taylor Date: Wed Jul 5 08:56:49 2017 -0500 Use the right variable name in userdata encoding The variable is "userdata" not "text". Change-Id: I1fecdf088f3aba744b5060e36dcfe62674772d1b commit e3753627042e53ecc9086736ed47ecf4b1e623ff Author: Sławek Kapłoński Date: Tue Jul 4 22:08:04 2017 +0000 Add searching for Neutron API extensions Shade client can now check if required API extension is available in Neutron. Change-Id: I9ffe431b23ac8586d327489347abaa40b0c1d775 commit 67b053c7b1a640de98bc5d243d8db3db227a2dac Author: Sławek Kapłoński Date: Sun Jul 2 20:49:34 2017 +0000 Add Neutron QoS policies commands Create/Update/List/Get/Delete QoS policies is now possible to do with shade. Change-Id: I127463dff9f73307aaac7ebb6927ef23599d3682 commit 790fffd37a4fa1ab584c40c0abeb56b7373d53df Author: Samuel de Medeiros Queiroz Date: Tue Jun 27 19:31:00 2017 -0400 De-client-ify Domain Update and Delete Change-Id: I56e661ca38e9a94ab43ccc3c0cc45a42976eac3d commit 1e1c6ac1d8c1bc9e994bef3610d07ed3b44b8ff9 Author: Samuel de Medeiros Queiroz Date: Tue Jun 27 14:39:01 2017 -0400 De-client-ify Domain Create Change-Id: I09426fd4fd374bdb64f42f3b31862dd3b898310d commit 65ce1a22896e52ff59a23a393e3bc4227f55f006 Author: Doug Hellmann Date: Fri Jun 30 10:14:38 2017 -0400 switch from oslosphinx to openstackdocstheme Change-Id: I83c5856a49cdfd912eb2d62314848a4cc4905fe1 Signed-off-by: Doug Hellmann commit 20b2f1f0c0402f28b6dde1e8ff0c5416edb6d21e Author: Doug Hellmann Date: Fri Jun 30 10:07:41 2017 -0400 reorganize docs using the new standard layout Move the docs around a little to allow the new templated docs.o.o site link to things like the user and install guides in the expected location. Change-Id: I7f3b625c04aa6cd2a7ebe5f2ce4a398cf464b1cc Signed-off-by: Doug Hellmann commit f74902b0b9f82e221b1ae1af7f254dc2918f96b8 Author: Doug Hellmann Date: Fri Jun 23 14:53:54 2017 -0400 use openstackdocstheme html context Set some of the new config values and enable openstackdocstheme as an extension so it will inject values into the page context as it writes each documentation page. This ensures the pages link to the right bug tracker, etc. Change-Id: Id9cc61e81aa43f4b69883d338090716005477d0a Signed-off-by: Doug Hellmann commit 071e3429103a027fb579399907f4976b894ffd12 Author: Rosario Di Somma Date: Tue Jun 27 22:15:42 2017 +0000 Don't remove top-container element for flavor, zones and server groups Change-Id: If85a133be034b27253bd6ddd36cf8a9224ab1673 Signed-off-by: Rosario Di Somma commit 70d8cc39df1093a69618ba1d1a6eb41ef1842baa Author: OpenStack Proposal Bot Date: Tue Jun 27 12:07:54 2017 +0000 Updated from global requirements Change-Id: Id6df6784e14fa6dfd4543ab54f9c2e01c87c69cf commit c016f15867d53b7054e8d8561dd5de4d995adc3c Author: Rosario Di Somma Date: Mon Jun 26 23:20:09 2017 +0000 Don't remove top-container element for flavors and clusters Change-Id: Ie48b477a35f448bfddd561bec68f30a5eb452e97 Signed-off-by: Rosario Di Somma commit f4668b7c6f0a2578ae6a96516e02ec1ff754c1b4 Author: Samuel de Medeiros Queiroz Date: Fri Jun 23 10:48:51 2017 -0400 Project update to change enabled only when provided The project update call considers enabled=True as the default, causing the project to always become enabled unless enabled=False is passed explicitly. This patch removes that default and only touches the enable field when it is explicitly provided as enabled=False or enabled=True. Closes-Bug: #2001080 Change-Id: I0a3b926b42be0321d06ebc370e4f51eba4150a50 commit 30c8729f782c0c13ca872260085d5b7b7c37df61 Author: Doug Hellmann Date: Thu Jun 22 15:26:16 2017 -0400 switch from oslosphinx to openstackdocstheme Change-Id: Ie45909df0b5a118d0200a1ee71277f4dbfe41d08 Signed-off-by: Doug Hellmann commit 412f0fdd8503d4a5b67d5ec55021fd0a9f452984 Author: Doug Hellmann Date: Thu Jun 22 15:17:54 2017 -0400 turn on warning-is-error in documentation build Change-Id: I18cdecec84f8dd5f11741ac1ffc35630f7eb64b8 Signed-off-by: Doug Hellmann commit 95f44f171c614cb0bb1650eb0062baea5c96f25d Author: Doug Hellmann Date: Thu Jun 22 15:15:52 2017 -0400 rearrange existing documentation to follow the new standard layout Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454 Change-Id: Ib68812eda4ab0ce09c6d438f9f236111d61ef38b Signed-off-by: Doug Hellmann commit 1069d44810c57aaa3191ec77dc766001c7bd6327 Author: Monty Taylor Date: Wed Jun 21 04:20:35 2017 +0100 Fix mismatch between port and port-id for REST call The old novaclient parameter is port-id, but the rest wants port. We should really stop having so much logic in os_server. Story: 2001075 Task: 4700 Change-Id: Ia16f8effca705e04b01fee5c2e899d90d084acb4 commit 14216dc5c9b7ab338d264d96b02db6c1f902b634 Author: Monty Taylor Date: Wed Jun 21 02:39:00 2017 +0100 Remove a direct mocking of _image_client Change-Id: I21505fc5b0b043f9c32c3ee568b48db9c32ff23e commit bc942953bc4a39c7696624dab6b59d06ad4f3298 Author: Monty Taylor Date: Wed Jun 21 02:15:12 2017 +0100 Fix image normalization when image has properties property In the somewhat pathological case of an image having a property named properties already that contains a non-dict value, image normalizaiton becomes quite unhappy. Fix it. Change-Id: I2ce4dd4e3b7a4a9b46ff2bf699d2c8517e1ce7ce Story: 2001073 Task: 4697 commit 74522a1a224a5379649645ad57e916fe003638bd Author: Monty Taylor Date: Tue Jun 20 16:10:01 2017 -0500 Fix delete_ips on delete_server and add tests This codepath was basically completely untested and essentially completely broken. Fix the break, but also add tests for it. Also add tests for config_drive while we're in there. Change-Id: I9f44474000213bab9e08266a376e41fecc4fbc1f commit 16cd2cc88b19130769b6dd5b7f3c3ce8752bdb9d Author: Monty Taylor Date: Tue Jun 20 23:49:03 2017 +0100 Fix config_drive, scheduler_hints and key_name in create_server We don't want to pass these if they're None. Turns out - we don't want to pass them if they're False either. Change-Id: I421b4e537892deead1866ddc979565e86fbcb211 commit 6334250493624aa56a7062c394442026dea5dfca Author: Monty Taylor Date: Tue Jun 20 14:37:49 2017 -0500 Don't fail hard on 404 from neutron FIP listing We do a filtered FIP listing from _delete_servers, which has exposed our list_floating_ips method as dying hard when it can't find a match. That's pretty inconsistent with the rest of the API - return a [] in that case but keep logging the big error message. The user should really mark the cloud has floating_ip_source: None if they want the error message to go away - which is indicated in the error message. Change-Id: I76493e7cc004831c1a0620de9fbe004fdbc39e45 commit 45e689942676f52f5a405262b41c0d60a0d681ab Author: Monty Taylor Date: Tue Jun 20 14:47:24 2017 -0500 Only search for floating ips if the server has them We have a server dict, which has an addresses dict. If the addresses dict does not list any floating ips, then there is no need to spend the API call to look for the fip ids needed to do the delete. Change-Id: Iaf7583fe29bd197a59ae2728fd52d8de2ac1d411 commit 2486e09b67c20254f780a1f2cee941c4345553d1 Author: Monty Taylor Date: Tue Jun 20 07:44:30 2017 -0500 Don't try to delete fips on non-fip clouds There is no need to even go through the logic. We have a flag for this. Change-Id: I103a2f346344d7a1eed5c54b58d279f04a1f76a3 commit 10beaf9c43a19220b61b7e979f6e46f0056410c5 Author: Monty Taylor Date: Tue Jun 20 07:42:59 2017 -0500 Return an empty list on FIP listing failure We don't want a 404 - we want an empty list. Change-Id: Ia30077d4093b224485b9953c5ad9d2d7c811ec50 commit 410a4558db80874dd34352ebc2c761b18404f0a7 Author: Rosario Di Somma Date: Mon Jun 19 19:37:27 2017 +0000 Don't remove top-container element for server REST API calls Change-Id: Ic44e99b95a546bbc62562634340f14033ae1e346 Signed-off-by: Rosario Di Somma commit 5512e46933b894d447c4b19917e1cd1cfebae6f7 Author: Monty Taylor Date: Mon Jun 19 08:17:43 2017 -0500 base64 encode user_data sent to create server user_data is base64 encoded, which novaclient did for us previously. Since we no longer use novaclient, we need to base64 encode it ourselves. Change-Id: Idf2320f43ba81b3ddc3b1c0016c7f872b5c5319b commit 3aee4f5e6ea3ec4a49442c905a4bd43b1e7b13a9 Author: Monty Taylor Date: Sun Jun 18 12:54:05 2017 -0500 Remove novaclient from shade's dependencies All calls to nova are now done via REST. This means we can remove the dependency. Only two more to go ... Change-Id: I01a0afef5986b7452fd73e04c48568ebb9817681 commit 56524c16a82f0b75cb9e576eb74982d8b19fb105 Author: Monty Taylor Date: Sun Jun 18 12:50:24 2017 -0500 Translate final nova calls to REST Change-Id: I89e0e59ec1ed6a81843da61bd3fce49d57da7c17 commit 56244f54103c076444a1e8793fa78b6753350961 Author: Monty Taylor Date: Sun Jun 18 12:22:27 2017 -0500 Convert remaining nova tests to requests_mock Change-Id: Iff4341f2c83493c901f5e18570f82b0b5f7f3ad5 commit a2ec277bf5f6ee63b7396894975a104401dfd284 Author: Monty Taylor Date: Sun Jun 18 12:09:45 2017 -0500 Convert host aggregates calls to REST Change-Id: Ic250e904e1a51d659c2599591e2b4274ebc5d1c0 commit f1778968de1125f48165efb1694be4c1a951aab9 Author: Monty Taylor Date: Sun Jun 18 11:51:07 2017 -0500 Convert host aggregate tests to requests_mock Change-Id: Ia2f5ef2798c57c88a0b3735db3381e1fbc20d9fa commit b1faf5bdd12fdd2cb08c0f08e05223f103171dcd Author: Monty Taylor Date: Sun Jun 18 10:53:59 2017 -0500 Convert hypervisor list to REST Change-Id: Ie08b2e2e9ef0b27e9faa27d38934e97c74c76305 commit d69b81fe00627b527a8c999bd9ce7ac9ac689d30 Author: Monty Taylor Date: Sun Jun 18 10:50:53 2017 -0500 Convert hypervisor test to requests_mock Change-Id: Ie9acb8582ab52580c90b3511acf5e28eed2f9abf commit 0ad08858a543d67f66e6576c49e7988c53038a28 Author: Monty Taylor Date: Sun Jun 18 10:41:20 2017 -0500 Convert Server Groups to REST Change-Id: If779c02521d0cf07d43f19ff9a11666838e4ac3b commit 3aec23cfd2a0477693e6684a97bfb3abbd3cd937 Author: Monty Taylor Date: Sun Jun 18 10:34:34 2017 -0500 Convert server group tests to requests_mock Change-Id: Ic4b137073e0c662d26cac254611708b3f31734e0 commit 611ce3dca1bf7b320ab075b4f05294c1f24fd4e3 Author: Monty Taylor Date: Sun Jun 18 10:05:19 2017 -0500 Convert FakeSecGroup to dict Change-Id: I0e0e1b87b0b32e8c015ba1f9944faf3b0e0738c1 commit fb956cce7b528eebc7332377d76c156cddcbd6ed Author: Monty Taylor Date: Sun Jun 18 08:19:21 2017 -0500 Remove use of FakeServer from tests FakeServer is a Fake of a novaclient object. Use actual json instead. Speaking of - transform the dict through json dump/load so that it's unicode where it's supposed to be. This makes diffs easier to make. Change-Id: I45c1136078f604c73c1fea54a9eb52bbbc8c69b5 commit 7cd4ef000153c7c4b8b3a43910ccb2bc4439c6c5 Author: Rosario Di Somma Date: Sun Jun 18 00:47:12 2017 +0000 Don't remove top-container element for user and project REST API calls Change-Id: I5d2ca9426f629014069f98ed9521556392c9d71d Signed-off-by: Rosario Di Somma commit b9a2c296e618d6ea07f8e91d995cc29885fe63c0 Author: Monty Taylor Date: Fri Jun 16 18:23:07 2017 -0500 Convert keypairs calls to REST Change-Id: Iea7c8267e87c5b5beb83e9315f41a61ae714005f commit caa69b4117ebe5f75d45adc805f67035d1d55855 Author: Monty Taylor Date: Sat Jun 17 08:46:23 2017 -0500 Add normalization and functional tests for keypairs Keypairs didn't have functional tests, although they do have ansible tests. Also, there was no normalization. Add both. Change-Id: Ib6fab25cf4c88e5f9d224e831a8b5f297b263aea commit c23611a093290b0f8882a4995cb0ab04de13888b Author: Monty Taylor Date: Thu Apr 20 10:33:14 2017 -0500 Remove future document This is a write up of an idea from several years ago which is both long in the tooth and honestly never going to happen. Go ahead and remove it. Change-Id: I4377cfb24c468f2333ac470a2a58fa97cf35d4bd commit 145a0ab7a3662615a9b5df5cad28b92dfb30884a Author: Monty Taylor Date: Thu Apr 20 10:29:53 2017 -0500 Add text about microversions We aren't doing anything with microversions yet, but since we just wrote down algorithms for version discovery, let's go ahead and talk about how microversions should work. Also, mention that it's important to fetch information about them as part of discovery. Change-Id: Iadd48cd53488240e33db83797a88af689b1497dc commit 587b41b0f6612c147fad93966369836b3e953a18 Author: Monty Taylor Date: Fri Jun 16 18:10:34 2017 -0500 Convert keypairs tests to requests_mock Change-Id: I85a9d19959e750995fed20a882eb8a9cae9add64 commit 70365c9f65cc04b711f96a418aac3ae23dc2fbec Author: Monty Taylor Date: Thu Jun 15 22:41:08 2017 -0500 Convert list_servers to REST Change-Id: Id3e60a9df87c3ca64fcabcb5c6d30b2b0bcb0b24 commit 83c8bf5a3439c8bf732604ca0de9098af312d6b0 Author: Monty Taylor Date: Thu Jun 15 21:50:52 2017 -0500 Convert list servers tests to requests_mock Also, found a few others that had been missed before. Change-Id: I9dfbabd2b5318a59b91edf4d8a62ccc0ccb9baa0 commit c5245648edcd2041d1df1f94f68c5d612fda6be9 Author: Monty Taylor Date: Thu Jun 15 21:38:56 2017 -0500 Remove some unused mocks Change-Id: I25c59933cd61eff31d02b3c763f6ebd5551d3231 commit 35980c1da8977db1cffb66975145ee5532a83fe8 Author: Monty Taylor Date: Tue Jun 13 21:35:02 2017 -0500 Break early from volume cleanup loop Change-Id: I540c4d860a60810d6ae6838ec558cc48cff67cf8 commit c431cc2c4bed6b8b181fd94b6d57098b32c68c83 Author: Monty Taylor Date: Wed Jun 14 18:08:27 2017 -0500 Add some release notes we forgot to add Change-Id: I05c31400e6f2e584a656c8ab422875be2d6f6bfe commit 6b325282d3ab2f848de372a80def36b01b6ba6f4 Author: Rosario Di Somma Date: Fri Jun 16 18:13:15 2017 +0000 Retry to fetch paginated volumes if we get 404 for next link When we get a volume list, it's possible for a volume to disappear causing the pagination to bork. When that happens we retry to get the list from scratch for 5 times. If all the attempts fail we just return what we found. Change-Id: Ia88d1d8a6b3558f7d5d364a9c78bbf834836d3f7 Signed-off-by: Rosario Di Somma commit daabd8cb9cded99ffeef9de34321bd9439d722b8 Author: Markus Zoeller Date: Fri Jun 16 11:21:41 2017 +0200 docs: make the first example easier to understand The very first example of the usage of shade is easier to understand if there is also an example of the needed `clouds.yml` file. Without it, it is unclear what the meaning of the key `mordred` means. Change-Id: Iad3aba66b0c6344157da30f374e191d01e938b2b commit 494d5d1e0fe2d600b43dd4ae9f7c9657a08bbc88 Author: Monty Taylor Date: Tue Jun 13 14:57:39 2017 -0500 Properly expand server dicts after rebuild and update Change-Id: I60568206c6b8900560ebd4f202aaaa5cd9f0d71e commit 972dcfcdf71feca95d166e1d9c152fcc097567fd Author: Monty Taylor Date: Tue Jun 13 12:27:31 2017 -0500 Migrate non-list server interactions to REST Change-Id: I999ea383909d01317f361ef55bee73db9fc1afbf commit 8ed5666501966ca8a2d9bfed8b9111f612b4dddf Author: Rosario Di Somma Date: Wed Jun 14 23:22:17 2017 +0000 Increase timeout for volume tests Creating and deleting volumes is slow so tests like test_list_volumes_pagination are often timing out Change-Id: I87f59bdfb527326a2a90a03d524e38d632ea7377 Signed-off-by: Rosario Di Somma commit 4fa316b778a88c92e4fcfd57480631d45cc2df5e Author: Monty Taylor Date: Wed Jun 14 14:43:13 2017 -0500 Skip pagination test for now The pagination test, although awesome, is killing the cinder in the gate and we're seeing an unworkable increase in timeouts. Skip the test for now allowing us to work on fixing the test without killing everything else. Change-Id: If83abbad9398cb97ca7fdc1d3f6d2d5473343664 commit 9353650d1d8325bc8836980f84fa14bbfd37d746 Author: Monty Taylor Date: Wed Jun 14 06:28:12 2017 -0500 Fix urljoin for neutron endpoint We just add a '/v2.0' to the catalog endpoint for neutron. However, if the catalog endpoint does not end in a /, this can turn https://domain.tld/neutron into https://domain.tld/v2.0 instead of https://domain.tld/neutron/v2.0 as intended. Change-Id: If16dc64dd9a4c9e525d042190632d0f4f0a4fb63 commit 19cddb559180ea22e26b7171f26ea692c32ee967 Author: deepakmourya Date: Wed Jun 14 11:54:08 2017 +0530 Remove py34 and pypy in tox No gate check for py34 and pypy Change-Id: Idcc0dd485d94ab66e52e086c6d5cda268c5aea07 commit 3bb46e4f7fb01484fc1d855d58b3b02b644ea96e Author: rajat29 Date: Wed Jun 14 11:45:44 2017 +0530 Replace six.iteritems() with .items() 1.As mentioned in [1], we should avoid usingg six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2.In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Change-Id: Iffdaadabccd6314643f668147f486103378a55eb commit 0d7fc5940a566cc21965ce68efaa0ef99edc593a Author: Monty Taylor Date: Tue Jun 13 14:16:35 2017 -0500 Update tests for server calls that aren't list Change-Id: I6abe198fc690fc04b35c0a90c3c3ee7a08cfdd08 commit a0abee2c5cd48501ea73a5e661a9acd15421ded3 Author: Monty Taylor Date: Tue Jun 13 07:53:27 2017 -0500 Convert delete server calls to REST Also, remove the GetServer task which was missed earlier. Change-Id: Ic7e5bf011193efc842f68de6b038942af6f23b7d commit 458b6e9c96c7a3e961f11be938718008cf644086 Author: Monty Taylor Date: Tue Jun 13 07:53:15 2017 -0500 Convert delete server mocks to requests_mock Change-Id: I1615aa825dffbddd33e5effc014415945a694e76 commit c085c4c5f911133a9add0b50e63c1f6c85f3121f Author: Monty Taylor Date: Tue Jun 13 06:56:55 2017 -0500 Convert get_server_by_id Already did all the tests during create_server. Change-Id: I10ade7ff0bf682691e4842e639726195253e1300 commit 36b659eed403aea3ecf8666a68524b8e0f8ef494 Author: Monty Taylor Date: Mon Jun 12 09:57:23 2017 -0500 RESTify create_server In order to create passing tags to the nics parameter of create_server, we need to support microversions. In order to support microversions, we need to be using REST. Yolanda needs to pass tags to the nics parameter, so let's go ahead and transition create_server since we want to anyway. Tests are modified to remove an extra GET call that novaclient makes that we don't actually need. A follow up to this will add microversion discovery, and then will add support for 'tags' being in the nics list. Change-Id: I04c3b08d80cf496dabec8ce7000ca5fb679fe3b9 commit 6b61f18ea20f622029939230730048e49e523fe6 Author: Monty Taylor Date: Mon Jun 12 15:34:25 2017 -0500 Don't fetch extra_specs in functional tests We don't need to get these with every list_flavors and they make the logs harder to read. Change-Id: I642f6e0f05b13b67e95ed2cefdf7230c2cda5e5c commit 9cb4b1dcf73de64dd0cc79bbbd9b4c32878c619e Author: Monty Taylor Date: Mon Jun 12 12:00:34 2017 -0500 Convert create_server mocks to request_mock Next patch will convert create_server. Note: this found a few bugs in the tests. Change-Id: Ia1c9d3a02e52b63756f61dbff77b90dc35e45d24 commit e5389891214837b50c15987b4337a0f4678422f8 Author: Monty Taylor Date: Mon Jun 12 17:28:37 2017 -0500 Add boot from volume unit tests The boot from volume parameters are complex and we don't test them. Change-Id: Ia4b8db8792d8343d1bc1c5525e24065f67b4646c commit e6573737638383ba7f7b0c4021b3ceb381cf2bc2 Author: Monty Taylor Date: Tue Jun 13 15:25:01 2017 -0500 Cleanup volumes in functional tests in parallel We spin up 8 volumes for pagination, but then we try to clean them up in series. That's bad for our timeout. Let's take a page from nodepool and just poll the list. Change-Id: Icda01fd21dca06e459fbdd3c1cbd31441b95cd7a commit 081930d3a925e7f0c8ed6fe9cd9d95818e3eca8a Author: Samuel de Medeiros Queiroz Date: Mon Jun 12 21:04:55 2017 -0400 De-client-ify Project Update Change-Id: I2c9c6ebe594268b1be78af7b1e25f110605a076d commit 18f9b64ced1aa7d294d844976a7ddde8a58bafc0 Author: Samuel de Medeiros Queiroz Date: Mon Jun 12 18:48:28 2017 -0400 De-client-ify Project Create Change-Id: I4003cda72ac6f4bfc083722983159409673d3098 commit d3df09107ead9d690461e9166c420b28050baadb Author: Samuel de Medeiros Queiroz Date: Mon Jun 12 20:54:07 2017 -0400 De-client-ify Project Delete Change-Id: I24522698dbb333edc7eec6087637a252c0f92ff1 commit 92370249542302cfd288b0843c61170659b819e6 Author: Samuel de Medeiros Queiroz Date: Mon Jun 12 17:46:11 2017 -0400 De-client-ify Project List Change-Id: I13cb90a46ca61716b04989574483cfb4b04fa6b1 commit 2b48aed90d7f236b0a72dbc90698ae7aa30bdfcf Author: Rosario Di Somma Date: Mon Jun 12 23:28:13 2017 +0000 Don't remove top-container element for sec group REST API calls Change-Id: I81cdf17fede6414bdbbd7c7ea0a7eb5efc8aced3 Signed-off-by: Rosario Di Somma commit db83c23be7d04debc3804906e12613a1616814cb Author: Samuel de Medeiros Queiroz Date: Mon Jun 12 18:03:33 2017 -0400 Improve grant docs on when and how use domain arg Change-Id: I76184b229d48d8bd3268c803400c2ab9d3fcab17 commit 5d204c32696456c4789985e6da503a30b118c854 Author: Rosario Di Somma Date: Mon Jun 12 15:56:12 2017 +0000 Don't remove top-container for stack and zone REST API calls Change-Id: I502c7a7bcae7a7efd6541d50cc9837c04d48cb63 Signed-off-by: Rosario Di Somma commit ebedf176c7e6e00cf4ae6110f2cb5ace5a8c66e9 Author: OpenStack Proposal Bot Date: Sat Jun 10 21:35:01 2017 +0000 Updated from global requirements Change-Id: I363e82513bb504ee7691c9283ab9763c40471fb6 commit 4fce8d91f401249c06db5a7d7b264588dcd547e4 Author: Rosario Di Somma Date: Sat Jun 10 16:07:38 2017 +0000 Rename obj_to_dict and obj_list_to_dict Since we are actually to munch objects and not dict, let's rename them to obj_to_munch and obj_list_to_munch. Change-Id: Id4d77520237503bbfede89638675402d143fffcd Signed-off-by: Rosario Di Somma commit 75ce1eae85c53cc517520d7208eb1091a9f7374d Author: Rosario Di Somma Date: Thu Jun 8 21:53:38 2017 +0000 Don't remove top-container element for network REST API calls Change-Id: I2cde7add2bc0c85afbcfd03992dd500ce3ec7a8c Signed-off-by: Rosario Di Somma commit 75ce9ad924c9315d747529e40788a9f4ccb35138 Author: Rosario Di Somma Date: Fri Jun 9 13:49:05 2017 +0000 Convert data from raw clients to Munch objects Change-Id: Ib6fcb0b18e550c75248eaf00f4a305f5882e6cdf Signed-off-by: Rosario Di Somma commit 40c4f3ca15f990572e3ebeb93f484b74ac9d392b Author: Rosario Di Somma Date: Thu Jun 8 17:56:32 2017 +0000 Remove unneeded calls to shade_exceptions Change-Id: I3dce6e9a9e25e763e4daa2be0495521876a27fd4 Signed-off-by: Rosario Di Somma commit f01a7d43ca3423650e9d2e0b90eea0b61dfde92f Author: Rosario Di Somma Date: Thu Jun 8 13:40:35 2017 +0000 Don't remove top-container element for volume REST API calls This is a first step in the process of removing the logic from the shade.Adapter that removes top-container element from the REST PAI response. The goal is to simplify the logic and move it into the REST API calls. Change-Id: I885ba0c8d1df8c6f33bd3e2e92d052a1614a917f Signed-off-by: Rosario Di Somma commit 766d6227a39f485ae7fbcb29acd68036d0bd5bc7 Author: Monty Taylor Date: Tue Jun 6 16:59:00 2017 -0500 Use get_discovery from keystoneauth If we use the get_discovery call, we'll re-use the keystoneauth cache. This removes the last stupid extra discovery call. While doing this, noticed the dns version discovery was wrong, but we weren't noticing because adapter magic. Fix it. Change-Id: I01d07554d094fffd498f21a9291710c8eb0041f6 commit ba36d445a71fb1c98168240a6a284e75154039f6 Author: Morgan Fainberg Date: Wed May 24 14:39:42 2017 -0700 De-client-ify User Ops Remove keystoneclient from some user CRUD ops. Change-Id: I95ab2b58e2895c7735cc5a65dbf401bbd7715ccf commit 752d01eb270c24a9058060be25cc51112669df25 Author: Monty Taylor Date: Tue Jun 6 15:18:56 2017 -0500 Add links to user list dict This is what keystone returns, so it's what our mock should return too. Change-Id: I7d4b428a48d3f4779994f4ac7d41744cf74d549d commit 5a1a3d813b89e19f3f85da1a6ac363ae759c4f53 Author: Monty Taylor Date: Tue Jun 6 10:40:22 2017 -0500 Avoid keystoneclient making yet another discovery call Even with an endpoint_override set, keystoneclient will make one discovery call if the keystoneclient.client.Client constructor is used. Because we're not going to make that extra discovery call after we've already made a discovery call when we do ksa calls, directly instantiate the v2 or v3 objects ourselves. This lets us avoid the extra discovery call so that we can remove it from our test fixtures. The discovery call sequence now should be identical for ksa vs. ksc. There is still an inefficiency here due to our discovery not using ksa discovery. But we can optimize that later. Change-Id: If7f8625745f80334b9a78d742dc4a9250a4eb72c commit 96c24b1108f5eca3d679a6b17a29c475a433c2e5 Author: Monty Taylor Date: Tue Jun 6 09:39:35 2017 -0500 Use shade discovery for keystone Use the new discovery method for identity client. HOWEVER - also use it for ksc by setting an endpoint_override. This prevents us from having multiple competing discovery stacks while we transition from ksc to ksa. discovery is still less optimized. Our discovery isn't making use of the ksa discovery cache so it double discovers identity. We'll fix that next. Change-Id: Ieae669c1ea1155434a642dbc89f78f85a3563567 commit 076a407eac78d1d04efa65f5ad660da6f5a3c5de Author: OpenStack Proposal Bot Date: Tue Jun 6 05:59:39 2017 +0000 Updated from global requirements Change-Id: I5b98af79293aae245f2e37eb585ed87b9153c940 commit 641073bba93e90e4373e08e7113d7de853355ab9 Author: Monty Taylor Date: Sun Jun 4 23:30:01 2017 -0500 Migrate dns to new discovery method Change-Id: I66cdb189a87e94df35fbdb720c48e59f24ca51cb commit a45848d5b97270685904653635b2bb4b248d7139 Author: Monty Taylor Date: Sun Jun 4 10:34:46 2017 -0500 Generalize version discovery for re-use This will eventually all push down into keystoneauth, but for now we need it in a few places. Let's just make one method rather than cutting and pasting it for each service. Change-Id: I190f3abfc403af337d671e8c420915c009964cf3 commit 751b0a0411941490e5d1be678e0a3ca4ad1b8db5 Author: Jakub Jursa Date: Mon Jun 5 15:16:50 2017 +0200 Pass hints to Cinder scheduler in create_volume This commit adds support for passing 'scheduler_hints' as kwarg in create_volume. Change-Id: I85915fab03f2bff77a21802791f2f6a7579815f2 commit 10cb4f2d592908b74ca92cd1e61d21ab6b6dbab9 Author: Sławek Kapłoński Date: Fri Jun 2 16:48:03 2017 +0000 Remove designate client from shade's dependencies All calls to Designate API are now done with REST calls made via keystoneauth1 Shade don't require python-designateclient package since now. Change-Id: I55393dc04ec9eeaba885fee849e6466f199be479 commit c97bac299751775294e8abc5f01d1bfb7bb681cf Author: Monty Taylor Date: Thu Jun 1 16:46:27 2017 -0500 Do less work when deleting a server and floating ips When we delete a server with floating ips, we tell get_server to not fetch a bare server, which does the work to fill in the network info from neutron. Then we look in the server for the floating ip address and look up the port it goes with. This is not necessary. We can tell get_server to get us a bare server, then look up floating ips by device_id. Then just delete them. Change-Id: I5ec04dc2a356aa20cf561866e8f43f9e28b2db21 commit f0fa7e71c00a8dbda25db704a16c4b46ae1c3f75 Author: Sławek Kapłoński Date: Thu Jun 1 20:11:08 2017 +0000 Remove designateclient from commands related to recordsets All commands related to recordsets, like create/update/list/get/delete recordset are now made using keystoneauth1 client and direct REST calls to cloud. Change-Id: I40339ec188b75668211d87d4410e5f9b8961424f commit 1a5f7343fd462ad703b42046823c9ac33ee2df9f Author: Rosario Di Somma Date: Mon May 22 22:22:33 2017 +0000 Add pagination for the list_volumes call This commit adds support for pagination when it is enforced by the cinder server because the length of the volumes list requested is longer then CONF.osapi_max_limit. Change-Id: Ibd234e521884d4de746cb002988a5a6540c9f043 Signed-off-by: Rosario Di Somma commit 755890ba413a67806ceb40a9d413c95cdd233f95 Author: Sylvain Baubeau Date: Thu Jun 1 16:10:27 2017 +0200 Handle ports with no 'created_at' attribute Change-Id: I1ff4635365acd803878212787fa98c622c69a41b commit 014d3979cfca4b9229faba7ef5bbbfea8b17031f Author: Monty Taylor Date: Wed May 31 07:10:57 2017 -0500 Update test_user_update_password to overlay clouds.yaml Rather than adding a bunch of v2/v3 logic, just use the demo cloud entry in clouds.yaml but with the new user_id/password. To make sure this works, go ahead and assign the member role to the user, so that the project settings in the file will work too. Change-Id: I1adc271d60c0ded25c639962d0974242009c7c9b commit f0c981cfc4873b46710628a7de394e0a826cdd6a Author: Monty Taylor Date: Tue May 30 08:48:19 2017 -0500 Fix legacy clients helpers There is no method called _create_or_return_legacy_client. Also, you have to pass a variable to a format. Change-Id: I559416d29c34b6cfea944f405c8608714ad81508 commit 6a325df8b6423d004d91eae51a270d2ccfb8ec0a Author: Monty Taylor Date: Tue May 30 09:52:03 2017 -0500 Remove unused occ version tie We have a trap for old os-client-config versions so that we can use set_session_constructor. Problem is - we don't actually use set_session_constructor. So it's a bogus trap that's just making life hard. Also disable a part of test_update_user_password. Our keystone v3 devstack doesn't have a v2 endpoint anymore, and this went south. Change-Id: I1299c6d33f301a6b1deed848737bfb561129a031 commit 92a19dfa2f545de5d56059e55a8380cad3246aee Author: Sławek Kapłoński Date: Fri May 26 20:57:41 2017 +0000 Remove designateclient from commands related to zones All commands related to zones, like create/update/list/delete zone are now made using keystoneauth1 client and direct REST calls to cloud. Change-Id: Id3a0fc0aa55e62832fd6fb85cafda8d55023d01f commit 5d987eb31e8c620dd69fe11a3c3ce8458bb45332 Author: Monty Taylor Date: Thu May 25 10:18:58 2017 -0500 Add documentation about shade's use of logging shade logs to some specific named loggers for various things. They are defined and intentional, but are not documented. So let's document them. Change-Id: If52553e5478d4e2f8a56f5d899e93fd2b4fe3c2d commit e167039f581b51995de0f9bdb8562b1b799d246b Author: Monty Taylor Date: Thu May 25 10:21:23 2017 -0500 Add novaclient interactions to http_debug While hopefully novaclient will be gone soon, it's here now. We set up novaclient logging in our unit tests so that we can see what's going on. Do the same in simple_logging at least until we've gotten rid of novaclient. Change-Id: I105af3acbe215fb8d0cdc3dd7e5670eb4379d668 commit f6c74f25f0bd6e8cd1341701f3bc135f46691fe7 Author: Monty Taylor Date: Thu May 25 10:16:19 2017 -0500 Set some logger names explicitly In the next patch we'll add documentation about what shade logs to what logging facilities. To make sure that those named facilities are maintained as part of the interface a consumer can count on, set non-root logger names explicitly. Also, this changes the logger name for the "waiting" messages from shade._utils to shade.iterate_timeout. _utils is an implemenation detail and such subject to change. The logger for it is not. Change-Id: I2ff413062c4cc3b49872fa8fd24e5daade063187 commit 58d9b2a713544ed84a7abd68a019899d4588e47b Author: Monty Taylor Date: Thu May 25 09:45:22 2017 -0500 Add logging of non-standard error message documents Sometimes we get non-standard repsonses that include things like html errors. Log them to a special logger if they are there so that someone can opt in to seeing them. Change-Id: Ife1ce58b0484c610d6b43a9adb39113f387eff77 commit bf8774b80970357048e1d9353383a42ebe811c2c Author: Monty Taylor Date: Thu May 25 09:29:30 2017 -0500 Log specific error message from RetriableConnectionFailure There are more than one error from keystoneauth that can match RetriableConnectionFailure. We retry on all of them, but logging the whole message can be useful for debugging. Change-Id: I2fd3bf62a3a755281d34ff5d3624b835281604fb commit 990cfa3ce24d0a92c7578b52ae1fea02d69f7e87 Author: Matthew Booth Date: Thu May 25 13:26:48 2017 +0100 Don't pop from os.environ It's rude to other users and subsequent callers. Change-Id: I7789f381c99311bfd1c1e0a9869cbacbc96b17d6 commit aad00aa01e737b4b553c17eb22c4c5211f6767f5 Author: OpenStack Proposal Bot Date: Wed May 24 23:11:29 2017 +0000 Updated from global requirements Change-Id: I1a52a58baccd8dd3b6f04bd8baa8d20654ce366d commit 462fe8178bc10bbef0618f608eff94c826d9934d Author: Monty Taylor Date: Wed May 24 12:34:52 2017 -0500 Fix python3 issues in functional tests Change-Id: I86e28616403c36672603a6ad6cb0477722da4594 commit 9f393dcbc89390a08d5f20a44cbdeb96ae9be5e4 Author: Monty Taylor Date: Wed May 24 12:24:41 2017 -0500 Add time reporting to Connection Retry message Change-Id: I38415e88fd3415022d003f710d95131a4dc314d8 commit b194a4d58a4eec557232a5d485b45da4a2382554 Author: Monty Taylor Date: Wed May 24 11:40:58 2017 -0500 Log cloud name on Connection retry issues It's hard in a complex environment like nodepool to know what to debug otherwise. Change-Id: I5885fc136c89a37ac405ce1d859a33d1c1f9cf1a commit a4bcf38f5518579363bb5f33ef9b7c5651f44575 Author: Monty Taylor Date: Wed May 24 09:37:11 2017 -0500 Use catalog endpoint on any errors in image version discovery If we can't do version discovery for whatever reason, just use what's in the catalog. While we do that, try to detect what version it is so that we can at least take the correct actions. Change-Id: I2be381c1a0af9ee576f22b6c03b7a2e577503aed commit ba0e9451e664743dbc5d24307ca5a3829ee3e91b Author: Monty Taylor Date: Tue May 23 16:05:15 2017 -0500 Pick most recent rather than first fixed address If there are multiple fixed ips for a server after nat_destination filtering, we pick one arbitrarily. The thing we really want to do is pick the most recent one - since it's the one with the greatest chance of success. Removed a test that wasn't actually testing anything. Change-Id: I73fe5fe58269931ae9a7e52b79c3211d96e69a92 commit 072001a6289bee6594a97fe30dd5ab53bb1d9e99 Author: Monty Taylor Date: Tue May 23 09:04:25 2017 -0500 Allow a user to submit start and end time as strings get_compute_usage currently requires a user to provide a datetime object. That's actually fairly unfriendly. Also, it turns out if you happen to produce one of those with timezone offset information, Nova will return a 400 error. It's pretty easy to convert a datetime with timezone info to a datetime in UTC without it - so do that first. Now a user can submit a fully compliant ISO 8601 datetime with whatever info they want and we'll make it meet nova's standards. They can also supply a datetime if they prefer. Also - do date parsing before project get - to avoid an API call if the validation that doesn't need an API call fails. Finally, supply a default for 'start' of the first day OpenStack existed. Change-Id: I53989d47f0d24695c19c1023e35acb315bec9eea commit 12b07e12e2f6f43eb7dd9230d25acff2c6ac8343 Author: Monty Taylor Date: Tue May 23 08:13:19 2017 -0500 Fix get_compute_limits error message We're currently using name_or_id in the error message whether it's there or not. Change-Id: Ieaddc57e52f7c26b410ebe0178e2c30f48897769 commit 8d34399714297d5eaa12ae7428bf93392e2b4108 Author: Monty Taylor Date: Tue May 23 07:55:38 2017 -0500 Fix get_compute_usage normalization problem When we normalize an empty usage report, start and end can be empty, so the pop() call fails. Don't fail on that. Also, stop forcing interface=admin in operator_cloud. We stopped adding this elsewhere already, because it turns out it's NOT actually a thing anyone should ever do by default. (It's an old keystone v2 thing - jamielennox says it should be avoided like the plague) Make operator_cloud consistent. (This will still honor interface=admin if it's in the clouds.yaml file) Change-Id: I432dc58d60fb56ce13332443435138354d66e9e1 commit e3d43e7396d95d6cfaa4ca0113108cbef22225b6 Author: Clark Boylan Date: Mon May 22 12:10:24 2017 -0700 Find private ip addr based on fip attachment In the case of multiple private ip addresses we previous returned the first private ip address found. That can cause problems if that IP address isn't valid. Since the IPs are private the only real validity check we can use is if the private IP address has a floating IP attaached. Update shade to return the private IP that is attached to a floating IP when there are multiple private IPs. Change-Id: I86807c5149dfad72948ff6832a6697b594d1f195 commit 329b939241a218e09e03cb41ad4ac8f3bec3c2f4 Author: Monty Taylor Date: Fri May 19 09:44:11 2017 -0500 Add ability to run any tox env in python3 To test this I ran the pep8 tox env with python3 set - and lo and behold there was a python3 mistake in a functional test. Whoops. Change-Id: Ia93a2a85e420d164d67abee479ad498b5e6d3167 commit ee0112182a8e4a0c01546d472bb097f85ea2d8e3 Author: Rosario Di Somma Date: Thu May 18 15:14:49 2017 +0000 Fix issue with list_volumes when pagination is used Change-Id: Iecf478d8c6352744bd58cfa437d34caf0f47021b Signed-off-by: Rosario Di Somma Fixes: bug 2001022 commit b9872da5f0bc95ed0b0aa196517e28ebe0fb3842 Author: Monty Taylor Date: Wed May 17 12:02:31 2017 -0500 Make sure security_groups is always a list In https://github.com/ansible/ansible/issues/24675 we see that sometimes security_groups is coming back None. The data model in shade says it's a list, so make sure it is one. Change-Id: I6db45ba7c3d630812ea58353d3eaddbb98cb8c1f commit c19a797066348f44b8f478c60c28842083cfcc7f Author: OpenStack Proposal Bot Date: Wed May 17 03:45:54 2017 +0000 Updated from global requirements Change-Id: I245f8b4e10a57d133443683ba115274ce2332bfd commit 750e0a98032c27e2db7d3fbce75ddb1d613dad10 Author: Monty Taylor Date: Mon May 15 18:00:50 2017 -0500 Remove direct uses of nova_client in functional tests We use nova_client in a few places for setup/teardown - but we're solid enough at this point to just use ourselves for these functions. We're _pretty_ good at deleting servers consistently. Change-Id: Ifd12488752c036e4453c308a1aa6573c57d52944 commit 8235e0ce6cff00bfa84501865a3cf48511cdf2ec Author: Monty Taylor Date: Tue May 16 18:12:41 2017 -0500 Keep a singleton to support multiple get_config calls We are destructive to os.environ in the OpenStackConfig constructor- so it really should only ever be called once. Make sure get_config does this. Change-Id: I279bdf68408a807ec18fba634df3769c9b8fc4dc Closes-Bug: #1691294 commit 5991a5e72214a8c7bd12e7478f91f4aaa3a05d2f Author: OpenStack Proposal Bot Date: Tue May 16 12:18:08 2017 +0000 Updated from global requirements Change-Id: I034286a50f55350269777e13331cda536f9c8b4f commit 892b502251c08a930d62b146df5aac6f8bfe3f5c Author: Sławek Kapłoński Date: Wed May 10 16:54:59 2017 +0000 Remove designateclient mock from recordset tests Designate client mock is replaced by requests_mocks Change-Id: I839a4d83bb53214980fd87beb79454251335721b commit 4199976762d53583814b371f51672eb4a7a06a50 Author: Monty Taylor Date: Mon May 15 16:09:37 2017 -0500 Convert list_server_security_groups to REST The tests for this are already covered, the call just didn't get converted. Change-Id: I78f91dca0ec41207c433597bcf0fc6284bed73c7 commit f11edd7fdd6196ac4a74c33679efd5bbdba96e10 Author: Monty Taylor Date: Mon May 15 16:00:18 2017 -0500 Remove two unused nova tasks ServerConsoleGet and NovaImageList were both used but still in the file. Change-Id: I91a609b241eed497842a2a28ed41d2b1205913ca commit dbb42fc6ffec6dad484c1813639d5ce0643bd644 Author: Monty Taylor Date: Mon May 15 15:42:19 2017 -0500 Include error message from server if one exists Nova includes bodies in error responses that look like this: { "badRequest": { "message": "Invalid input for field/attribute fixed_address.", "code": 400 } } I recently had to look at HTTP debug logs to figure out a bug. Let's include that data in our exceptions already. Change-Id: I4b4b4702d772739b8f930ff6a3c1ad83987fed17 commit 9ecf600397aedd54236cbbb72bc8a080ea2f7a27 Author: Monty Taylor Date: Mon May 15 11:14:27 2017 -0500 Optimize the case of versioned image endpoint in catalog We have version discovery for glance. However, if someone asks for a version, and it's the version that they get from the catalog, we can skip doing a full discovery run. Do that. Change-Id: I2c0694ffc70bf2801de1fc187ba7b38e6a1b9d09 commit 40f66c70c3703e1ffd499562a99d724cffbe2c53 Author: Monty Taylor Date: Mon May 15 10:46:21 2017 -0500 Fix broken version discovery endpoints In the version discovery spec, it is noted that both schema and netloc on endpoints reported by version discovery documents are known to be able to be broken, but shade was only fixing scheme. Update the code to do the right thing. Also, add a test to ensure that this behavior occurs correctly. While we're in the tests for this, have the discovery call return a 300, which is what it returns. There are no bugs in this area, but 300 is correct so we should test it that way. Story: 2001027 Change-Id: Id04f6f033c9277e791b602f193d1eaf6ac73047f commit e1dfc7228da2729919b54a03825a5d1840718510 Author: Monty Taylor Date: Sun May 14 07:53:12 2017 -0500 Remove cinderclient from install-tips.sh It's removed from requirements - missed it in the install-tips helper script. Change-Id: If798251387bdb81da980ef9e8d9869f2b0738cbe commit a88d41e3026497cc98b0779d82fb05ee8ea4e720 Author: Monty Taylor Date: Thu Apr 27 18:46:04 2017 -0500 Fix tips jobs and convert Nova Floating IP calls The script to install the git versions of the libraries wasn't working because it wasn't installing over top of the versions already installed by pip. So by adding an uninstall first, we ensure that the git version is actually installed. Also, add a pbr freeze to the end so that we can verify, and some +x so that we can see the output of our scripts. And: novaclient 8.0 doesn't have these calls anymore. However, the tests we had on legacy clouds were erroneously installing the wrong version of novaclient so we did not catch it. Doh. This has to do the tests and the calls in the same patch because the fix to the gate job to install the correct verison of the library exposed the fact that we had be broken for these for a few minutes. Depends-On: I208e8c009d0438de19cd3eb08dc45ddebb45d3e9 Change-Id: I4fd882aeb8373b94c7f6b54d97b457042b324361 commit dc77e7d6c266d0278c13cdcaf5d46b2d07faeb96 Author: Monty Taylor Date: Thu May 11 21:11:31 2017 -0400 Convert first ironic_client test to REST Add the various plumbing and convert one test. Also, ironicclient prepends "v1" to all of its calls (joy) so there is an ugly transition related to version discovery coming with this one. For now just prepend it in our mock base class. When we convert calls, we'll have to prepend v1 at the call site until we're done with the transition. Then we can do a followup patch that'll do discovery and remove the v1 from the code. Gross. Change-Id: Icfd70267910d19a7da2ae8e9b9e4f24d2077b87d commit f94880c6d835cda4cd33e5b55f7d81d3608b8f52 Author: Sławek Kapłoński Date: Sun May 14 09:34:09 2017 +0000 Move mocks of designate API discovery calls to base test class As API discovery call has to be mocked in each Designate's test case it's better to move it to base test class and reuse later. This commit moves it to tests.unit.base.RequestsMockTestCase that it can be added to mocks in setUp() method before each test. Change-Id: I3f00c2d51619d634e4e44f3ebf276949544c8575 commit be0a0c99f3ebcb80e7a71226557bd2a96f75af73 Author: Paul Belanger Date: Sat May 13 15:10:17 2017 -0400 Fix exception when using boot_from_volume for create_server It is possible for create_server to accept a dict for image, however _get_boot_from_volume_kwargs did expect that. This created the following exception: Traceback (most recent call last): File "/opt/stack/new/nodepool/nodepool/nodepool.py", line 358, in _run self._launchNode() File "/opt/stack/new/nodepool/nodepool/nodepool.py", line 290, in _launchNode volume_size=self._label.volume_size) File "/opt/stack/new/nodepool/nodepool/provider_manager.py", line 235, in createServer return self._client.create_server(wait=False, **create_args) File "", line 2, in create_server File "/opt/stack/new/nodepool-venv/local/lib/python2.7/site-packages/shade/_utils.py", line 393, in func_wrapper return func(*args, **kwargs) File "/opt/stack/new/nodepool-venv/local/lib/python2.7/site-packages/shade/openstackcloud.py", line 5517, in create_server volumes=volumes, kwargs=kwargs) File "/opt/stack/new/nodepool-venv/local/lib/python2.7/site-packages/shade/openstackcloud.py", line 5333, in _get_boot_from_volume_kwargs cloud=self.name, region=self.region_name)) OpenStackCloudException: Image {'id': u'1cb47019-08a4-4b9c-ae62-737b547648b6'} is not a valid image in devstack:RegionOne Now, check if image is a dictonary, like we did in create_server. Also add an ansible test for os_server so we additional code coverage. Change-Id: If58cd96b0b9ce4569120d60fbceb2c23b2f7641d Signed-off-by: Paul Belanger commit a483534123640eca2bcbf7c06920be3a2a01b090 Author: Monty Taylor Date: Sat May 13 08:45:26 2017 -0500 Revert "Revert "Use interface not endpoint_type for keystoneclient"" Unrevert the endpoint_type/interface patch. But this time around, put in a check for API version 2.0 and only apply the interface arg if it's for v3. This reverts commit 4493871824839782846c3825c754895876f8d08e. Change-Id: Ib347ec686d4d01788ee943c4c4f809aad06d9ccf commit 4493871824839782846c3825c754895876f8d08e Author: Jordan Pittier Date: Wed May 3 13:11:10 2017 +0000 Revert "Use interface not endpoint_type for keystoneclient" This reverts commit 38e5eba621e48d74c05315da2b89e6c801f4c43f. This patch introduced a bug when using Keystone v2. With this patch, the following works: python -c "import os_client_config; print(os_client_config.make_client('identity', auth_url='http://localhost/identity_admin', username='admin', project_name='admin', password='testtest', identity_api_version='3').roles.list())" But changing identity_api_version from 3 to 2.0 raises an exception. Without this patch, both 3 and 2.0 works. Change-Id: I8d2ad71ff51a08af1166d36805b740ea272939ed commit 1c0a95ba8f9fda57e0a094c86393bae546f89f23 Author: Monty Taylor Date: Fri May 12 10:58:46 2017 -0500 Move legacy client constructors to mixin Remove them from the main class to make them slightly less obvious. Change-Id: I72b32d992c71777155c22b51ce4c7868e19d44c1 commit 7a3acde3ed8a68acc15596be2d297426ee357084 Author: Monty Taylor Date: Fri May 12 12:05:50 2017 -0500 Add ironicclient to constructors list Change-Id: I29db3c830759a80d8ea9f0d93a213b4bae4c8b59 commit 103bc13862639e6bfe942843c095230f3d6ddf89 Author: Monty Taylor Date: Fri May 12 11:52:41 2017 -0500 Fix pep8 errors that were lurking Something about how we were doing legacy client constructors was causing pep8 to fail open. The next patch fixes that, but these are the pep8 errors that snuck in while it wasn't working. Change-Id: I080fd1730fcbc4cd30860963a89dad6ccf3d4f2f commit 3f76b25798984cb3a4dabaf91ca5338782254465 Author: Rosario Di Somma Date: Wed May 10 14:48:05 2017 +0000 Remove cinder client Change-Id: I585da9a60757da8020b8e1086ae8d8375a9ce364 Signed-off-by: Rosario Di Somma commit 3ed97257ec51c3bf42c39d5db142426f8c51dab8 Author: Monty Taylor Date: Fri May 12 09:45:36 2017 -0500 Make deprecated client helper method We had a bunch of cargo-culted code inside of the deprecated client factory methods. Make a helper method so that it's easy to mark one as deprecated correctly as we do. Change-Id: Iedc859876c4adc4ccdadd580c5b686e0bda798f0 commit d3b653f23cef0cb0aef45e2a322a54e0626a7336 Author: Monty Taylor Date: Thu May 11 21:09:47 2017 -0400 Add 'public' as a default interface for get_mock_url The calls are almost always 'public'. Make it the default. Change-Id: I0923b79d88e839aa4331afb987d27a3200b3b01f commit ef35f02ea61a96ef025923cc3653bb67b4ef03ad Author: Monty Taylor Date: Thu May 11 21:08:38 2017 -0400 Add super basic machine normalization In prep for ironic_client conversion to REST, make sure we're removing the novaclient artifacts. Change-Id: I8ef1c5e87492310821c1a0e8ab7e2144c6a10dbc commit d1d9ed7cd428e55a8e6b7f124a90659da739b69a Author: Sławek Kapłoński Date: Tue May 9 21:46:20 2017 +0000 Remove designateclient mock from zones tests This patch adds also dns service to service catalog mock used in tests. Change-Id: Ic7ce778f58e9fd28951eb02067f6bbf86a14b0cd commit 61141ae9cff44f20e6ad7ce8dfd71b47ef088b2c Author: Rosario Di Somma Date: Mon May 8 19:23:12 2017 +0000 Remove direct calls to cinderclient Change-Id: Iad89e4a0c13e28f545b2d164417b60ee39cb5b12 Signed-off-by: Rosario Di Somma commit fcaf06c3f2d1738590c2ff81a5de45c510a341df Author: Monty Taylor Date: Sun May 7 07:30:32 2017 -0500 Add "Multi Cloud with Shade" presentation Check it out - when we write presentations in presentty, we can add them to our docs! First given at the 2017 Boston OpenStack Summit. Change-Id: Ia46a6f32b6b374974fba7b620b202f8eadc774a1 commit 7801de73ed57c015758ce7b2d69f53199f3410ae Author: Rosario Di Somma Date: Mon May 8 14:40:14 2017 +0000 Use REST API for volume quotas calls Change-Id: I73c5448edbd5ba7bc36f7e709c128136916073fb Signed-off-by: Rosario Di Somma commit b6926bb8e5e07b425809beb5773aa39b64feda98 Author: Monty Taylor Date: Mon May 8 09:48:11 2017 -0400 Add pprint and pformat helper methods Because of munch - using pprint directly is weird. Make a helper method that does what the user expects. Change-Id: I617b75034a59118c170895ad20b86fb8a1eab386 commit 347fe82c929bb9b8aba5aee504bbe3eaf1e8bf04 Author: Monty Taylor Date: Mon May 8 07:20:53 2017 -0400 Add helper method to fetch service catalog Grabbing the catalog is weird. OCC should help. Change-Id: I6e7176568311c1f0e644a8e8876f56c3e153d6e8 commit 2f8285db7211b7b59f3ddb996f40a175990edf89 Author: Christian Zunker Date: Fri May 5 10:46:57 2017 +0200 extend security_group and _rule with project id This allows admins to manage security groups and rules across projects. Story: #4193 Change-Id: Iaea4d14baec377f1885bd2e00fafcc889ca1ba94 commit 81239f6742a22415492fe65873f9606b6734173d Author: Sławek Kapłoński Date: Sun May 7 22:15:15 2017 +0000 Remove neutronclient from shade's dependencies All calls to Neutron API are now done with REST calls made via keystoneauth1. Shade don't require python-neutronclient package for now. Change-Id: I0aa6f32b10986e99d6f86cad9640d9d95b5d2cef commit 1a8cb0aac20479309cca1da71d027aa23e047d64 Author: Rosario Di Somma Date: Sun May 7 17:30:50 2017 +0000 Remove cinderclient mocks from quotas tests Change-Id: Ibce1d58309cf63a23ad8fb0e9ce89fb3b3de21fe Signed-off-by: Rosario Di Somma commit e00ff9c7194e7b62c34c2a13ac5d2e73ca67cf9c Author: Sławek Kapłoński Date: Sun May 7 19:50:03 2017 +0000 Fix Neutron floating IP test Test test_create_floating_ip_no_port was did wrong during transition from neutronclient mocks to request_mocks. This test expects raising error and error was raised but from wrong reason. Now test is using proper data and exception is raised with good reason. Change-Id: Ic965c66c2507fe4adbd42f159c11666199208b39 commit c43f1d81e3c02e6781684097407cbc5c18806c66 Author: Rosario Di Somma Date: Sat May 6 20:48:52 2017 +0000 Use REST API for volume snapshot calls Change-Id: If6fda6bcc0455d086779d134e00417d72f1f4e92 Signed-off-by: Rosario Di Somma commit ad516fba6de1dd0a619083cd3ef1392f7070aaff Author: Sławek Kapłoński Date: Sun May 7 15:26:18 2017 +0000 Remove usage of neutron_client from functional tests Neutron client was used in functional tests to add/remove router interface and to remove external_gw from router. Now shade can do such operations so shadeis used for that and neutron client is no longer needed there. Change-Id: Idf3e0329eef8c3ad6aebe7dd132f146d54f767cb commit 55ef1369b63d5590e6b88b50d143cd259ae47aac Author: Sławek Kapłoński Date: Sun May 7 11:14:04 2017 +0000 Enable neutron service in server create and rebuild tests Instead of mocking Neutron client calls to Neutron are now mocked by request_mocks in tests for create and rebuild servers. Change-Id: Ic90ad8f8468254a935e9e134348f599fa3079bba commit 072be85da12914624f287f80dc9f57696b01e84c Author: Sławek Kapłoński Date: Sun May 7 11:06:42 2017 +0000 Replace neutronclient with REST API calls in FIP commands All commands related to Neutron's floating IPs like list/create/attach/detach/delete are now made via keystoneauth Change-Id: Ifd739bbb2fe170cea2114816830d002c55ce2e45 commit 81d39a9ea0265c72bb46238e8a9989538be735aa Author: OpenStack Proposal Bot Date: Sat May 6 19:23:35 2017 +0000 Updated from global requirements Change-Id: I3e7455e3f1bed53cbb3e9d64351d1536c82dc650 commit b39045069fc2e562f4b7b1e36316628b0fc59e16 Author: Rosario Di Somma Date: Sat May 6 16:04:05 2017 +0000 Add assert_calls check testing volume calls with timeout enabled Change-Id: I4203f0de012b3d84ece3ba7749568f39c92dcfeb Signed-off-by: Rosario Di Somma commit f7f54d0ddbc8695f7efd9b8b27a95b04a686efc5 Author: Sławek Kapłoński Date: Sat May 6 15:16:37 2017 +0000 Remove has_service mock from Neutron FIP tests As we switched FIP related tests to use request_mocks and Neutron is in service catalog in tests there is no need to mock has_service() method anymore. Additionally one useless mock of get_server() method was also removed. Change-Id: Idb6a8afbba7720548faefad1ab60b1bc582d1c10 commit 4b75c85e184fed7f5bbad292c5d1f11bd076a926 Author: Rosario Di Somma Date: Fri May 5 23:40:01 2017 +0000 Remove cinderclient mocks from snapshot tests Change-Id: Ib753f7db64cad35bc47fb6abf20bccf41202cd2e Signed-off-by: Rosario Di Somma commit 24494880f8241fee38cf75afbe4b594cd4f6dd60 Author: Sławek Kapłoński Date: Fri May 5 23:23:08 2017 +0000 Remove neutronclient mocks from floating ips tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I5fcdd0c07d2ec3627e73598615940b555883612a commit 689d3bb9ddb69897238e48eb1dfb13763d2a3ec9 Author: Rosario Di Somma Date: Tue May 2 13:18:35 2017 +0000 Use REST API for volume attach and volume backup calls * Also remove unneeded call to shade_exception in the detach_volume method. Change-Id: Ic8f63453ab11e39a28fbfe5027f95ba41c59fadc Signed-off-by: Rosario Di Somma commit f52448d8cb4af6ee46434f34c87368eca2f3544e Author: Sławek Kapłoński Date: Tue May 2 20:45:29 2017 +0000 Replace neutronclient with REST API calls in ports commands All ports related commands to Neutron like list/create/update/delete are now made via keystoneauth Change-Id: I145b9347cf0be5e459bb025f9d92958176e6e7a2 commit f7b1eb5c60f83374fa8f5e3d5bad188a7565beeb Author: Sławek Kapłoński Date: Tue May 2 20:33:34 2017 +0000 Don't get ports info from unavailable neutron service In shade.meta._get_supplemental_addresses() Neutron API was called to get ports list even if cloud.has_service('neutron') returned False. Now it's done only if Neutron service is available. Change-Id: I30ff7a8d049ef0bac025ac21185deb50760144cf Closes-Bug: https://storyboard.openstack.org/?#!/story/2001011 commit a2aad709fb76a46716311193868d5358c2555e3e Author: Mike Perez Date: Tue May 2 10:07:34 2017 -0700 Removing unsed fake methods and classes These are being mocked otherways now. Change-Id: Ica242ff6a48508f616ca5dde90a77d588f8d2bdb commit 77bac2b9d03c1a7a3b53cf4ae388354ffc553568 Author: Sławek Kapłoński Date: Mon May 1 11:27:08 2017 +0000 Replace neutronclient with REST API calls in quotas commands All quotas related commands to Neutron like list/create/update/delete are now made via keystoneauth Change-Id: I5f0cb3e174c2f5453d2fe760bb39b2140fe1f201 commit cbc233d0e70fb603004c16cace3698f9ef3bbe4b Author: Sławek Kapłoński Date: Mon May 1 14:00:54 2017 +0000 Replace neutronclient with REST API calls in security groups commands All security groups and security group rules related commands to Neutron like list/create/update/delete are now made via keystoneauth Change-Id: I875e8780ac28cbeb46c80f67629f98a86fd57160 commit bcc7ea694ab78e0903c3a2075102afe3bb47eda2 Author: Rosario Di Somma Date: Mon May 1 01:42:49 2017 +0000 Use REST API for volume delete and detach calls Change-Id: I0267899b4fb1dbb277ef969663ff82eadf465879 Signed-off-by: Rosario Di Somma commit be9275178185feceaf95dd859afacec3979b8320 Author: Rosario Di Somma Date: Sun Apr 30 22:11:42 2017 +0000 Use REST API for volume type_access and volume create Change-Id: Ibf3e16d7e2faab3ed9afe7e2b69216b59aceecdf Signed-off-by: Rosario Di Somma commit f430b9483eabcbf9796e0ec6ca043c94159554be Author: Rosario Di Somma Date: Wed Apr 26 17:20:26 2017 -0700 Refactor the test_create_volume_invalidates test Simplify the logic a little bit to make the switch to the REST API call easier. Change-Id: I8eee73f7d59d4def45b788be08c5170c1f6820c2 Signed-off-by: Rosario Di Somma commit 7abe4e9422d907f281c86aa09a48d8fabc3c48d3 Author: Sławek Kapłoński Date: Thu Apr 27 11:20:25 2017 +0000 Replace neutronclient with REST API calls in router commands All router related commands to Neutron like list/create/update/delete/add_interface/remove_interface are now made via keystoneauth Change-Id: I81592285268030e4868ef6b522bc7937a31c756e commit 478d4ba101b1c1f581ab48cb1bdf82917a928e52 Author: Monty Taylor Date: Sun Apr 30 10:35:57 2017 -0500 Move REST error_messages to error_message argument The with shade_exceptions is not doing what is expected here - since it passes OpenStackCloudException objects on unmodified. Instead, use the new error_message parameter to continue to give friendly error messages. Also - wow, we were mocking _compute_client for the nova extensions tests. I believe that was become those pre-dated our use of requests_mock. Anyway, that's super lame (and also broke because of this patch), so it's now fixed. Change-Id: Ia764cc76d724a8a732fa2b1209a138634a25a9e1 commit 944556e992eb21f060adb04cdf7093bc8ac4fbb9 Author: Monty Taylor Date: Sun Apr 30 10:23:46 2017 -0500 Remove two lines that are leftover and broken Not really sure how these crept in - they never would have made sense. Also not sure how this codepath _worked_ in the live test I used (with the results in IRC) - but they definitely break as they should when triggered in unit tests. Change-Id: Iddc69cbd325c7a3a25cde48a2b2bddb01826c0ff commit 17ab75b0a3350bcc87673d11cce12551fcec2a77 Author: Morgan Fainberg Date: Tue Mar 21 16:58:29 2017 -0700 Convert test_role_assignments to requests mock Stop mocking keystoneclient objects directly. Change-Id: Ibb441ba7a3de50201e96310b9aca5bea628fae01 commit 05f16004187a8e1fbf42d1b164e37b5d98deef7f Author: Sławek Kapłoński Date: Sat Apr 29 20:45:41 2017 +0000 Remove neutronclient mocks from sec groups tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I2a9516e7d7da7f604efb7a4c747674dc761de192 commit 20793660ec0b0429c5aacaa1c5fd70c8ea8f576c Author: Sławek Kapłoński Date: Fri Apr 28 20:59:01 2017 +0000 Remove neutronclient mocks from quotas tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: Ic6fc4f4f29bb28cd865e39191c2ed79977500cd5 commit b9073b5698a708e82dc0cddd218cb922871fdcd5 Author: Sławek Kapłoński Date: Fri Apr 28 20:40:26 2017 +0000 Remove neutronclient mocks from ports tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: If6cbe3c926ead8e0fbabcf602cf0ea8db9fec922 commit e81bec084a7154a8bac206eded94587dafb950b0 Author: Monty Taylor Date: Fri Apr 28 08:12:45 2017 -0500 Add optional error_message to adapter.request When we make REST cals, sometimes we want to provide a more helpful error string. Add an optional argument to the calls to allow this. Change-Id: I797e34cda9f27c18d66a42fd5860fe572fa55ada commit 17debbb09907b83d5781ad683f4b72c9eb1ce221 Author: Monty Taylor Date: Fri Apr 28 12:46:44 2017 -0500 Fix interactions with keystoneauth from newton keystoneauth in newton did not have app_name or app_version as Session parameters. Although it isn't a super common combination, user agent strings aren't a reason to break something. Add a simple workaround. Change-Id: Ib5774389fefdbc190a4b78dd6784c8006afbb270 commit 8a4f99720f9b84f49dee9793c7712b4646485420 Author: Monty Taylor Date: Thu Apr 27 19:42:01 2017 -0500 Add in a bunch of TODOs about interface=admin keystone v2 needs to use the admin interface for a set of calls. We can't change that on a per-call basis until we're using REST - but once we are, by golly, make it happen. Change-Id: I8e77c1b0babb44bb44411f87b6567118a99d1aeb commit a5c49cb0ef04b9e076546527cd03d775ab5b81ff Author: Monty Taylor Date: Thu Apr 27 19:01:30 2017 -0500 Set interface=admin for keystonev2 keystone tests Keystone v2 needs to perform admin tasks over the admin interface. Be explicit about doing that. Change-Id: If3352fccd244a5515af8d4f95c9992df74cfb39d commit 60569b2fbc24c8a07c07d47b0608744e654d807d Author: Rosario Di Somma Date: Wed Apr 26 07:40:25 2017 -0700 Add a _normalize_volume_backups method Change-Id: I597a8a8b113ebded06efb727169998dd0ba98c2c Signed-off-by: Rosario Di Somma commit ca2f10b2e65cddf634d5b9d6f7b252e43e4bc93b Author: Rosario Di Somma Date: Tue Apr 25 17:27:55 2017 -0700 Use requests-mock for the volume backup tests Change-Id: I88d7351a2fc147224542898d08e2a769a62577a0 Signed-off-by: Rosario Di Somma commit a71bea882d9157d19e829dd2cc61fe6ec48575a3 Author: Sławek Kapłoński Date: Tue Apr 25 21:39:41 2017 +0000 Remove neutronclient mocks from router tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I54769c34fef4f64150461fef47881bd400313335 commit 8b6ae89268f90e90c6b564e5fcd0615476448c88 Author: Sławek Kapłoński Date: Tue Apr 25 12:07:00 2017 +0000 Replace neutronclient with REST API calls in subnet commands All subnet related commands to Neutron (list/create/update/delete) are now made via keystoneauth Change-Id: I0e0f16f5fb9be7d288b5aa503f4fa6ad51a17aea commit b964757de8dbf9bf0ea7d79923fd5f040816ece4 Author: Rosario Di Somma Date: Mon Apr 24 11:22:02 2017 -0700 Define a base function to remove unneeded attributes Many of the _normalize_* methods are removing the same attributes, let's have just define a base function that does that. Change-Id: I5fb9f8fdb14db0889b2f7a63415218b8774cc7bc Signed-off-by: Rosario Di Somma commit 66e3168f954082173d0bce78df9f2c6bcf1ec29e Author: Sławek Kapłoński Date: Mon Apr 24 21:37:53 2017 +0000 Remove neutronclient mocks from subnet tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: Id6cf281d9a9e8f891812ad081c32272a3e7f3438 commit 80ebf88bc28be12ea4d09135fc996787b8baec2b Author: Sławek Kapłoński Date: Sat Apr 22 19:00:52 2017 +0000 Replace neutronclient with REST API calls in network commands All network related commands to Neutron (list/create/delete) are now made via keystoneauth Change-Id: Ifa179c062c164d7e48e8a09c52e554dce5ddd1cb commit 1c0c81fe09ba69413e6b6e55d8823741dc58be47 Author: Sławek Kapłoński Date: Sun Apr 23 20:19:31 2017 +0000 Move router related tests to separate module All router tests were in common test_shade.py file. Now all those tests are in separate test module, like it is done for network related tests. Change-Id: I9eee8c676280ea08b8e2c5fb70c1b63f746f4819 commit c21447733a40db1fa4a21440118295cba4176e29 Author: OpenStack Proposal Bot Date: Sun Apr 23 20:41:20 2017 +0000 Updated from global requirements Change-Id: I1318331dd1b8bae151416b35016e11e7223c34e8 commit 65c350f7847ded8cc98b6a5993d07d53ce11f53f Author: Sławek Kapłoński Date: Sun Apr 23 20:09:17 2017 +0000 Move subnet related tests to separate module All subnet tests were in common test_shade.py file. Now all those tests will be in separate test module, like it is already done for network related tests. Change-Id: Id026ba11d4ea26dc94fb3670ec93ab2f46813236 commit cee8b6c56440819d5f14ce947cfc511d4f83021d Author: Sławek Kapłoński Date: Sun Apr 23 19:58:34 2017 +0000 Fix list_servers tests to not need a ton of neutron It was fixed for rebuild/create servers in Ia877232b8dc167a8414f1601ea82708ff5aa2be9 but same issue was also in test_list_servers_all_projects and this commit fixes it for this test. Change-Id: Id901c307f1e11e2da48e41b29c363870d4c61bdf commit 950c4500e2f2bcff370146d88f016e6ef84e56ad Author: Sławek Kapłoński Date: Sat Apr 22 20:06:57 2017 +0000 Remove neutronclient mocks from network create tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: Ied57f41694d1c4f934439c52799f4c87794db0a5 commit ff2c06c30538edb9cb47b83f0a194f7893a7f458 Author: Jordan Pittier Date: Sun Apr 23 17:42:47 2017 +0200 Make _fix_argv() somewhat compatible with Argparse action='append' Python Argparse supports the 'append' action [1] which is super handy to allow a user to repeat several times the same argument, each time with different values. This doesn't work with occ that tries to "fix argv" but raises this error: os_client_config.exceptions.OpenStackConfigException: The following options were given: '--foo,--foo' which contain duplicates except that one has _ and one has -. There is no sane way for us to know what you're doing. Remove the duplicate option and try again This patch tweak the _fix_argv() function so that it doesn't explode if the duplicate option has no '_' not '-' in its name. Change-Id: I4f06b6aff8d3ab1df45637399bc3a9b4b61764a9 Related-bug: #1685630 commit d1d670666ba81faed8cc7898ab0dc77ef80ac05e Author: Sławek Kapłoński Date: Sun Apr 23 08:15:21 2017 +0000 Remove neutronclient mocks from network exceptions tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I488de8613a2e2580f49533b319603d159f7dc832 commit 0a39c015bccebd86af331bb39709e670631b2a9e Author: Sławek Kapłoński Date: Sat Apr 22 20:43:00 2017 +0000 Remove neutronclient mocks from network delete tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I71df04e886d0c08ca29fe141f41961d833138b74 commit e61a5c0418db13da8d9d13f460b9a7acccdd8b97 Author: Sławek Kapłoński Date: Fri Apr 21 20:28:50 2017 +0000 Remove neutronclient mocks from network list tests Neutronclient mock is replaced by mocking REST calls using base.RequestsMockTestCase class Change-Id: I8fd72845afa62fa5fdf351c666d23aae31757bba commit 258a6a33ba375fbf638426fd178aae498d8e86d6 Author: Rosario Di Somma Date: Fri Apr 21 16:16:40 2017 -0700 Use requests-mock for the list/add/remove volume types tests Change-Id: I03aac75375b0f34678f8dc0b953fb2a0cd797150 Signed-off-by: Rosario Di Somma commit 09af82b11770a4586dca8714f907bffd65dab3c2 Author: Monty Taylor Date: Fri Apr 21 17:44:01 2017 -0500 Fix create/rebuild tests to not need a ton of neutron The tests are testing nova interactions, but because of _expand_server they call neutron a bunch. This is hidden with neutronclient for some reason - I'd look in to that more but we're deleting neutronclient anyway. To avoid us having to add a bunch of network mocks that are noise to the tests, fake out has_service to return false for neutron to skip the calls. We can then add them in on a case-by-case basis as needed. Change-Id: Ia877232b8dc167a8414f1601ea82708ff5aa2be9 commit 7a2b5792522a14c0fc39490e407bbddddc8d7189 Author: Monty Taylor Date: Fri Apr 21 17:20:26 2017 -0500 Don't do all the network stuff in the rebuild poll When we're polling for completeness during rebuild server, we do not need to make all of the network calls to fill in network info. If we wait for the server though, we do return the server to the user, so fill in the info once at the end. Change-Id: I78aaf995cb83a88fef9414c17b6bd7fca21fe3c3 commit 5dae1875ec70ef32791be41acd0a4a441b7afbd4 Author: Sławek Kapłoński Date: Fri Apr 21 21:03:58 2017 +0000 Move unit tests for list networks to test_network.py file This file is place where all tests related to networks lives so tests for list_networks should be also there. Change-Id: I3aa7254f66a100d269deefef725dff036488efd2 commit 4f807b8c60f32f61003d5008ed715e802f0df039 Author: Monty Taylor Date: Fri Apr 21 09:57:09 2017 -0500 Include two transitive dependencies to work around conflicts For people installing released shade from pip and then trying to use it somehow through entrypoints, 1.20.0 is currently broken because of some transitive dependencies, ordering issues and conflicting exclusion ranges. While this is by no means a comprehensive or sustainable solution to the problem, it does unbreak the end users currently broken and is not terribly onerous. Both of these additions are tracked in g-r and both can be removed when the dependencies that pull in conflicting ranges of things are removed. Change-Id: I6a4a1ab5ab109f0650873201868e0f1c4d09c564 commit 0bfdaf4e0bda20cb9aa8d2a22688eb4b55da0d6e Author: Rosario Di Somma Date: Wed Apr 19 07:05:07 2017 -0700 Use requests-mock for all the attach/detach/delete tests Change-Id: Ibc70e1b9565d1494e196e818274c5fcee6e8bc05 Signed-off-by: Rosario Di Somma commit 5c0f3f5a5de0a128a4a02342c83415fb73895705 Author: Monty Taylor Date: Thu Apr 20 10:55:57 2017 -0500 Remove stray line Thanks Jens! Change-Id: I88801842705dcb1374640b3178423f6f987799e4 commit d5396cf35cd5d4b792d24590375401aa1177ad0e Author: Monty Taylor Date: Wed Apr 19 10:40:22 2017 -0500 Strip trailing slashes in test helper method A recent patch by Rosario pointed out a flaw in get_mock_url. Luckily, it's an easy fix. Change-Id: Iff12fb36832a5757321bbcc36728b959899b45cd commit 49fe112b85a80935065809f0c6b80b4c867caae5 Author: Monty Taylor Date: Wed Apr 19 07:41:21 2017 -0500 Clarify some variable names in glance discovery I'm bad at naming things. This was unreadable. Update the variable names so it makes sense and add a comment. Change-Id: Iacbaeed91d71dca35c6fdd7d07999bd5956430fa commit 02e6371b8115fb1e8c2a0d9288e49a3f9712b302 Author: Samuel de Medeiros Queiroz Date: Tue Apr 18 17:20:49 2017 -0300 _discover_latest_version is private and not used Change-Id: I978fd77457791e2005edd1050886ce5840daf8d4 commit afed15f37130b841d6e523a468cd9d6cfcdfc791 Author: Monty Taylor Date: Tue Apr 18 13:57:58 2017 -0500 Remove extra unneeded API calls The create and update calls to nova security groups return the security group. There is no need to issue a GET. Change-Id: I068ae5b46954d0c3b0c8be67b80f3eed1be1f55b commit 4c67e76376569cb6f33653c4554b2f9ec514d33d Author: Monty Taylor Date: Tue Apr 18 11:53:55 2017 -0500 Change versioned_endpoint to endpoint_uri In this context, the word versioned_endpoint is confusing. Change-Id: I89b6faadbb3666e867e61d321e1cc096589589cf commit b459c8de5cba1692db0c21e8e45d04a11d182e7e Author: Monty Taylor Date: Tue Apr 18 11:30:59 2017 -0500 Futureproof keystone unit tests against new occ We have a version of OCC coming out that fixes how keystoneclient is constructed. The fix is good - however, it breaks a couple of places where we're mocking to the old behavior. This will all go away once we're done with keystoneclient-ectomy, so for now just put in a version detection switch. Change-Id: I9d4908ef12d40868dc207b130e3244577b9870e9 commit 3b8ef1b88abe01b9b7510d8a0cd4179e3f0e59d5 Author: Monty Taylor Date: Tue Apr 18 11:13:02 2017 -0500 Actually fix the app_name protection The previous "fix" just disabled the app_name protection for python3. Go with Jens' suggestion (the easy route) of trying, and if that doesn't work, retrying. Change-Id: Ie4d1091b0f1fc6e1c9d9a2c935a458ea5ce55af3 commit 26c834c10efbcb338d26ca02fabf79f704e3b6de Author: Monty Taylor Date: Tue Apr 18 09:49:29 2017 -0500 Replace nova security groups with REST One more set of things down. Change-Id: I02f81382693e30513a3fe85c49450f84f8c3d64d commit 8d94ef15a485ef83cda4f42ecea78758c1b228f0 Author: Monty Taylor Date: Tue Apr 18 05:01:48 2017 -0500 Transition nova security group tests to REST novaclient v8 doesn't support these calls anymore. Transition them. A few fixes in the non-test areas related to normalization. Also, we allow users to pass in a dict to bypass server lookup, but then we assume an object when we use it. mocking the clients hides terible things. Yay requests_mock. Change-Id: I39952800414058d7f8a77dfca7610bc8c1fcfd18 commit dfec0ca2afe4035c62d3f3e99b5ab973e9dbb698 Author: Monty Taylor Date: Tue Apr 18 04:32:29 2017 -0500 Remove dead ImageSnapshotCreate task We removed the use of this already. Remove the task. Change-Id: Iba30a78f591257ba7a10f90b823f95cc91bb98b6 commit 0cbed4fbafb7d9adff2f43a9dba342084aec80d6 Author: Monty Taylor Date: Wed Apr 12 09:59:25 2017 -0500 Pass in app_name information to keystoneauth keystoneauth (and os-client-config) support passing through app_name and app_version. These affect the user-agent string. Allow our users to set app_name and app_version. So as not to cause an os-client-config minimum bump, check the arg list of the occ constructor and only pass in app_name/app_version if it accepts them. (This is informative and neat, but not, you know, essential) Change-Id: I515f93168adf35adc2521339255369b1ccfdfe0a commit 5adcef04eb6f42d80c93a8875a2090cfd424aad5 Author: Rosario Di Somma Date: Tue Apr 18 07:22:01 2017 -0700 Use REST for cinder list volumes Change-Id: Ifacc5fac67f08b62886ac64652996263d6642cfd Signed-off-by: Rosario Di Somma commit 64b28d42eda595a6fb4ee8b46d93cd61e612aae1 Author: Monty Taylor Date: Sun Apr 2 11:22:34 2017 -0500 Add ability to pass in user_agent keystoneauth supports adding a user_agent info to the Session and Adapter via app_name. Allow users to add app_name/app_name and versions as desired. Also, add os-client-config into additional_user_agent. As an example, once this is landed and plumbed through shade, nodepool will set app_name='nodepool' and we'll have: User-Agent: nodepool/0.4.0 os-client-config/1.26.1 shade/1.19.1 keystoneauth1/2.18.0 python-requests/2.13.0 CPython/2.7.12 Change-Id: I1eb4dbd2587dcbe297b5c060c3c34b68ef51ef5e commit dc6ed6965537ab3f3bfb4666f5b82676cc7eefb8 Author: Rosario Di Somma Date: Thu Apr 13 12:04:05 2017 -0700 Upgrade list volumes tests to use requests-mock Replace the python-cinderclient with a direct REST call for the `list_volumes` method. Change-Id: I2859d73a70a78236c254aa5cf8a18c3e3d93df1e Signed-off-by: Rosario Di Somma commit 15d64f2af5d9f45ba91bc7f4f5f48402ab8c339b Author: OpenStack Proposal Bot Date: Mon Apr 17 17:11:00 2017 +0000 Updated from global requirements Change-Id: I84c807adf93913bc411954c59040ab780e2eb04e commit 8082cdff7129c999ab0bee3961bb6cf5369e24cf Author: Monty Taylor Date: Thu Apr 13 08:59:55 2017 -0500 Pass shade version info to session user_agent After chatting with jamielennox, the better way to deal with user agent setting in shade is to push it onto the additional user agent stack. Older keystoneauth doesn't have this attribute, so protect it with a hasattr. Change-Id: I35985c834a899a6ef3279dae25eb453d953ff70f commit 9cd5bf900437101476e447d4e15eddf144199a23 Author: Monty Taylor Date: Thu Apr 13 09:06:39 2017 -0500 Use keystone_session in _get_raw_client We're bypassing our local session object when we construct the adapter and instead getting a raw one from occ. This becomes aparent when we try to do things to our local one and they don't show up in the one used by the adapter. Change-Id: I91673527ebe1e1446dfc6efb8c495694a4a65c6b commit d5982e8ffd75f51af1eeeb9568bf34bd9a2e482c Author: Monty Taylor Date: Wed Apr 12 09:18:11 2017 -0500 Don't fail on security_groups=None We currently put whatever is in security_groups into a list to be friendly, but this breaks if security_groups is None. It should stay None if it's None. Change-Id: I571c05bf8353f2ec5ad34ed31040032f2daefd25 Story: 2000828 commit d12032d14752a7574e414ad0e089d39f34cba2ef Author: Monty Taylor Date: Tue Apr 11 15:13:57 2017 -0500 Stop defaulting container_format to ovf for vhd It turns out a basic vhd file is in bare format, not ovf - and bare is a perfectly sensible thing for vhd files to be. Actually, even past that, it turns out that container_format is essentially ignored by glance, not being very useful. disk_format is the important bit for external consumers. Also, we grab disk_format twice. Change-Id: Idc90a8542e1351da641e42aa67d8fa1c37b544e1 commit 049b4cef420d239210148790d7b627bfb5197435 Author: Monty Taylor Date: Thu Apr 6 10:26:29 2017 -0500 Don't run extra server info on every server in list If someone is just doing a get, there is no reason to fill in the extra information for EVERY server in the list. This makes ansible modules especially slow. Instead, if get_server is called, prevent list_servers from doing the expansion and instead do it late just on the one requested. Fixes: ansible/ansbile#23354 Change-Id: I42773b292b11f1faa26cf9193b2d0435d9455dd0 commit ccf7cca47372249f6df392670e8c1baa061278b7 Author: Monty Taylor Date: Thu Apr 6 09:23:40 2017 -0500 Use REST for neutron floating IP list Wow, turns out we already had the tests fixed. How did we do that? Change-Id: I1c26a6f817ef7e7d67ba2e560da1149bc4345fbc commit f956aed405c2837bcef48e0e7ddd34e06ad046a5 Author: Monty Taylor Date: Sun Apr 2 11:14:31 2017 -0500 Migrate create_image_snapshot to REST Change-Id: I6cb8a26bf9d6189ecc18ee7fbde44f37c131aaa8 commit aa58173f0d60a8f04318b51ff6d1490e7ee10cfb Author: Monty Taylor Date: Sun Apr 2 15:53:06 2017 -0500 Add ability to configure extra_specs to be off We fetch flavor extra_specs for each flavor for consistency with old behavior. However, it's costly and often just simply not needed. Query clouds.yaml for extra client settings and if "get_flavor_extra_specs" is set to false, set the default for list_flavors to false. Change-Id: Iaea1c41e8e0ae504cb080d7d37407de12be96fd1 commit 413965c33101197ed86b742e3f8aee1764fda323 Author: Monty Taylor Date: Sun Apr 2 09:11:02 2017 -0500 Migrate server snapshot tests to requests_mock Change-Id: Ic6a489ac25688b7666a6a130f7daf43841909f30 commit cf54ef6b9203d9afcb9c9e50ab19bad73094015d Author: Monty Taylor Date: Fri Mar 31 11:58:00 2017 -0500 Add test to validate multi _ heat stack_status According to the Heat API docs, there is a status of IN_PROGRESS which can cause the old code to fail. Add a test that sets that stack_status so that we ensure we don't regress on splitting the stack_status. Change-Id: Ibb1143ffd47465d1640f17bf4319425e6db1f4d1 commit 97b9ac6beb730b00201351bad4efed32cf0fc605 Author: Sorin Sbarnea Date: Fri Mar 31 17:56:43 2017 +0100 Fixed stack_status.split() exception Change-Id: Idc76dde81ee71a0a81dfb9db33627c15e878268f Signed-off-by: Sorin Sbarnea commit 88d8a37cfae9b23acfeda76b354880e68de8c96f Author: Jamie Lennox Date: Wed Mar 29 11:11:59 2017 +1100 Add server security groups to shade We need a way to add and remove security groups to a server in shade. This will let us modify them from ansible. Change-Id: I5602e44720485e20491cf4930605362312274b20 commit 7e92e93104cfef6a2e6271d8d81fb4f2961f0c50 Author: OpenStack Proposal Bot Date: Thu Mar 30 14:03:25 2017 +0000 Updated from global requirements Change-Id: I87c2f41a041ebf80a97f1f4b6100800b68f4f137 commit c1984b636ee9fc6101c28bb57723d2d490b04586 Author: Monty Taylor Date: Wed Mar 29 03:53:14 2017 -0500 Add bare parameter to get/list/search server The bare parameter tells shade to skip all additional calls it makes to fill in extra information on the server record from other services, such as fixing the addresses dict. This is useful internally in shade where there are times when one is getting the server dict just to get its id so other operations, such as getting the console log or attaching security groups, can be performed. Change-Id: Ic9cc6e8be4f4e30f76d3abb655d9a3cf0cb9918b commit b31e9aa777a028e34814499d6821ac1c1bfbb881 Author: Jim Rollenhagen Date: Wed Mar 29 16:54:30 2017 -0400 Docs: add a note about rackspace API keys Some users are forced to use these instead of passwords (whether because they use 2-factor auth or by policy). Document it so they know how. Change-Id: I558c2e8d3e8b0fad0a96a361232f14443e82a35f commit bb4eededb059efc42b1b0b251f21305f00bbee26 Author: Monty Taylor Date: Wed Mar 29 05:13:18 2017 -0500 Update tox build settings Remove heatclient and magnumclient from install-tips We do not consume them anymore, so do not need to install them as part of our tips testing. Install from pip using upper-constraints. To ensure we work with OpenStack releases. Change-Id: I98f39d2e2a591eb84a1ebcd033eb51e1758f1f39 commit b447fa4356c9af229f9fb49226f02711d936f390 Author: Monty Taylor Date: Sat Mar 25 17:22:23 2017 -0500 Take care of multiple imports and update explanation The explanation for what's up with pep8 checks is a little different than it used to be. Get it up to current. Change-Id: I2c03a5aec02dd41ed5cdfb4c4082e17339ed2765 commit b34e06f81b251a405638ac0698fef7943f3d3bfc Author: Monty Taylor Date: Sat Mar 25 17:12:28 2017 -0500 Reenable hacking tests that already pass Several of the ignores are things we're already clean on. Just reenable them. Change-Id: Ic6ac2123ca2574a089aa2882f84cf0d4a9d47b1e commit 7ac3c0321246816abb4fb59011dbb259590e78d4 Author: Monty Taylor Date: Wed Mar 15 18:21:46 2017 +0100 Enable H201 - don't throw bare exceptions I agree - bare except is bad - it can cause ctrl-c to stop working, which is totally evil. (I mean, unless that is the intent, in which case it's the right thing to do. None of these cases are cases when we desire ctrl-c to stop working) Change-Id: Ieffa26e8da77199c9ef7238a6c9f0704fc581ba6 commit fe130c620b9eb39eb30dccf853d973b829056db3 Author: Monty Taylor Date: Wed Mar 15 18:19:59 2017 +0100 Enable H238 - classes should be subclasses of object As shade is no longer an Infra project, it's no longer appropriate to ignore hacking. Luckily, shade is mostly hacking clean anyway, so this isn't terribly disruptive. Change-Id: I607f1835abb328e3b4a4a33d80a1848ab11779be commit c9e9ef9f43dce18e6cdcd528414a05b9ad78134a Author: Monty Taylor