Wrong method cidr_to_netmask() in manila/utils.py

Bug #1273663 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Aleksandr Chirko

Bug Description

1) Method 'cidr_to_netmask' should be renamed to 'get_netmask_from_cidr',
 because it is real target of method.

2) method body should expect input as cidr and use parse, now, it doesn't.

tags: added: share-network
Changed in manila:
assignee: nobody → Aleksandr Chirko (achirko)
Revision history for this message
Aleksandr Chirko (achirko) wrote :

Fix proposed in master: https://review.openstack.org/69389

Changed in manila:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/76141
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=43357850cabfaa58eb34c959ddd1555a5628d628
Submitter: Jenkins
Branch: master

commit 43357850cabfaa58eb34c959ddd1555a5628d628
Author: Yulia Portnova <email address hidden>
Date: Tue Feb 25 11:49:46 2014 +0200

    Add function cidr_to_netmask to utils

    cidr_to_netmask util function to returns netmask
    from cidr subnet notation.

    Change-Id: Id76d0aa698bbd844376075dfc2ff0d9add67cf83
    Closes-Bug: #1273663

Changed in manila:
status: New → Fix Committed
Changed in manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.