API for share-networks and security-services should be available only for admins

Bug #1271943 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Aleksandr Chirko

Bug Description

New API for
1) share-networks
and
2) security-services

Should be available only for admins.

So, we need to extend default policy.json file to implement this restriction

tags: added: share-network
Changed in manila:
assignee: nobody → Aleksandr Chirko (achirko)
tags: added: policy
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/70375

Changed in manila:
status: New → In Progress
Changed in manila:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/71278

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/70375
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=826b15692ee0cfa509d82d13fbba09c56c9c6b27
Submitter: Jenkins
Branch: master

commit 826b15692ee0cfa509d82d13fbba09c56c9c6b27
Author: Aleks Chirko <email address hidden>
Date: Fri Jan 31 18:37:11 2014 +0200

    Fix policy.py

    Because inside check_policy() there is hardcoded
    'share' target prepended to all policies, any
    policy we check will be checked against 'share'
    policy. Change check_policy() to use explicit
    target and action instead of just action.
    Change wrap_check_policy decorator to be a
    decorator maker which accepts resource name
    as an argument.
    Closes-Bug: #1274951
    Partial-Bug: #1271943

    Change-Id: I85c184035619d78107d56ea94918f608d8d7c282

Changed in manila:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/71278
Committed: https://git.openstack.org/cgit/stackforge/manila/commit/?id=9ae134954fad334593a2dffe83b111799ebae68b
Submitter: Jenkins
Branch: master

commit 9ae134954fad334593a2dffe83b111799ebae68b
Author: Aleks Chirko <email address hidden>
Date: Wed Feb 5 16:51:48 2014 +0200

    Add policy checks in share networks API

    Add sample policy configuration for share
    network API.
    Closes-Bug: #1271943

    Change-Id: I77aad91014d7c0ef125192bddeae7aafaaed3aef

Changed in manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.