manila-ui

Missing param check in list command

Bug #1967312 reported by Victoria Martinez de la Cruz
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
manila-ui
Fix Released
High
Goutham Pacha Ravi
manila-ui zed-1
python-manilaclient
Fix Released
Low
Unassigned
python-manilaclient caracal-client-release

Bug Description

In the list implementation for API versions 2.35 to 2.68 [0] we are not sanitizing the search_opts param. If this param is not set (which is the default value) this leads to "AttributeError: 'NoneType' object has no attribute 'pop'"

[0] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L356-L362

Victoria Martinez de la Cruz (vkmc)
Changed in python-manilaclient:
assignee: nobody → Yukti Sharma (s-yukti)
Victoria Martinez de la Cruz (vkmc)
Changed in python-manilaclient:
status: New → Won't Fix
status: Won't Fix → Confirmed
importance: Undecided → High
milestone: none → zed-1
Goutham Pacha Ravi (gouthamr)
Changed in manila-ui:
milestone: none → zed-1
OpenStack Infra (hudson-openstack)
Changed in python-manilaclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila-ui/+/837614

Changed in manila-ui:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila-ui:
importance: Undecided → Medium
importance: Medium → High
assignee: nobody → Goutham Pacha Ravi (gouthamr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (master)

Reviewed: https://review.opendev.org/c/openstack/manila-ui/+/837614
Committed: https://opendev.org/openstack/manila-ui/commit/3221aceb346fcbe55eec959d5934ac4d0ef18cbd
Submitter: "Zuul (22348)"
Branch: master

commit 3221aceb346fcbe55eec959d5934ac4d0ef18cbd
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Apr 13 00:48:04 2022 +0530

    Workaround SDK bug in listing shares

    python-manilaclient 3.3.0 [1] has a bug that causes the shares
    panel to fail to load with an error:

    Error: Unable to retrieve share list. Details
    'NoneType' object has no attribute 'pop'

    Workaround this problem so we don't have to add the client
    version to a block-list in the UI's requirements files.

    Closes-Bug: #1967312
    [1] https://pypi.org/project/python-manilaclient/3.3.0/

    Change-Id: I9e79972d9aca4fc7845f4d274751351d948f41ef
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

Changed in manila-ui:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila-ui/+/837682

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila-ui/+/837682
Committed: https://opendev.org/openstack/manila-ui/commit/9fe5dab14351d622cb3d8778bbd4672088b1023f
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 9fe5dab14351d622cb3d8778bbd4672088b1023f
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Apr 13 00:48:04 2022 +0530

    Workaround SDK bug in listing shares

    python-manilaclient 3.3.0 [1] has a bug that causes the shares
    panel to fail to load with an error:

    Error: Unable to retrieve share list. Details
    'NoneType' object has no attribute 'pop'

    Workaround this problem so we don't have to add the client
    version to a block-list in the UI's requirements files.

    Closes-Bug: #1967312
    [1] https://pypi.org/project/python-manilaclient/3.3.0/

    Change-Id: I9e79972d9aca4fc7845f4d274751351d948f41ef
    Signed-off-by: Goutham Pacha Ravi <email address hidden>
    (cherry picked from commit 3221aceb346fcbe55eec959d5934ac4d0ef18cbd)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 8.0.0.0rc1

This issue was fixed in the openstack/manila-ui 8.0.0.0rc1 release candidate.

Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
milestone: zed-1 → none
Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
importance: High → Low
assignee: Yukti Sharma (s-yukti) → nobody
status: In Progress → Confirmed
OpenStack Infra (hudson-openstack)
Changed in python-manilaclient:
status: Confirmed → In Progress
Revision history for this message
Nobuto Murata (nobuto) wrote :

SRU for Ubuntu packages is tracked at:
https://launchpad.net/bugs/2003772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 7.0.1

This issue was fixed in the openstack/manila-ui 7.0.1 release.

Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
milestone: none → caracal-2
Carlos Eduardo (silvacarlose)
Changed in python-manilaclient:
milestone: caracal-2 → caracal-client-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-manilaclient (master)

Change abandoned by "Goutham Pacha Ravi <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/863652
Reason: No follow up; abandoning.. there's another change addressing this: https://review.opendev.org/c/openstack/python-manilaclient/+/863652/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/837611
Committed: https://opendev.org/openstack/python-manilaclient/commit/d66d7b1d1481fe00aa8d3809b6c17e09d9d1cb8f
Submitter: "Zuul (22348)"
Branch: master

commit d66d7b1d1481fe00aa8d3809b6c17e09d9d1cb8f
Author: sdailey <email address hidden>
Date: Tue Apr 12 17:09:28 2022 +0000

    Fix list call when search_opts isn't provided

    Added line to the list implementation versions 2.35 to 2.68 to point
    the search_opts variable to an empty dict if it was set to none.

    Closes-bug: #1967312
    Change-Id: Ibbd95047ad082665c323f58b735e843d32001c45

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/909553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/909553
Committed: https://opendev.org/openstack/python-manilaclient/commit/d7193cd8958a422845b70665b2d9d0e74ffd7acc
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit d7193cd8958a422845b70665b2d9d0e74ffd7acc
Author: sdailey <email address hidden>
Date: Tue Apr 12 17:09:28 2022 +0000

    Fix list call when search_opts isn't provided

    Added line to the list implementation versions 2.35 to 2.68 to point
    the search_opts variable to an empty dict if it was set to none.

    Closes-bug: #1967312
    Change-Id: Ibbd95047ad082665c323f58b735e843d32001c45
    (cherry picked from commit d66d7b1d1481fe00aa8d3809b6c17e09d9d1cb8f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.8.0

This issue was fixed in the openstack/python-manilaclient 4.8.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.