Unable to select share networks with share types that have a hyphen in their name
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
manila-ui |
Fix Released
|
Medium
|
Goutham Pacha Ravi |
Bug Description
This issue was observed in Red Hat OpenStack Platform 16.1.
When using the "Create share" form, the "Share Network" label and associated Select widget appears only if a Share type that has "driver_
Screenshots:
Share types: https:/
Create Share form with a share type that presents the Share network selection widget: https:/
Create Share form with a share type that must present the Share network selection widget, but doesnt: https:/
Goutham Pacha Ravi (gouthamr) wrote : | #1 |
Goutham Pacha Ravi (gouthamr) wrote : | #2 |
The issue isn't reproducible on devstack with stable/train branch code: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (master) | #3 |
Fix proposed to branch: master
Review: https:/
Changed in manila-ui: | |
status: | New → In Progress |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/train) | #4 |
Fix proposed to branch: stable/train
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/wallaby) | #5 |
Fix proposed to branch: stable/wallaby
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/victoria) | #6 |
Fix proposed to branch: stable/victoria
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/ussuri) | #7 |
Fix proposed to branch: stable/ussuri
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/wallaby) | #8 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/wallaby
commit b7d87e886a1d71e
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jun 15 00:02:09 2021 -0700
Fix parsing names in switched fields
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Closes-Bug: #1931641
[1] https:/
Change-Id: Id924fc55debdc3
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 37e5b2f0530c9fe
tags: | added: in-stable-wallaby |
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (master) | #9 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 37e5b2f0530c9fe
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jun 15 00:02:09 2021 -0700
Fix parsing names in switched fields
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Closes-Bug: #1931641
[1] https:/
Change-Id: Id924fc55debdc3
Signed-off-by: Goutham Pacha Ravi <email address hidden>
Changed in manila-ui: | |
status: | In Progress → Fix Released |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (master) | #10 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/wallaby) | #11 |
Fix proposed to branch: stable/wallaby
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (master) | #12 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 803ab32358eec94
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Jun 21 14:58:54 2021 -0700
Fix share group creation with share types
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f0530c9fe
Change-Id: I0983359acc4895
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/victoria) | #13 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/victoria
commit 6ad8fd882afe8c7
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jun 15 00:02:09 2021 -0700
Fix parsing names in switched fields
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Closes-Bug: #1931641
[1] https:/
Change-Id: Id924fc55debdc3
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 37e5b2f0530c9fe
(cherry picked from commit b7d87e886a1d71e
tags: | added: in-stable-victoria |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/victoria) | #14 |
Fix proposed to branch: stable/victoria
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/ussuri) | #15 |
Fix proposed to branch: stable/ussuri
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (stable/train) | #16 |
Fix proposed to branch: stable/train
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/ussuri) | #17 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/ussuri
commit a97f5e67508b02c
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jun 15 00:02:09 2021 -0700
Fix parsing names in switched fields
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Closes-Bug: #1931641
[1] https:/
Change-Id: Id924fc55debdc3
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 37e5b2f0530c9fe
(cherry picked from commit b7d87e886a1d71e
(cherry picked from commit 6ad8fd882afe8c7
tags: | added: in-stable-ussuri |
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/wallaby) | #18 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/wallaby
commit f421aeb1e186644
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Jun 21 14:58:54 2021 -0700
Fix share group creation with share types
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f0530c9fe
Change-Id: I0983359acc4895
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 803ab32358eec94
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/train) | #19 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/train
commit 902baefc33f3b78
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jun 15 00:02:09 2021 -0700
Fix parsing names in switched fields
In the share creation form dialog, share network
selection is optionally provided based on whether
the share type chosen supports the DHSS extra-spec.
This selection breaks often when dealing with share
types that have a name matching the format: ".*-\d+.*".
For example: test-700. The root cause of this seems to
be in javascript code for "switchable" fields [1] that
doesn't get triggered as expected.
A similar issue manifests in the share Network Creation
form where we setup switched fields with the Neutron
network IDs (dashed format UUIDs) and in the Share
Group Creation form where we setup switched fields
with the Share Group Type IDs (dashed format UUIDs).
So, we could encode the "-" in these field names to
workaround this issue.
Unfortunately this isn't a clean cherry-pick since
we need to support users running manila-ui under
python2 in this branch - and unicode wrangling
isn't cleanly possible due to some assumptions
django makes about field names in the forms code as
well as in tests.
Closes-Bug: #1931641
[1] https:/
Change-Id: Id924fc55debdc3
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 37e5b2f0530c9fe
(cherry picked from commit b7d87e886a1d71e
(cherry picked from commit 6ad8fd882afe8c7
(cherry picked from commit a97f5e67508b02c
Signed-off-by: Goutham Pacha Ravi <email address hidden>
tags: | added: in-stable-train |
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/victoria) | #20 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/victoria
commit bf820e10c742c3a
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Jun 21 14:58:54 2021 -0700
Fix share group creation with share types
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f0530c9fe
Change-Id: I0983359acc4895
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 803ab32358eec94
(cherry picked from commit f421aeb1e186644
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/ussuri) | #21 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/ussuri
commit 21e31332cb0a3e7
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Jun 21 14:58:54 2021 -0700
Fix share group creation with share types
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f0530c9fe
Change-Id: I0983359acc4895
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 803ab32358eec94
(cherry picked from commit f421aeb1e186644
(cherry picked from commit bf820e10c742c3a
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (stable/train) | #22 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/train
commit 2ce86803ba72d00
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Jun 21 14:58:54 2021 -0700
Fix share group creation with share types
A recent change [1] introduced an encoding for
problematic field names. On the share group
creation form, an encoding was missed causing
a silent failure where the share type/s chosen
were ignored in the API request.
[1] 37e5b2f0530c9fe
Change-Id: I0983359acc4895
Partial-Bug: #1931641
Signed-off-by: Goutham Pacha Ravi <email address hidden>
(cherry picked from commit 803ab32358eec94
(cherry picked from commit f421aeb1e186644
(cherry picked from commit bf820e10c742c3a
(cherry picked from commit 21e31332cb0a3e7
Changed in manila-ui: | |
importance: | Undecided → Medium |
assignee: | nobody → Goutham Pacha Ravi (gouthamr) |
milestone: | none → xena-2 |
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 3.1.0 | #23 |
This issue was fixed in the openstack/manila-ui 3.1.0 release.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 6.0.0.0rc1 | #24 |
This issue was fixed in the openstack/manila-ui 6.0.0.0rc1 release candidate.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 5.1.0 | #25 |
This issue was fixed in the openstack/manila-ui 5.1.0 release.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 4.1.0 | #26 |
This issue was fixed in the openstack/manila-ui 4.1.0 release.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui train-eol | #27 |
This issue was fixed in the openstack/manila-ui train-eol release.
Red Hat OpenStack Platform 16.1 translates to OpenStack Manila UI's train release: https:/ /opendev. org/openstack/ manila- ui/src/ branch/ stable/ train/
If you look at the browser's inspector logs, it appears that the share networks are populated, but hidden: https:/ /imgur. com/a/9ReoIcA