string_concat is removed from django as of 2.1

[Vishal Manchanda]

When I run django22 job using 'tox -e py3-dj22' command.
It is failing with below traceback:

Traceback (most recent call last):
  File "/home/ubuntu/manila-ui/manage.py", line 23, in <module>
    execute_from_command_line(sys.argv)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/commands/test.py", line 23, in run_from_argv
    super().run_from_argv(argv)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/commands/test.py", line 53, in handle
    failures = test_runner.run_tests(test_labels)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/test/runner.py", line 632, in run_tests
    self.run_checks()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/test/runner.py", line 570, in run_checks
    call_command('check', verbosity=self.verbosity)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/__init__.py", line 148, in call_command
    return command.execute(*args, **defaults)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/commands/check.py", line 64, in handle
    fail_level=getattr(checks, options['fail_level']),
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/base.py", line 390, in check
    include_deployment_checks=include_deployment_checks,
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/management/base.py", line 377, in _run_checks
    return checks.run_checks(**kwargs)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/checks/registry.py", line 72, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/checks/urls.py", line 13, in check_url_config
    return check_resolver(resolver)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/core/checks/urls.py", line 23, in check_resolver
    return check_method()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/urls/resolvers.py", line 399, in check
    for pattern in self.url_patterns:
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/utils/functional.py", line 80, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/urls/resolvers.py", line 584, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/utils/functional.py", line 80, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/urls/resolvers.py", line 577, in urlconf_module
    return import_module(self.urlconf_name)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/openstack_dashboard/test/urls.py", line 41, in <module>
    url(r'', horizon.base._wrapped_include(horizon.urls)),
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 110, in _wrapped_include
    return include((pattern_list, app_namespace), namespace=instance_namespace)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/urls/conf.py", line 33, in include
    if isinstance(urlconf_module, str):
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/utils/functional.py", line 256, in inner
    self._setup()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/django/utils/functional.py", line 392, in _setup
    self._wrapped = self._setupfunc()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 858, in url_patterns
    return self._urls()[0]
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 892, in _urls
    _wrapped_include(dash._decorated_urls)))
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 568, in _decorated_urls
    _wrapped_include(panel._decorated_urls)))
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 340, in _decorated_urls
    urlpatterns = self._get_default_urlpatterns()
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/site-packages/horizon/base.py", line 142, in _get_default_urlpatterns
    urls_mod = import_module('.urls', package_string)
  File "/home/ubuntu/manila-ui/.tox/py3-dj22/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/ubuntu/manila-ui/manila_ui/dashboards/project/shares/urls.py", line 18, in <module>
    from manila_ui.dashboards.project.shares import views as shares_views
  File "/home/ubuntu/manila-ui/manila_ui/dashboards/project/shares/views.py", line 26, in <module>
    from manila_ui.dashboards.project.shares import tables as shares_tables
  File "/home/ubuntu/manila-ui/manila_ui/dashboards/project/shares/tables.py", line 18, in <module>
    from django.utils.translation import string_concat
ImportError: cannot import name 'string_concat'
Tests failed.
ERROR: InvocationError for command /bin/bash run_tests.sh -N --no-pep8 (exited with code 1)
______________________________________________________________ summary _______________________________________________________________
ERROR: py3-dj22: commands failed

This is due to string_concat is no longer support in django2.1.
For more info please refer[1]
[1] https://github.com/django/django/blob/master/docs/releases/2.1.txt#L456

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/686891

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/686891
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=83a0e432fe475a263c2f5e5337511db96263c3b8
Submitter: Zuul
Branch: master

commit 83a0e432fe475a263c2f5e5337511db96263c3b8
Author: manchandavishal <email address hidden>
Date: Sat Oct 5 11:45:04 2019 +0000

    Switch from django string_concat to format_lazy

    string_concat was removed in django 2.1 when it reached the end
    of it's deprecation cycle. It was removed because the same behavior
    can be achieved with format_lazy.

    For more info. please refer [1].
    [1] https://github.com/django/django/blob/master/docs/releases/2.1.txt#L456

    Change-Id: I794a62cd39061d9bffe5a1c074bf1ff209d15f21
    Closes-Bug: #1846878

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/727385

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727385
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=b1f62a005c61555205931985f6a871e57b2adcab
Submitter: Zuul
Branch: stable/train

commit b1f62a005c61555205931985f6a871e57b2adcab
Author: manchandavishal <email address hidden>
Date: Sat Oct 5 11:45:04 2019 +0000

    Switch from django string_concat to format_lazy

    string_concat was removed in django 2.1 when it reached the end
    of it's deprecation cycle. It was removed because the same behavior
    can be achieved with format_lazy.

    For more info. please refer [1].
    [1] https://github.com/django/django/blob/master/docs/releases/2.1.txt#L456

    Change-Id: I794a62cd39061d9bffe5a1c074bf1ff209d15f21
    Closes-Bug: #1846878
    (cherry picked from commit 83a0e432fe475a263c2f5e5337511db96263c3b8)