Unable to retrieve replica details as non-admin user

[Goutham Pacha Ravi]

How to reproduce:

0) Setup manila with a driver that supports replication (ex: zfsonlinux driver, or just the dummy driver for testing)
1) As admin, create a share type that supports replication, set appropriate replication_type extra spec (replication_type = "readable" for dummy and zfsonlinux drivers)
2) Log into UI as non-admin user, create a share of the type created above
3) Create a share replica (Drop down on the share you created in #2, click "Manage Replicas"->"Create Replica")
4) Click on share replica to retrieve its details

Expected Results:
- See the details of the replica, ex: export location needed to mount the replica

Actual Results:
- An error banner pops up, redirecting the user to the last page, See attached screenshot

[Goutham Pacha Ravi (gouthamr)]

The UI uses an API (GET /v2/{tenant_id}/share_instances/{share_instance_id}/export_locations) that has default policy set to "admin"; we don't/shouldn't expect cloud administrators to relax this policy for users to see per-replica export locations. Manila needs a way to expose share replica export locations to end users.

https://developer.openstack.org/api-ref/shared-file-system/#id302

[Goutham Pacha Ravi (gouthamr)]

Manila exposes, with API 2.47, an export locations API that has its default policy set such that non-privileged tenants may access it [1]

The manila client SDK supports this feature too, in version 1.27.x of the library [2]

[1] https://developer.openstack.org/api-ref/shared-file-system/#share-replica-export-locations-since-api-v2-47
[2] https://docs.openstack.org/releasenotes/python-manilaclient/stein.html#relnotes-1-27-0-stable-stein

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/649702

[Goutham Pacha Ravi (gouthamr)]

https://review.openstack.org/649702 is only a partial fix that we can back port to stable releases. please follow https://bugs.launchpad.net/manila-ui/+bug/1823078 which blocks using a tenant visible export locations API for non-privileged project users to retrieve export locations of individual share replicas.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649702
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=8aa099315403381c5c3bb32415d5ba5d8e518a4d
Submitter: Zuul
Branch: master

commit 8aa099315403381c5c3bb32415d5ba5d8e518a4d
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Apr 3 12:18:19 2019 -0700

    Fix share replica details page for non-admins

    Non-administrators cannot access share instance
    export locations by the virtue of default policy.

    Fix this retrieval to not error-out showing the
    whole page.

    Change-Id: I5f78e7fbfbf4ce93f9c1658609f20f179c6995a6
    Closes-Bug: #1787016

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/650130

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-ui 2.18.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650130
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=4ce060cf725210e895c7b1567c1c6a4928db44ee
Submitter: Zuul
Branch: stable/rocky

commit 4ce060cf725210e895c7b1567c1c6a4928db44ee
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Apr 3 12:18:19 2019 -0700

    Fix share replica details page for non-admins

    Non-administrators cannot access share instance
    export locations by the virtue of default policy.

    Fix this retrieval to not error-out showing the
    whole page.

    Change-Id: I5f78e7fbfbf4ce93f9c1658609f20f179c6995a6
    Closes-Bug: #1787016
    (cherry picked from commit 8aa099315403381c5c3bb32415d5ba5d8e518a4d)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/651536

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651536
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=517266b37c8c73daeff8ee785c2134fb9d179578
Submitter: Zuul
Branch: stable/queens

commit 517266b37c8c73daeff8ee785c2134fb9d179578
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Apr 3 12:18:19 2019 -0700

    Fix share replica details page for non-admins

    Non-administrators cannot access share instance
    export locations by the virtue of default policy.

    Fix this retrieval to not error-out showing the
    whole page.

    Change-Id: I5f78e7fbfbf4ce93f9c1658609f20f179c6995a6
    Closes-Bug: #1787016
    (cherry picked from commit 8aa099315403381c5c3bb32415d5ba5d8e518a4d)
    (cherry picked from commit 4ce060cf725210e895c7b1567c1c6a4928db44ee)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-ui 2.13.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-ui 2.16.1 release.