Manila UI breaks network tabs (Pike)

[Christoph Fiehe]

I have setup a fresh OpenStack Pike HA environment based on Ubuntu 16.04.3 and added the Manila UI to Horizon. Unfortunately, the Manila dashboard integration breaks the standard network tabs, causing the buttons "Create Network" and "Create Router" to silently disappear from the "Networks" and "Routers" panel.

The horizon.log gives me the following when opening the "Networks" tab from the browser:
[Wed Sep 06 14:56:25.196450 2017] [wsgi:error] [pid 16347:tid 140146471208704] TypeError: tenant_quota_usages() got an unexpected keyword argument 'targets'
[Wed Sep 06 14:56:25.207755 2017] [wsgi:error] [pid 16347:tid 140146471208704] ERROR horizon.tables.base Error while checking action permissions.
[Wed Sep 06 14:56:25.207791 2017] [wsgi:error] [pid 16347:tid 140146471208704] Traceback (most recent call last):
[Wed Sep 06 14:56:25.207795 2017] [wsgi:error] [pid 16347:tid 140146471208704] File "/usr/share/openstack-dashboard/horizon/tables/base.py", line 1378, in _filter_action
[Wed Sep 06 14:56:25.207799 2017] [wsgi:error] [pid 16347:tid 140146471208704] return action._allowed(request, datum) and row_matched
[Wed Sep 06 14:56:25.207802 2017] [wsgi:error] [pid 16347:tid 140146471208704] File "/usr/share/openstack-dashboard/horizon/tables/actions.py", line 137, in _allowed
[Wed Sep 06 14:56:25.207806 2017] [wsgi:error] [pid 16347:tid 140146471208704] self.allowed(request, datum))
[Wed Sep 06 14:56:25.207875 2017] [wsgi:error] [pid 16347:tid 140146471208704] File "/usr/share/openstack-dashboard/openstack_dashboard/dashboards/project/networks/tables.py", line 95, in allowed
[Wed Sep 06 14:56:25.207882 2017] [wsgi:error] [pid 16347:tid 140146471208704] usages = quotas.tenant_quota_usages(request, targets=('networks', ))
[Wed Sep 06 14:56:25.207885 2017] [wsgi:error] [pid 16347:tid 140146471208704] File "/usr/lib/python2.7/dist-packages/manila_ui/dashboards/project/shares/__init__.py", line 57, in wrapper
[Wed Sep 06 14:56:25.207889 2017] [wsgi:error] [pid 16347:tid 140146471208704] return new_func(orig_func, *args, **kwargs)

May someone please have a look.

[Dr. Clemens Hardewig (bringha1)]

I have the same problem too

In addition, also my Network topology and overview panel are not available anymore - now subnet or any other network attributes can be created either

Horizon is therewith unusable in Pike currently

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/503021

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503021
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=f49f885b32f750c19cda619fa0290ea36503dc98
Submitter: Jenkins
Branch: master

commit f49f885b32f750c19cda619fa0290ea36503dc98
Author: Christoph Fiehe <email address hidden>
Date: Tue Sep 12 16:32:22 2017 +0200

    Manila-UI breaks Horizon's "Network" panel group

    Since the OpenStack Pike release, the Manila UI dashboard integration
    for Horizon breaks the "Network" panel group, causing the "Network
    Topology" panel to fail and the buttons "Create Network", "Create
    Router", "Create Security Group" and "Allocate IP To Project" to
    silently disappear from the panels "Networks", "Routers", "Security
    Groups" and "Floating IPs".

    This commit adds the parameter "targets" to the method
    "tenant_quota_usages" that was introduced by the fix of Horizon
    Bug#1675504.

    Closes-Bug #1715540
    Signed-off-by: Christoph Fiehe <email address hidden>

    Change-Id: I6d8f9ae2ae03577e63cc985d37fcbba824d68a9d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/503584

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503584
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=e5e86282337ecf4c34c6bcd8d2569a4f9c8ed42f
Submitter: Jenkins
Branch: stable/pike

commit e5e86282337ecf4c34c6bcd8d2569a4f9c8ed42f
Author: Christoph Fiehe <email address hidden>
Date: Tue Sep 12 16:32:22 2017 +0200

    Manila-UI breaks Horizon's "Network" panel group

    Since the OpenStack Pike release, the Manila UI dashboard integration
    for Horizon breaks the "Network" panel group, causing the "Network
    Topology" panel to fail and the buttons "Create Network", "Create
    Router", "Create Security Group" and "Allocate IP To Project" to
    silently disappear from the panels "Networks", "Routers", "Security
    Groups" and "Floating IPs".

    This commit adds the parameter "targets" to the method
    "tenant_quota_usages" that was introduced by the fix of Horizon
    Bug#1675504.

    Closes-Bug #1715540
    Signed-off-by: Christoph Fiehe <email address hidden>

    Change-Id: I6d8f9ae2ae03577e63cc985d37fcbba824d68a9d
    (cherry picked from commit f49f885b32f750c19cda619fa0290ea36503dc98)