Disabled quotas cannot be obtained properly

[Tatiana Ovchinnikova]

All attempts to check create share action permission are futile, and instead of "Create Share" button we get a traceback:

Error while checking action permissions.
Traceback (most recent call last):
  File "/home/lys/OpenStack/manila/horizon/horizon/tables/base.py", line 1289, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/lys/OpenStack/manila/horizon/horizon/tables/actions.py", line 137, in _allowed
    self.allowed(request, datum))
  File "/home/lys/OpenStack/manila/manila-ui/manila_ui/dashboards/project/shares/shares/tables.py", line 75, in allowed
    usages = quotas.tenant_quota_usages(request)
  File "/home/lys/OpenStack/manila/manila-ui/manila_ui/dashboards/project/shares/__init__.py", line 57, in wrapper
    return new_func(orig_func, *args, **kwargs)
  File "/home/lys/OpenStack/manila/manila-ui/manila_ui/dashboards/project/shares/__init__.py", line 137, in tenant_quota_usages
    usages = f(request, tenant_id)
  File "/home/lys/OpenStack/manila/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/lys/OpenStack/manila/horizon/openstack_dashboard/usage/quotas.py", line 392, in tenant_quota_usages
    disabled_quotas = get_disabled_quotas(request)
  File "/home/lys/OpenStack/manila/manila-ui/manila_ui/dashboards/project/shares/__init__.py", line 57, in wrapper
    return new_func(orig_func, *args, **kwargs)
  File "/home/lys/OpenStack/manila/manila-ui/manila_ui/dashboards/project/shares/__init__.py", line 129, in get_disabled_quotas
    disabled_quotas.extend(_get_manila_disabled_quotas(request))
AttributeError: 'set' object has no attribute 'extend'

Disabled quotas should be treated as a set, not as a list.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352889
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=06c81a4a071270f4ba9ffabf218f0b187e141e22
Submitter: Jenkins
Branch: master

commit 06c81a4a071270f4ba9ffabf218f0b187e141e22
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Aug 9 16:04:15 2016 +0300

    Fix get_disabled_quotas

    Disabled quotas should be treated as a set, not as a list, or else
    instead of action buttons we'll get a traceback:

    File "/manila-ui/manila_ui/dashboards/project/shares/__init__.py",
        line 129, in get_disabled_quotas
        disabled_quotas.extend(_get_manila_disabled_quotas(request))
    AttributeError: 'set' object has no attribute 'extend'

    Change-Id: I5364a8b7fbea3f166264c33ffb6eff341e140bdf
    Closes-Bug: #1611368

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila-ui 2.4.0 release.