Test coverage is too small

[Valeriy Ponomaryov]

To view test coverage run following command:

$ tox -e cover

Then, in newly created dir "reports" will be list of files with marked uncovered code with unit tests.

And there is lots of places that are not tested at all.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314965
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=a169db47fe63991ce42f75a55ec71c5f0f9d7194
Submitter: Jenkins
Branch: master

commit a169db47fe63991ce42f75a55ec71c5f0f9d7194
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed May 11 12:51:25 2016 +0300

    Update HTML template for security service detailed page

    Also cover admin part with unit tests and fix "redirect url"
    for case requested security service not found.

    Change-Id: I166029353984da75b72e26e5b4be30687a9aef78
    Partial-Bug: #1578284
    Partial-Bug: #1576776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314992
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=45a0c5f776edb801fa1124a3aed39a40a9f11a7a
Submitter: Jenkins
Branch: master

commit 45a0c5f776edb801fa1124a3aed39a40a9f11a7a
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed May 11 14:56:04 2016 +0300

    Update HTML template for share network detailed page

    Also cover admin part with unit tests and fix "redirect url"
    for case requested share network not found.

    Change-Id: I8acaa58a1ee7095cd8675379489050194018fb55
    Partial-Bug: #1578284
    Partial-Bug: #1576776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/315000
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=fe06503a021a84bec8a6f41b084e7bdb3ef9b137
Submitter: Jenkins
Branch: master

commit fe06503a021a84bec8a6f41b084e7bdb3ef9b137
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed May 11 15:14:05 2016 +0300

    Update HTML template for snapshot detailed page

    Also cover admin part with unit tests and fix "redirect url"
    for case requested snapshot not found.

    Change-Id: I99a8de9534231e122eaa902f11d99b23d19e88ba
    Partial-Bug: #1578284
    Partial-Bug: #1576776

[Dustin Schoenbrun (dschoenb)]

I just checked out the master branch of manila-ui and ran the coverage job and it reports coverage of 82.29%. Looking at some of the details it looks like a log of the calls into the Manila client are not covered and neither are a lot of negative branches in the code. This is still something that needs to be improved and looked at.

[Dustin Schoenbrun (dschoenb)]

This bug is way too vague to be meaningfully actionable. Closing it as invalid and I will request that future bugs that come in along these lines more specifically targeted to specific areas of the code.