Manila-ui plug-in should not use Horizon overrides.py feature

[Richard Hagarty]

1 - the manila-ui plug-in is using a feature of Horizon that was never intended to be used by plug-ins. This feature is placing monkey patch code in a file and then invoking it by using the "customization_module" setting in Horizon local settings.

2 - the "customization_module" can only point to one file, so if multiple plug-ins try to use this feature, only one can be active at a time.

Avoiding the monkey patch issue, the best short-term solution is to place all of this code in a local _init_.py file so that there will not be any potential conflicts with other plug-ins.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/215781

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/215781
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=871f5ce4ebaf20c46c2ef8cf857ec98084eb1e04
Submitter: Jenkins
Branch: master

commit 871f5ce4ebaf20c46c2ef8cf857ec98084eb1e04
Author: Rich Hagarty <email address hidden>
Date: Fri Aug 21 13:46:07 2015 -0700

    Remove overrides reference from Manila-UI plug-in

    Plug-ins should not be using the "customization_module" override
    mechanism to change default Horizon behavior. Any "override"
    code should live with the __init__.py file of the appropriate
    plug-in directory.

    Change-Id: Idc2c66e2994780298725535f00184d4e3f2f6bb9
    Closes-Bug: #1485112

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-ui 1.2.0 release.