exceptions.check_message does not work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Low
|
Akihiro Motoki | ||
manila-ui |
Fix Released
|
Undecided
|
Akihiro Motoki |
Bug Description
When using exceptions.
To reproduce:
Stop the Nova API
Navigate to http://<ip>/admin/info/
Other notes:
1. Even if the error message contains "Connection" and "refused" exactly, the same error screen is shown, because the exception is re-raised in both situations, and is not being handled properly higher up.
2. The exception being raised when a connection is refused is ConnectionError, a Python built-in exception.
3. The only other situation where check_message is used within Horizon is in https:/
4. The current use of check_message is not compatible with localization. The keywords checked for are not translated, so if the exception message is translated, the words will never match.
Changed in horizon: | |
status: | In Progress → New |
assignee: | Ryan Rossiter (rlrossit) → nobody |
Changed in horizon: | |
importance: | Undecided → Low |
tags: | added: low-hanging-fruit |
description: | updated |
description: | updated |
Changed in horizon: | |
assignee: | nobody → Robin Cernin (rcernin) |
Changed in manila-ui: | |
assignee: | nobody → Robin Cernin (rcernin) |
Changed in manila-ui: | |
assignee: | Robin Cernin (rcernin) → Akihiro Motoki (amotoki) |
Changed in horizon: | |
assignee: | Robin Cernin (rcernin) → Akihiro Motoki (amotoki) |
Fix proposed to branch: master /review. openstack. org/106864
Review: https:/