image publish job is failing

[Tom Barron]

We recently merged a review [1] that built a new generic service image but it published to tarballs.openstack.org incorrectly. The publish job should have added the new image to http://tarballs.openstack.org/manila-image-elements/images, which has these contents:

Index of /manila-image-elements/images/images
[ICO] Name Last modified Size Description
[PARENTDIR] Parent Directory -
[DIR] images/ 2019-01-03 17:45 -
[ ] manila-service-image-master.qcow2 2017-09-27 05:07 323M
[ ] manila-service-image-refs-tags-1.2.0.qcow2 2016-03-24 19:10 288M
[ ] manila-service-image-refs-tags-1.3.0.qcow2 2017-03-01 20:21 275M
[ ] manila-ubuntu-core.qcow2 2015-11-17 16:06 299M

The publish job instead added in an additional images subdirectory -- to http://tarballs.openstack.org/manila-image-elements/images/images:

Index of /manila-image-elements/images/images
[ICO] Name Last modified Size Description
[PARENTDIR] Parent Directory -
[ ] manila-service-image-refs-heads-master.qcow2 2019-01-03 17:45 360M

Note also that the job no longer saves the image with the correct name, nor keeps it under a tagged name.

[1] https://review.openstack.org/#/c/627795/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/631846
Committed: https://git.openstack.org/cgit/openstack/manila-image-elements/commit/?id=ee41dc68a809dc4a4b9a973ee3f62ecb6822d11f
Submitter: Zuul
Branch: master

commit ee41dc68a809dc4a4b9a973ee3f62ecb6822d11f
Author: Tom Barron <email address hidden>
Date: Fri Jan 18 12:36:48 2019 -0500

    Add native Zuul v3 manila image elements jobs

    Replace the auto-converted legacy jobs with native jobs
    and define all the jobs in-tree. After we merge this we
    can remove the legacy-manila-publish-generic job from the
    openstack-zuul-jobs repository.

    Note that the old job apparently relied on some JJB magic
    to construct tagged-image names. This no longer works so
    instead we use 'git describe --tags' to obtain a current
    tag, publish the image with its tagged name, and symlink
    manila-service-image-master.qcow2 -- which is the expected
    image-name for our CI jobs -- to it.

    Unfortunately the new publish job can't be tested
    beforehand so we may have to follow this with another
    patch if there are issues.

    Closes-Bug: #1812478
    Change-Id: Ie0c367591c0e1ae4fefb62688ecd76aff5b94464