When remove an attachment, remove also the comment entry

Bug #126224 reported by Marco Rodrigues
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Graham Binns

Bug Description

Anyone can verify what I'm saying at for example this bug - https://bugs.launchpad.net/ubuntu/+source/ipkungfu/+bug/126106

Check the 3rd comment.. I've removed the attachment, so why it's the entry of it there?

When remove a attachment, should remove also the comment associated with it.

Thanks!

Tags: lp-bugs
Changed in malone:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Marco Rodrigues (gothicx) wrote :

Like mpt said, it should only remove the comment with no text inside it. So only if it has attachment with no text.

Graham Binns (gmb)
Changed in malone:
assignee: nobody → gmb
Graham Binns (gmb)
Changed in malone:
status: Confirmed → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote :

The comment shouldn't be removed from the database, though. The code that displays the comments on the bug page should simply hide it if it's empty. This is to ensure that the permalinks of the comments don't change when removing an attachment.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 126224] Re: When remove an attachment, remove also the comment entry

Björn Tillenius wrote:
> The comment shouldn't be removed from the database, though. The code
> that displays the comments on the bug page should simply hide it if it's
> empty. This is to ensure that the permalinks of the comments don't
> change when removing an attachment.
>

I'll bear that in mind, thanks.

--
Graham

Revision history for this message
Graham Binns (gmb) wrote :

Fix in review.

Graham Binns (gmb)
Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.