Add domain: user feedback

[Florian Fuchs]

from http://wiki.list.org/display/DEV/Notes+from+the+GHC11+Open+Source+Day

"When you try to add a new domain, the software should show you the results of your action - did it succeed, fail, etc - put a message at the top"

[benste (benste)]

Atm. we're using a redirect to the Domain Index, incl. the display of all current Domains on Success.

Adding an additional Message would require to change the whole part (views l73) to render the whole page into the template which would duplicate code.

Or, adding an additional arguement to the view we could render the domain index view with a different argument
BUT we would keep the URL

personally I'd prefer to leave it as it is.

[Florian Fuchs (flo-fuchs)]

IMO we definitely need some kind of feedback. At the moment the "add domain" view only returns some feedback if the action fails (through form validation). What's missing is a success message.

I suggest on of these two quite common solutions:

1.) Successful adding of a domain redirects to a domain detail page, where all of the domain's info is displayed, along with a success message.

or:

2.) Redirect to the domain index page, also by displaying a success message.

Usually I would opt for solution 1. But since the amount of info per domain is rather small, I think the second solution would also be OK in this case. Both solutions could be very easily implemented by using Django's messaging framework:

https://docs.djangoproject.com/en/1.3/ref/contrib/messages/

[benste (benste)]

I'll take a look at this this evening - as i posted earlier messages
apply for Redering templates - they can't be passed using the redirect
function.

On 03/02/2012 11:46, Florian Fuchs wrote:
> IMO we definitely need some kind of feedback. At the moment the "add
> domain" view only returns some feedback if the action fails (through
> form validation). What's missing is a success message.
>
> I suggest on of these two quite common solutions:
>
> 1.) Successful adding of a domain redirects to a domain detail page,
> where all of the domain's info is displayed, along with a success
> message.
>
> or:
>
> 2.) Redirect to the domain index page, also by displaying a success
> message.
>
> Usually I would opt for solution 1. But since the amount of info per
> domain is rather small, I think the second solution would also be OK in
> this case. Both solutions could be very easily implemented by using
> Django's messaging framework:
>
> https://docs.djangoproject.com/en/1.3/ref/contrib/messages/
>

[Florian Fuchs (flo-fuchs)]

Oh, are you sure about that? I am pretty sure messages survive a redirect... Maybe it's just worth a try?

[benste (benste)]

Even though it's delayed, the messaging framework doesn't survive redirects !

Reffering to
http://stackoverflow.com/questions/1888537/render-to-response-to-a-redirected-url-in-django?

we don't have domain overview pages - asking in IRC right now whether it might be helpful - e.g. for showing list ownership details

[benste (benste)]

sorry, wrong implementation
got the framework in now - next step removing all old message and error statements in favor of

messages.debug(request, '%s SQL statements were executed.' % count)
messages.info(request, 'Three credits remain in your account.')
messages.success(request, 'Profile details updated.')
messages.warning(request, 'Your account expires in three days.')
messages.error(request, 'Document deleted.')