bin/disabled.py is nonfunctional

Bug #937154 reported by Barry Warsaw on 2012-02-20
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GNU Mailman
Low
Unassigned

Bug Description

The bin/disabled.py script needs tests, documentation, and fixing in Mailman 3.

Barry Warsaw (barry) on 2012-02-20
Changed in mailman:
status: New → Confirmed
importance: Undecided → High
milestone: none → 3.0.0b1
Barry Warsaw (barry) on 2012-02-20
description: updated
Barry Warsaw (barry) wrote :

Oh yeah, it should also get moved into a subcommand of bin/mailman, i.e. cli_disable.py

Barry Warsaw (barry) on 2012-03-23
Changed in mailman:
milestone: 3.0.0b1 → postponed
Andrea Crotti (andrea-crotti-0) wrote :

I can try to challenge this problem, only a couple of questions:

- What options should the command have??
  Should it provide exactly the same command line interface?

- Does it need to be independent from the rest of the code or should
  it be added to the mailman commands??

Anything else that I should know?

On Mar 26, 2012, at 08:03 PM, Andrea Crotti wrote:

> Should it provide exactly the same command line interface?

Not necessarily. Looking at the code now I think the long options are
probably fine, but I'm not sure the short options are great (e.g. -o is
usually reserved for output to a file; not relevant for this particular
script, but I don't like appropriating commonly understood options if at all
possible). Also --unknown won't be useful now; that was a nod to some bug in
MM2.1 we never figured out. ;) If you make it a bin/mailman subcommand, you
won't need to re-implement -C here.

>- Does it need to be independent from the rest of the code or should
> it be added to the mailman commands??

I think I would make it a bin/mailman subcommand. One of the main use cases
for this script is to implement a cron job that site admins can enable to
process users in various statuses. But I think a cron could invoke a
subcommand just fine. Still, that use case should inform its cli.

>Anything else that I should know?

One thing to keep in mind is that in mm3, I'm trying to reduce the amount of
logic in the actual commands. Meaning, it would be better to move as much as
possible into core services, and have the command do as little as possible,
over cli parsing and such.

tags: added: easy
Barry Warsaw (barry) on 2012-09-08
Changed in mailman:
milestone: postponed → none
assignee: Barry Warsaw (barry) → nobody
importance: High → Low
Barry Warsaw (barry) wrote :

I'm removing the 'easy' tag because updating this script is wrapped up in work I'm doing on the bounce processing subsystem.

tags: removed: easy
Abhilash Raj (raj-abhilash1) wrote :

This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/34

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers