Makefiles in 2.x use unsafe shell construct that can lead to infinite recursion

Bug #610893 reported by James Westby on 2010-07-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Undecided
Unassigned
Nominated for 2.2 by James Westby

Bug Description

Hi,

I set CDPATH in my zsh shell, and somehow this caused off behaviour in /bin/sh (dash)
when building mailman 2.x.

It somehow stopped "cd $$d" from working when run from a Mailman makefile. While this
was a problem with my environment, the build system's behaviour in the face of it isn't very
nice.

As the Makefiles use

  (cd $$d; make)

if the cd fails, they run the make anyway, which causes infinite recursion.

If this was changed to

  (cd $$d && make)

or

  (make -C $$d)

then this wouldn't happen and you would get an error message, rather than
thrashing.

Thanks,

James

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers