Add support for digest_size_threshold = 0

Bug #558274 reported by mherdeg on 2007-04-30
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GNU Mailman
Status tracked in 3.0
2.1
Wishlist
Mark Sapiro
3.0
Wishlist
Unassigned

Bug Description

This patch results in no more than one digest being sent per day if digest_size_threshold is set to zero.

This behavior is documented at http://www.gnu.org/software/mailman/mailman-admin/node19.html:
"Set this variable to zero to specify that there is no size threshold, in which case no more than one digest will be sent out per day."

ToDigest.py does not currently implement this behavior. Under the current code, a threshold of zero will always be exceeded, so digest mode will not result in any reduction of traffic for recipients (and will in fact increase message size.) This patch expands the test to check the zero case.

Related branches

mherdeg (mherdeg) wrote :

The file ToDigest.py.diff was added: rcsdiff output on ToDigest.py

Jeff White (jwhite530) wrote :

I just ran into this bug as well. This could be resolved by changing ToDigest.py something like the attached patch. I see tests/test_handlers.py sets mlist.digest_size_threshhold to zero in test_send_a_digest() so this may break that if it relies on the current incorrect behavior.

Mark Sapiro (msapiro) wrote :

The referenced documentation has been changed to reflect current behavior. The admin help for digest_size_threshhold never said that 0 meant unlimited, so I'm marking this as "wishlist" for the moment, but targeting implementation for 2.1.16.

Changed in mailman:
assignee: nobody → Mark Sapiro (msapiro)
importance: Undecided → Wishlist
milestone: none → 2.1.16
status: New → Confirmed
Mark Sapiro (msapiro) on 2013-03-11
Changed in mailman:
status: Confirmed → Fix Committed
Barry Warsaw (barry) wrote :

Adding a MM3 bug task since this seems like it might be interesting for Mailman 3.

tags: added: mailman3
Abhilash Raj (raj-abhilash1) wrote :

This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/48

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers