Log error on screwed-up template in archiver

Bug #558254 reported by kink on 2006-08-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Low
Mark Sapiro

Bug Description

Hello!

Bob Tanner supplied us with the following patch to add
logging to the code that handles really "screwed up
templates" so the admin can more easily see what has
gone wrong.

Please consider, thanks!

Thijs

--- HyperArch.py 2003-12-26 14:41:30.000000000 -0600
+++ HyperArch.py-bob 2005-11-23 03:19:13.000000000 -0600
@@ -217,8 +217,9 @@

Utils.GetCharSet(lang),
                                     'replace')
                 text = sdict.interpolate(utemplate)
- except (TypeError, ValueError):
+ except (TypeError, ValueError), e:
             # The template is really screwed up
+ syslog('error', 'The template is really
screwed up: %s\n',
e)
             pass
     # Make sure the text is in the given character
set, or html-ify any
     # bogus
     # characters.

Related branches

akuchling (akuchling) wrote :

Logged In: YES
user_id=11375
Originator: NO

I've attached a patch file including this change, but haven't actually tested the code with the patch yet.

File Added: mailman-archiver-template.diff

akuchling (akuchling) wrote :

The file mailman-archiver-template.diff was added: Patch to HyperArch.py

Mark Sapiro (msapiro) on 2013-07-12
Changed in mailman:
assignee: nobody → Mark Sapiro (msapiro)
importance: Undecided → Low
milestone: none → 2.1.16
status: New → Triaged
Mark Sapiro (msapiro) on 2013-07-12
Changed in mailman:
status: Triaged → Fix Committed
Mark Sapiro (msapiro) on 2013-07-14
Changed in mailman:
milestone: 2.1.16 → 2.1.16rc1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers