Fix MIME digest attachment

Bug #558052 reported by tkikuchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
Undecided
Unassigned

Bug Description

ToDigest.py in Mailman 2.1.1 was improved in handling
plain text digest but there was a side effect in MIME
digest.
We should now use copy of Message instance because the
original is scrubbed afterwards.

Revision history for this message
tkikuchi (tkikuchi-users) wrote :

The file ToDigest.py.diff.txt was added: ToDigest.py patch 2.1.1

Revision history for this message
dwighternest (dwighternest) wrote :

Logged In: YES
user_id=740960

After I applied this patch, I started to receive uncaught
exceptions leading to 100% of my postings being shunted.

Apr 08 10:03:57 2003 (20895) Uncaught runner exception:
'module' object has no attribute 'process'
Apr 08 10:03:57 2003 (20895) Traceback (most recent call last):
  File "/var/mailman/Mailman/Queue/Runner.py", line 105, in
_oneloop
    self._onefile(msg, msgdata)
  File "/var/mailman/Mailman/Queue/Runner.py", line 155, in
_onefile
    keepqueued = self._dispose(mlist, msg, msgdata)
  File "/var/mailman/Mailman/Queue/VirginRunner.py", line
38, in _dispose
    return IncomingRunner._dispose(self, mlist, msg, msgdata)
  File "/var/mailman/Mailman/Queue/IncomingRunner.py", line
130, in _dispose
    more = self._dopipeline(mlist, msg, msgdata, pipeline)
  File "/var/mailman/Mailman/Queue/IncomingRunner.py", line
153, in _dopipeline
    sys.modules[modname].process(mlist, msg, msgdata)
AttributeError: 'module' object has no attribute 'process'

Apr 08 10:03:57 2003 (20895) SHUNTING:
1049803236.489061+24037ff46bd58f849bf9a9646db1dd90bb863d2c

Revision history for this message
tkikuchi (tkikuchi-users) wrote :

Logged In: YES
user_id=67709

This patch is only 3 lines. Please check if your
Handlers/ToDigest.py was properly patched. I can't see
anything related to this patch from your traceback log.

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

The patch looks good, so I'm closing this in anticipation
that testing will work out.

I'm with tkikuchi though, I can't see how this patch could
possibly evoke dwighternest's bug.

Revision history for this message
mrjc (mrjc-users) wrote :

Logged In: YES
user_id=50125

did this make 2.1.3?

I'm still getting this:
http://cp1.myhostdns.org/pipermail/webmasters_mbssrc.com/
2003-October/000025.html whenever my users post HTML
messages.

Thanks, M.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.