SpamAssassin handler

Bug #557991 reported by jparise
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GNU Mailman
New
Undecided
Unassigned

Bug Description

I've updated the existing SpamAssassin patch (534577)
for Mailman 2.1.

Revision history for this message
jparise (jparise-users) wrote :

The file SpamAssassin.py was added: SpamAssassin handler

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

I'm only moving this to the MM2.2/3.0 group so I can
concentrate on patches for 2.1.

Revision history for this message
jparise (jparise-users) wrote :

Logged In: YES
user_id=485579

The attached patch adds the SpamAssassin handler to
Mailman's mail processing pipelines.

Revision history for this message
jparise (jparise-users) wrote :

The file Defaults.py.in.diff was added: Add SpamAssassin handler to pipelines

Revision history for this message
jparise (jparise-users) wrote :

Logged In: YES
user_id=485579

I've updated the SpamAssassin handler to report a more
detailed reason when a DiscardMessage and HoldMessage
exception is raised.

Revision history for this message
jparise (jparise-users) wrote :

The file SpamAssassin.py was added: SpamAssassin handler

Revision history for this message
shamanicacid (shamanicacid) wrote :

Logged In: YES
user_id=698712

I am a bit confused in which SpamAssassin.py file to use.
There does not seem to be an embedded version number in the
download links.

The diff I see is as follows:

$ diff SpamAssassin.1.py SpamAssassin.py
62,65d61
< # First, play footsie with _ so that the following are
marked as translated,
< # but aren't actually translated until we need the text
later on.
< def _(s):
< return s
71,73d66
< reason = _('SpamAssassin identified this message as spam')
< rejection = _('You message was identified as spam.')
<
78,80d70
< reason = _('SpamAssassin identified this message as spam')
< rejection = _('You message was identified as spam.')
<

Question # 1. Do I want to use the SpamAssassin.py file with
the "footsie" code?

Question # 2. Does the SpamAssassin.py code allow for
exceptions when the e-mail is from the $list-owner ( bounces
to moderator ) ?

I ask because I ran into a problem with a mailer-loop
occuring when SpamAssassin errantly tagged the $list-owner
moderator bounces as spam. ( spamassasin marks pending
e-mails from $list-owner with score 7.6 )

I have not read through all the code, I am curious if
mlist.isMember(sender) includes the owner alias?

Many Thanks in Advance

Revision history for this message
jparise (jparise-users) wrote :

Logged In: YES
user_id=485579

Yes, use the version with the "footsie" code. I don't
appear to have permission to delete the older version from
this patch tracker.

It doesn't make any special exceptions with regard to the
list owner, but I'll have a look at making that part of the
logic smarter.

Revision history for this message
jafo (jafo-users-sf) wrote :

Logged In: YES
user_id=81797

I can't get this code to work with Mailman 2.1. A message
that triggers the hold for moderator starts bouncing
messages from the list owner and just sits in a mail loop
until I remove SpamAssassin from the filter chain,
delivering a message for every loop to the admin interface.

I spent a couple of hours looking at it, but I can't see why
it is doing this. It's defeinitely in the
Hold.hold_for_whatever, but I don't know why that's failing.

Just thought I'd mention it. I guess we'll stay with 2.0
where it's working fine with the other patch-set.

Sean

Revision history for this message
filfil (filfil-users) wrote :

Logged In: YES
user_id=243444

Is it possible to modify that code so that it calls the classic spamassassin if the spamd daemon is not running? (Or is it already functioning this way?)

Revision history for this message
jhenstridge (jhenstridge) wrote :

Logged In: YES
user_id=146903

If you haven't assigned copyright for your work to the FSF,
don't say that your code is copyrighted by the FSF. Doing
so could cause problems in the event of a lawsuit. Accurate
copyright notices are essential.

In answer to filfil's question, the code requires that spamd
is running. However, if it can't contact spamd for some
reason, the message will pass this filter, so that mail
doesn't get lost.

Revision history for this message
Mark Sapiro (msapiro) wrote :

See https://bugs.launchpad.net/mailman/+bug/266588 which is the LP incarnation of SF patch 534577. That item has more up to date and complete code than this one.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.