Makefile fix so that errors propagate

Bug #557944 reported by noa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
Undecided
Unassigned

Bug Description

While I was trying to build mailman-2.1b1 as an rpm i
encountered problems with my python installation that
made the build in misc fail. Unfortunately, the error
didn't propagate to the toplevel make process so it
took some time to track down. The attached patch simply
propagates any errors from make subprocesses to the
topelevel make in an automake like fashion.

Revision history for this message
noa (noa) wrote :

The file mailman-2.1b1.makefile-propagate-error.patch was added: simple makefile fix

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

I think a more comprehensive solution might be necessary. I
introduced a delivery mistake (calling it email-2.0.3 in
misc/Makefile.in) and the build process didn't stop.

Revision history for this message
noa (noa) wrote :

Logged In: YES
user_id=24013

Since english is not my first language I don't understand
what you mean with 'comprehensive'. Does it indicate that my
patch is hard to understand? (Sounds unlikely to me)

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

No problem. No the patch was easy to understand, I just
don't think it goes far enough. See the simple mistake I
introduced that didn't stop the build process.

By comprehensive I mean that more Makefile.in's probably
need to be patched so that any error in any of them will
stop the build process.

Revision history for this message
bwarsaw (bwarsaw) wrote :

Logged In: YES
user_id=12800

I'm inclined to close this one. On further reflection,
while it can be a pain sometimes if a build fails, at other
times I want the build to continue and do as much as possible.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.