MM3: syntax errors and test failures on Mac OS X

Bug #418598 reported by Stephen Turnbull
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
High
Barry Warsaw

Bug Description

I don't actually expect to run Mailman on this box, but I needed a copy to work on in a comfortable environment.<wink>

'Long as I'm here, may as well build and test. Build threw up a bunch of syntax errors, since I don't know the code yet, I'm not going to try to analyze. Test reports two failures. Transcript of build and test run attached as beta.err.20090825213949.

Environment:
Mac OS X 10.5.8 on Intel.
Python 2.6.2 (MacPorts release 4).

Revision history for this message
Stephen Turnbull (stephen-xemacs) wrote :
Revision history for this message
Barry Warsaw (barry) wrote :

The syntax error looks like a problem with pylint, which is kind of in a sorry state. The pylint dependency isn't important though; it only helps keep the code clean, it's not essential to Mailman's operation.

The two test failures are real bugs. I've seen the 'dict changed size' problem before, though it's difficult to test deterministically (I still think I have a fix for that). The other one I've not seen before, but will look into it. It could be a locale problem.

Changed in mailman:
assignee: nobody → Barry Warsaw (barry)
importance: Undecided → High
milestone: none → 3.0.0a4
status: New → Triaged
Revision history for this message
Barry Warsaw (barry) wrote :

I think pylint 0.18 is not compatible with "from __future__ import absolute_import". I've contacted the pylint list about that.

I think I've fixed the master.txt problem. It's difficult to reproduce and there are no tests for this particular feature because of the signals involved here. Still, I think the code is defensive enough not to cause this to happen.

The digester.txt failure is caused by your problem with msgfmt. digester.txt requires that the .mo file be generated. On OSX 10.5, I'm using msgfmt 0.17 from MacPorts.

Changed in mailman:
status: Triaged → Fix Committed
Barry Warsaw (barry)
Changed in mailman:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.