syntax error in CheckFixUid.py

Bug #266387 reported by Chris-ress
2
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
Medium
Unassigned

Bug Description

bin/CheckFixUid.py is created by bin/check_perms_grsecurity.py. It has a
syntax error that keeps mailman from starting up.

Reproducable: always

Steps to reproduce:
1. run bin/check_perms_grsecurity.py -f
2. run bin/mailmanctl start

The error:
NameError: name 'uid' is not defined
Traceback (most recent call last):
  File "/usr/local/mailman/bin/qrunner", line 80, in ?
    import CheckFixUid
  File "/usr/local/mailman/bin/CheckFixUid.py", line 6, in ?
    class CheckFixUid:
  File "/usr/local/mailman/bin/CheckFixUid.py", line 12, in CheckFixUid
    if os.geteuid() != uid:

A proposed fix is attached.

[http://sourceforge.net/tracker/index.php?func=detail&aid=1660666&group_id=103&atid=100103]

Revision history for this message
Chris-ress (chris-ress) wrote :
Revision history for this message
Chris-ress (chris-ress) wrote :

Originator: YES

I forgot: You need to start Mailman as root for the error to occur.

Revision history for this message
Mark Sapiro (msapiro) wrote :

Originator: NO

These are not GNU Mailman scripts. They must be part of some
redistribution. Please report this bug to your packager. There's nothing
the Mailman project can do about it.

Revision history for this message
Chris-ress (chris-ress) wrote :

Originator: YES

Since it is part of the official distribution and is also in you SVN, I
thought you'd like to quickly apply a fix to it.

Anyway, I'll contact the contributor.

Revision history for this message
Mark Sapiro (msapiro) wrote :

Originator: NO

Perhaps I am mistaken. Can you tell me the exact path to where you found
check_perms_grsecurity.py in either the Mailman 2.1.9 tarball or SVN?

Revision history for this message
Mark Sapiro (msapiro) wrote :

Originator: NO

Never Mind!

I was originally looking at my installed Mailman that doesn't include the
contrib directory. I see that it is in the contributed software for which
the README says:
<quote>
This directory contains unofficial contributed scripts and extensions
to Mailman. They are unsupported by the Mailman developers. If you
have questions or problems with them, please contact the contribution
author directly.
</quote>

However, since the patch is so simple and obvious, I'll go ahead and patch
it.

Revision history for this message
Chris-ress (chris-ress) wrote :

Originator: YES

No Problem, thanks for patching it!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.