add-dup-header traceback

[Jcataldo]

I think I've found a bug in Mailman from Fedora Core 1
(all errata applied). Every time someone sends a
message to a list and includes in the To: or Cc: header
the address of a member, a traceback like the following
appears in logs/error and the message is shunted:

----------------------------------
Traceback (most recent call last):
  File "/var/mailman/bin/qrunner", line 270, in ?
    main()
  File "/var/mailman/bin/qrunner", line 230, in main
    qrunner.run()
  File "/var/mailman/Mailman/Queue/Runner.py", line 65,
in run
    filecnt = self._oneloop()
  File "/var/mailman/Mailman/Queue/Runner.py", line 93,
in _oneloop
    msg, msgdata = self._switchboard.dequeue(filebase)
  File "/var/mailman/Mailman/Queue/Switchboard.py",
line 156, in dequeue
    data = self._ext_read(dbfile)
  File "/var/mailman/Mailman/Queue/Switchboard.py",
line 334, in _ext_read
    execfile(filename, dict)
  File
"/var/mailman/qfiles/out/1078272688.60232+88a4bf4cb1ad84bb7e897338fb28343d9
8042476.db",
line 5
    add-dup-header = {'<email address hidden>': 1,
'<email address hidden>': 1}
SyntaxError: can't assign to operator
----------------------------------

For this example, I created a list whose members are my
girlfriend and me, and then I sent a message with us in
the Cc:

I've studied the 107827...42476.db file, and the value
"add-dup-header" seems to be wrong (I don't know
anything about the Mailman internals, so please don't
flame me). If I change it to "add_dup_header" and run
bin/unshunt, the message is processed without errors.

I don't know if this breaks something, but as a
workaround I've edited
Mailman/Handlers/AvoidDuplicates.py and
Mailman/Handlers/SMTPDirect.py to replace
"add-dup-header" for "add_dup_header" and the problem
stopped happening.

[http://sourceforge.net/tracker/index.php?func=detail&aid=908709&group_id=103&atid=100103]