mailman-config incorrect quoting in print statement

Bug #1774986 reported by Robert Arends
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Low
Mark Sapiro

Bug Description

As found in this newly included file bin/mailman-config

The following 2 lines have extra quotes.
print "mail_group: %s" % ""mail", "postfix", "mailman", "nobody", "daemon""
print "cgi_group: %s" % ""apache""

Editing to remove the extra quotes works.
print "mail_group: %s" % "mail", "postfix", "mailman", "nobody", "daemon"
print "cgi_group: %s" % "apache"

Thanks.
Rob.

Related branches

Revision history for this message
Mark Sapiro (msapiro) wrote :

This occurs because the values in the --with-mail-gid= and --with-cgi-gid= options passed to configure were quoted. Normally, they will not be. Whoever created your package should adjust their configure command options to remove unnecessary quoting.

Doesn't this also affect the

print "configure_opts: ...

line?

This occurs because the values in the --with-mail-gid= and --with-cgi-gid= options passed to configure were quoted
That said, I have changed the parameter quoting in bin/mailman-config from double to single quotes which should help.

Changed in mailman:
assignee: nobody → Mark Sapiro (msapiro)
importance: Undecided → Low
milestone: none → 2.1.27
status: New → Fix Committed
Revision history for this message
Robert Arends (swordfish90s) wrote :

My configure_opts line is as follows (I have not edited this line).

print "configure_opts: \"%s\"" % "--libdir=/usr/lib --prefix=/usr/lib/mailman --with-var-prefix=/var/lib/mailman --with-config-dir=/etc/mailman --with-lock-dir=/var/lock/mailman --with-log-dir=/var/log/mailman --with-pid-dir=/var/run/mailman --with-queue-dir=/var/spool/mailman --with-template-dir=/etc/mailman/templates --with-python=/usr/bin/python --with-mail-gid=mail postfix mailman nobody daemon --with-cgi-id=apache --with-cgi-gid=apache --with-mailhost=localhost.localdomain --with-urlhost=localhost.localdomain --without-permcheck"

The package was obtained from:
-> rpmfind.net mailman-2.1.26-1.fc29.x86_64
Other than that I don't know the packager.

I will admit that I'm running it on CentOS7.5.1804

OT (FYI)
I'm not using Archives at all, but everything else including virtual domains are working after a migration from RHEL5/mailman-2.1.9-8.el5_11
Including the reCaptcha on the subscription page - main reason for migrating.

Thanks - great work.

Revision history for this message
Robert Arends (swordfish90s) wrote :

Mark,

it was likely quoted by the packager because there are multiple values provided, and an assumption would be that quoting would be necessary. I certainly would have assumed the next line needed quoting. But then I'm not familiar with compiling my own.

--with-mail-gid=mail postfix mailman nobody daemon

Thanks, Rob.

Revision history for this message
Mark Sapiro (msapiro) wrote :

I'm not sure what's going on. Your 'configure_opts:' says '--with-cgi-gid=apache' and '--with-mail-gid=mail postfix mailman nobody daemon' which doesn't quote the values, yet the individual values set by configure are quoted. Yet, in my development environment before changing the quotes, I see:

print "mail_group: %s" % "mark"
print "cgi_group: %s" % "www-data"

and

print "configure_opts: \"%s\"" % "--prefix=/var/MM/21 --with-username=mark --with-groupname=mark --with-cgi-gid=www-data --with-mail-gid=mark --with-mailhost=msapiro.net --with-urlhost=msapiro.net"

I.e. '--with-cgi-gid=www-data' does not produce

print "cgi_group: %s" % ""www-data""

whereas in your case, '--with-cgi-gid=apache' does produce

print "cgi_group: %s" % ""apache""

The difference is something in configure on the system on which the package was built, but even then, why does it affect mail_group and cgi_group and not, e.g., var_prefix, mailman_user and mailman_group?

Anyway, I did replace the double quotes with single quotes and that should fix it.

Mark Sapiro (msapiro)
Changed in mailman:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers