Postgresql support is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| GNU Mailman |
Critical
|
Aurélien Bompard |
Bug Description
The support for postgresql database backend is broken (I guess after the python3 port). The details of the failures can be found here with the continuous integration on gitlab https:/
Related branches
- Mailman Coders: Pending requested 2015-04-22
-
Diff: 70 lines (+11/-2)5 files modifiedsrc/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py (+3/-1)
src/mailman/database/alembic/versions/46e92facee7_add_serverowner_domainowner.py (+1/-0)
src/mailman/docs/RELEASENOTES.rst (+4/-0)
src/mailman/model/user.py (+1/-0)
src/mailman/model/workflow.py (+2/-1)
- Barry Warsaw: Approve on 2015-04-22
-
Diff: 122 lines (+25/-17)4 files modifiedsrc/mailman/bin/master.py (+5/-5)
src/mailman/database/factory.py (+6/-0)
src/mailman/database/postgresql.py (+9/-5)
src/mailman/utilities/importer.py (+5/-7)
Changed in mailman: | |
milestone: | none → 3.0.0 |
importance: | Undecided → High |
status: | New → Triaged |
Barry Warsaw (barry) wrote : | #1 |
Changed in mailman: | |
status: | Triaged → Confirmed |
importance: | High → Critical |
Barry Warsaw (barry) wrote : | #2 |
Try running the following:
$ MAILMAN_
where you replace the path to the postgres.cfg with one of your own as described in src/mailman/
Pretty quickly we hit an exception:
=======
ERROR: LayerSuite
-------
Traceback (most recent call last):
File "/home/
context)
File "/home/
cursor.
psycopg2.
LINE 1: ...LECT setval(
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/
reset_
File "/home/
config.
File "/home/
self.
File "/home/
"""
File "/home/
bind, close_with_
File "/home/
return meth(self, multiparams, params)
File "/home/
return connection.
File "/home/
compiled_sql, distilled_params
File "/home/
context)
File "/home/
exc_info
File "/home/
reraise(
File "/home/
raise value.with_
File "/home/
context)
File "/home/
Aurélien Bompard (abompard) wrote : | #3 |
Alright I just linked to a branch with 4 commits fixing all the PostgreSQL issues. Please review, I may have left print statements in the code... ;-)
Barry Warsaw (barry) wrote : | #4 |
Thanks! Looking over the diff I think I understand all the changes. I'm running the test suite now for both pg and sqlite.
The one change I don't understand is to the importer code. Why did you choose to do it this way instead of the old way?
Changed in mailman: | |
assignee: | nobody → Aurélien Bompard (abompard) |
status: | Confirmed → Fix Committed |
Changed in mailman: | |
status: | Fix Committed → Fix Released |
Ug. Lots of pg failures :(