Non-queue runners should not create var/queue/* directories
Bug #1095422 reported by
Barry Warsaw
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
GNU Mailman |
Fix Released
|
Low
|
Unassigned |
Bug Description
The LMTP and REST runners are not queue runners. They are daemon processes which do not scan directories. They should not create directories in var/queue, probably by disabling the creation of the Switchboard in their subclass.
Related branches
lp:~sakuag333/mailman/my-branch
- Barry Warsaw: Pending requested
-
Diff: 39 lines (+14/-6)1 file modifiedsrc/mailman/core/switchboard.py (+14/-6)
lp:~sakuag333/mailman/non-queue-runner
- Barry Warsaw: Needs Fixing
-
Diff: 39 lines (+14/-6)1 file modifiedsrc/mailman/core/switchboard.py (+14/-6)
lp:~sakuag333/mailman/BUG_non_queue_runner
Merged
into
lp:mailman
- Barry Warsaw: Pending requested
-
Diff: 204 lines (+48/-13)8 files modifiedsrc/mailman/config/mailman.cfg (+2/-0)
src/mailman/core/runner.py (+9/-3)
src/mailman/core/switchboard.py (+13/-10)
src/mailman/interfaces/runner.py (+4/-0)
src/mailman/rest/tests/test_root.py (+7/-0)
src/mailman/runners/lmtp.py (+5/-0)
src/mailman/runners/rest.py (+1/-0)
src/mailman/runners/tests/test_lmtp.py (+7/-0)
Changed in mailman: | |
status: | Triaged → Fix Committed |
Changed in mailman: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
in mailman.app.config , there is function _expand_paths(self) which contains :
queue_dir = category.queue_dir
this results in queue_dir to get added to self.path
and thus when ensure_ directories_ exist() is being called in config.py , it make a directory var/queue
removing "queue_dir = category.queue_dir " will not allow the directory to be formed.
Since i am new to mailman, can you please guide me , how to push this change to mailman 3 code ?