bin/mailman --help could be improved

Bug #1035033 reported by Stephen Turnbull
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNU Mailman
Fix Released
High
Barry Warsaw

Bug Description

What the "reopen" command does is not at all clear. (Is it like "reload" in an init script, rereading config files? If so, maybe "reload" would be a better name.)

Presumably the "restart" command stops *and* starts the runners.

You can assign this to me (it would be appreciated if you'd tell me what reopen does, although I guess I could read the code. :-)

Tags: mailman3
Barry Warsaw (barry)
tags: added: mailman3
Revision history for this message
Barry Warsaw (barry) wrote :

The 'reopen' command essentially causes the master watcher to SIGHUP the runner subprocesses. Right now all this does is reopen their log files, so it's there primarily to support log rotation. It would be nice if the runners could re-read their configuration files, but I suspect that will be difficult. Also, for correctness, the master should also re-read the configuration file.

Yep, restart causes the master to SIGUSR1 all the runners. They exit, but with a status that the master recognizes as a restart, so it does. This does have the effect of reloading all the configuration files of course, but only for the runners, not for the master (though it may not matter much).

Take a look at src/mailman/bin/runner.py for details. I'll assign this to you, unmilestoned. If you want to take a crack at config file reloaded, go for it, but if not (i.e. starting and stopping might be good enough), just mark this as Invalid.

Changed in mailman:
importance: Undecided → Low
status: New → Confirmed
importance: Low → Wishlist
assignee: nobody → Stephen Turnbull (stephen-xemacs)
Revision history for this message
Barry Warsaw (barry) wrote :

I'm going to take a strict approach to this bug, and will attempt to improve the documentation.

Changed in mailman:
status: Confirmed → In Progress
milestone: none → 3.0.0b3
assignee: Stephen Turnbull (stephen-xemacs) → Barry Warsaw (barry)
importance: Wishlist → High
status: In Progress → Fix Committed
Barry Warsaw (barry)
Changed in mailman:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.