Non-string in msgdata breaks pending requests

[Robert Niederreiter]

msgdata['received_time'] in mailman.app.moderator.hold_message contains datetime.datetime object when being called.

this causes hold_request to fail -> it expects only strings as additional data.

so either remove received_time like so:

http://bazaar.launchpad.net/~rnix/mailman/anon-subscribe/revision/7159

before calling hold_request,

convert received_time to string before calling hold_request,

or improve mailman.model.request.ListRequests.hold_request as already commented in source code (maybe to also accept datetime instances?)

cheers,

robert

[Barry Warsaw (barry)]

Bernard, are you actually going to try to fix this?

[Barry Warsaw (barry)]

Bernard, why did you change the status to Fix Released? The bug hasn't even been confirmed, let alone fixed, let alone fixed in a released version of Mailman. I don't even see a patch or branch attached to this bug.

This is not the first time you've done something like this.

If you want some help understanding how our process works in the GNU Mailman project, please email me directly and I will help you. Otherwise, *please* *stop* *doing* *this*. It is only annoying us, causing us to do extra work, and generally giving you a very poor reputation for working with open source projects. If you're serious about contributing, and genuinely want to improve the way you interact with us, I would gladly help you, but until then we will have to treat such actions as spam.

[Robert Niederreiter (rnix)]

I have committed a fix for this issue here.

http://bazaar.launchpad.net/~rnix/mailman/anon-subscribe/revision/7163

Can you merge this back to the master please?

-Robert

[Barry Warsaw (barry)]

Hi Robert. Apologies for the delay in responding. Summer vacations and all. I did end up fixing this in a more general way, by ensuring that all values are pickled if they are not str or unicode. I think it's a programming error if the key is ever non-str/unicode so that raises an exception. I also mangle the key name when using a pickle so that unpending the data can restore the original object.

Thanks very much for the contribution to Mailman!