SAML is removing people from institutions when it shouldn't

[Robert Lyon]

With the addition of affiliated institutions code in SAML - that is, pass in a list of institutions the person is associated with over and above the one the SAML instance is connected to, so we can add the user to multiple institutions at once. There was a bit of code to remove them from institutions that they are not associated with anymore on login.

But the problem with that bit of code was it runs even if the affiliated institutions are not being used.

We need to only do the removal of associated institutions if the SAML instance is set up to handle affiliations

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12788

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12788
Committed: https://git.mahara.org/mahara/mahara/commit/6de118d76467a39163e6c2772273163287deee43
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 6de118d76467a39163e6c2772273163287deee43
Author: Robert Lyon <email address hidden>
Date: Mon May 23 09:04:23 2022 +1200

Bug 1975428: Need to check if affiliations are used before removing old ones

Change-Id: I19313946e2137a796f0fc47e3b61e2ace0494e6f
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13026

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13026
Committed: https://git.mahara.org/mahara/mahara/commit/46483b694e2c8eb11ba95bbb0e5fa6888755065e
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 46483b694e2c8eb11ba95bbb0e5fa6888755065e
Author: Robert Lyon <email address hidden>
Date: Mon May 23 09:04:23 2022 +1200

Bug 1975428: Need to check if affiliations are used before removing old ones

Change-Id: I19313946e2137a796f0fc47e3b61e2ace0494e6f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6de118d76467a39163e6c2772273163287deee43)